Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu 
On Thu, 10 Mar 2022 17:25:55 GMT, Naoto Sato  wrote:

> LGTM. Thanks for the fix!

Thanks for the review.

-

PR: https://git.openjdk.java.net/jdk/pull/7775

Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Naoto Sato 
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu  wrote:

> Please review this trivial patch to correct last parameter of 
> `GetStringChars()` call, which should be a  `jboolean*`, instead of `jboolean`

LGTM. Thanks for the fix!

-

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7775

Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Zhengyu Gu 
On Thu, 10 Mar 2022 15:28:15 GMT, Aleksey Shipilev  wrote:

> Looks fine to me.

Thanks, @shipilev

-

PR: https://git.openjdk.java.net/jdk/pull/7775

Re: RFR: 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c

2022-03-10 Thread Aleksey Shipilev 
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu  wrote:

> Please review this trivial patch to correct last parameter of 
> `GetStringChars()` call, which should be a  `jboolean*`, instead of `jboolean`

Looks fine to me.

-

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7775