Re: RFR: JDK11U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-28 Thread Naoto Sato 

+1

Naoto

On 1/28/19 3:19 AM, Chris Hegarty wrote:



On 26/01/2019 10:57, Deepak Kejriwal wrote:

Hi All,


JBS report: https://bugs.openjdk.java.net/browse/JDK-8212941

Webrev: http://cr.openjdk.java.net/~rpatil/8212941/jdk11u/webrev.00/


This looks good Deepak. Reviewed.

One minor comment. "The of(int) and valueOf(String) methods ...", these
references could be javadoc links.

Re: RFR: JDK11U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-28 Thread Chris Hegarty 




On 26/01/2019 10:57, Deepak Kejriwal wrote:

Hi All,

  


JBS report: https://bugs.openjdk.java.net/browse/JDK-8212941

Webrev: http://cr.openjdk.java.net/~rpatil/8212941/jdk11u/webrev.00/


This looks good Deepak. Reviewed.

One minor comment. "The of(int) and valueOf(String) methods ...", these
references could be javadoc links.