Re: RFR: JDK11U JDK-8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-28 Thread Chris Hegarty 



On 25/01/2019 18:35, Deepak Kejriwal wrote:

Hi All,

  


JBS report: https://bugs.openjdk.java.net/browse/JDK-8216546

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Erpatil/8216546/"http://cr.openjdk.java.net/~rpatil/8216546/


This change looks good Deepak. Reviewed.

I have added myself as Reviewer on the CSR.

Trivially, can you please update the copyright year before
pushing.

-Chris.

Re: RFR: JDK11U JDK-8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-25 Thread Roger Riggs 

+1

On 01/25/2019 02:11 PM, naoto.s...@oracle.com wrote:

Looks good to me.

Naoto

On 1/25/19 10:35 AM, Deepak Kejriwal wrote:

Hi All,


JBS report: https://bugs.openjdk.java.net/browse/JDK-8216546

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Erpatil/8216546/"http://cr.openjdk.java.net/~rpatil/8216546/


Summary:

As per previous communication from Iris[0], a maintenance review for 
Java SE 11 is planned. JDK-8216546 focuses on the java.lang.Character 
specification changes.


The specification is modified to allow the new Japanese Era code 
point (U+32FF). This code point is expected to be assigned in version 
12.1 of the Unicode Standard.


Specification changes are covered in this review. A follow up code 
review will be carried out for implementation changes.


[0]: 
http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2018-December/000308.html




Regards,

Deepak

Re: RFR: JDK11U JDK-8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-25 Thread naoto . sato 

Looks good to me.

Naoto

On 1/25/19 10:35 AM, Deepak Kejriwal wrote:

Hi All,

  


JBS report: https://bugs.openjdk.java.net/browse/JDK-8216546

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Erpatil/8216546/"http://cr.openjdk.java.net/~rpatil/8216546/

Summary:

As per previous communication from Iris[0], a maintenance review for Java SE 11 
is planned. JDK-8216546 focuses on the java.lang.Character specification 
changes.

The specification is modified to allow the new Japanese Era code point 
(U+32FF). This code point is expected to be assigned in version 12.1 of the 
Unicode Standard.

Specification changes are covered in this review. A follow up code review will 
be carried out for implementation changes.

[0]: 
http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2018-December/000308.html

  

  


Regards,

Deepak