Re: RFR 8032221 Typo in java.util.date

2014-01-31 Thread Joe Darcy 

On 01/31/2014 10:33 AM, roger riggs wrote:

Please review a typo and javadoc cleanup for java.util.Date

webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/

Thanks, Roger



Looks good Roger.

Cheers,

-Joe

Re: RFR 8032221 Typo in java.util.date

2014-01-31 Thread Chris Hegarty 
trancate - truncate . Other cleanups look good too.

-Chris.

On 31 Jan 2014, at 18:33, roger riggs roger.ri...@oracle.com wrote:

 Please review a typo and javadoc cleanup for java.util.Date
 
 webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/
 
 Thanks, Roger

Re: RFR 8032221 Typo in java.util.date

2014-01-31 Thread Lance Andersen - Oracle 
looks fine.  getting rid of tt and code, is something  I guess we  should 
look to do throughout all of our code?
On Jan 31, 2014, at 1:33 PM, roger riggs wrote:

 Please review a typo and javadoc cleanup for java.util.Date
 
 webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/
 
 Thanks, Roger
 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR 8032221 Typo in java.util.date

2014-01-31 Thread Joe Darcy 

On 01/31/2014 10:44 AM, Lance Andersen - Oracle wrote:

looks fine.  getting rid of tt and code, is something  I guess we  should 
look to do throughout all of our code?


Yes :-)

In the core libraries, Jason did some bulk conversions along those lines 
in JDK 8:


JDK-8017324 Cleanup of the javadoc code tag in java.security.*

etc.

For JDK 9, normalizing to {@code} has been proposed earlier:

http://mail.openjdk.java.net/pipermail/jdk9-dev/2013-December/000141.html

Thanks,

-Joe


On Jan 31, 2014, at 1:33 PM, roger riggs wrote:


Please review a typo and javadoc cleanup for java.util.Date

webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/

Thanks, Roger




Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com