Review request for JDK-8030010: cleanup native code warnings

2014-02-12 Thread Mandy Chung
This patch cleans up a few trivial native warnings (mainly remove local 
unreferenced variable)

   https://bugs.openjdk.java.net/browse/JDK-8030010

Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8030010/webrev.00/

This patch was contributed by Francis Andre [1] and I fixed a couple 
other trivial ones.


Mandy
[1] 
http://mail.openjdk.java.net/pipermail/build-dev/2013-December/011332.html


Re: Review request for JDK-8030010: cleanup native code warnings

2014-02-12 Thread Lance Andersen - Oracle
Hi Mandy

This looks OK to me

On Feb 12, 2014, at 12:46 PM, Mandy Chung wrote:

 This patch cleans up a few trivial native warnings (mainly remove local 
 unreferenced variable)
   https://bugs.openjdk.java.net/browse/JDK-8030010
 
 Webrev at:
 http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8030010/webrev.00/
 
 This patch was contributed by Francis Andre [1] and I fixed a couple other 
 trivial ones.
 
 Mandy
 [1] http://mail.openjdk.java.net/pipermail/build-dev/2013-December/011332.html


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com



Re: Review request for JDK-8030010: cleanup native code warnings

2014-02-12 Thread Alan Bateman

On 12/02/2014 17:46, Mandy Chung wrote:
This patch cleans up a few trivial native warnings (mainly remove 
local unreferenced variable)

   https://bugs.openjdk.java.net/browse/JDK-8030010

Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8030010/webrev.00/

This patch was contributed by Francis Andre [1] and I fixed a couple 
other trivial ones.
This looks good and nice to see the native code warnings getting a bit 
attention.


-Alan.