Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v21]

2022-11-23 Thread Andrew Haley
On Tue, 22 Nov 2022 17:34:22 GMT, Andrew Haley  wrote:

>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into 
> JDK-828
>  - Update src/java.base/share/classes/java/lang/VirtualThread.java
>
>Co-authored-by: Alan Bateman 
>  - Feedback from reviewers

src/hotspot/share/classfile/vmSymbols.hpp line 612:

> 610:   template(thread_throwable_void_signature,   
> "(Ljava/lang/Thread;Ljava/lang/Throwable;)V")   \
> 611:   template(thread_void_signature, 
> "(Ljava/lang/Thread;)V")\
> 612:   template(runnable_void_signature,   
> "(Ljava/lang/Runnable;)V")\

Suggestion:

  template(runnable_void_signature,   
"(Ljava/lang/Runnable;)V")   \

-

PR: https://git.openjdk.org/jdk/pull/10952


Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v21]

2022-11-22 Thread Andrew Haley
> JEP 429 implementation.

Andrew Haley has updated the pull request incrementally with three additional 
commits since the last revision:

 - Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into 
JDK-828
 - Update src/java.base/share/classes/java/lang/VirtualThread.java
   
   Co-authored-by: Alan Bateman 
 - Feedback from reviewers

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/10952/files
  - new: https://git.openjdk.org/jdk/pull/10952/files/b06ea927..dc577736

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=10952=20
 - incr: https://webrevs.openjdk.org/?repo=jdk=10952=19-20

  Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/10952.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10952/head:pull/10952

PR: https://git.openjdk.org/jdk/pull/10952