[coreboot] New Defects reported by Coverity Scan for coreboot
Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1432491: Error handling issues (CHECKED_RETURN)
/src/mainboard/google/volteer/mainboard.c: 46 in
mainboard_update_soc_chip_config()
*** CID 1432491: Error handling issues (CHECKED_RETURN)
/src/mainboard/google/volteer/mainboard.c: 46 in
mainboard_update_soc_chip_config()
40 dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator;
41 dev->ops->get_smbios_strings = mainboard_smbios_strings;
42 }
43
44 void mainboard_update_soc_chip_config(struct soc_intel_tigerlake_config
*cfg)
45 {
>>> CID 1432491: Error handling issues (CHECKED_RETURN)
>>> Calling "tlcl_lib_init" without checking return value (as is done
>>> elsewhere 10 out of 11 times).
46 tlcl_lib_init();
47 if (cr50_is_long_interrupt_pulse_enabled()) {
48 printk(BIOS_INFO, "Enabling S0i3.4\n");
49 } else {
50 /*
51 * Disable S0i3.4, preventing the GPIO block from switching to
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq2SfQfrHt3Prsn4qSLrYIrajINpiFX8l0vrlNSf8iCrS27qY0Cr0DkycwNUgGZJj8-3DZwSP_L-2FDzr14mnrsJO5b1wX1hp9b1MAQygl7x-2B74RAaH2cn1-2BoO0nwIVkpXKtEd9kWwmA8PTm4t0zw8d9Joq5O4vLtN6No-2FjJZ-2FK-2BBnI1CnfhFVPAB1gFTyiWx5GtWsf5QT9QwUztub1KssCE4ddat0T6i9mW-2BdLyBy4OQMYwfVTYigXY4b79udi9SZoG8xVDoiScxcb-2FC0nRWzdb-2BTEFidoEKPf9zULBulb-2Fem5lu5ZaFhA-3D
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
[coreboot] Re: [RFC] Proposal to move all FSP 1.x binaries to "legacy" branch
Am Fr., 4. Sept. 2020 um 10:56 Uhr schrieb Nico Huber : > I would expect the opposite. At least for all coreboot revisions that > use a Git submodule. Those point to commits, not branches, and hence > should always work as long as the branch history is kept in tact > upstream. > Indeed: As long as there's no git history rewriting involved, the branches will just continue to work because they point to commit ids. Nate, if there's strong interest in retiring binaries (although that will only reduce download size for shallow clones, so I'm not too sure what's the point), could you keep FSP 1.1 around and just retire FSP 1.0? Patrick -- Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
