[coreboot] Re: EC config registers?

2021-03-05 Thread Peter Stuge
crabstorage@getbackinthe.kitchen wrote:
> In devicetree.cb there are changes to the config0-config3 registers.
> Is this notable

Mh, it's all EC stuff like hotkeys, fan control, backlight control, etc.


> and can it cause pcie issues?

In theory not impossible, but I doubt it.


> Also the subsystemid is listed for devices in autoport, is it
> superfluous or should I append it to the current devicetree?

Subsystem IDs are largely cosmetic, but may be needed for some drivers
to load.


//Peter
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] EC config registers?

2021-03-05 Thread crabstorage
I've now run autoport to compare in tree T440P and stock bios. I didn't 
get as much output as expected and not as many differences save for one.


In devicetree.cb there are changes to the config0-config3 registers. Is 
this notable and can it cause pcie issues? Also the subsystemid is 
listed for devices in autoport, is it superfluous or should I append it 
to the current devicetree?


Autoport

chip ec/lenovo/h8 # FIXME: has_keyboard_backlight, 
has_power_management_beeps, has_uwb

register "beepmask0" = "0x00"
register "beepmask1" = "0x86"
register "config0" = "0xa7"
register "config1" = "0x05"
register "config2" = "0xa8"
register "config3" = "0xc6"
register "event2_enable" = "0xff"
register "event3_enable" = "0xff"
register "event4_enable" = "0xd0"
register "event5_enable" = "0x3c"
register "event7_enable" = "0x01"
register "event8_enable" = "0x7b"
register "event9_enable" = "0xff"
register "eventc_enable" = "0xff"
register "eventd_enable" = "0xff"
register "evente_enable" = "0x9d"

Tree

chip ec/lenovo/h8
register "beepmask0" = "0x00"
register "beepmask1" = "0x86"
register "config0" = "0xa6"
register "config1" = "0x0d"
register "config2" = "0xa8"
register "config3" = "0xc4"
register "has_keyboard_backlight" = "1"
register "event2_enable" = "0xff"
register "event3_enable" = "0xff"
register "event4_enable" = "0xd0"
register "event5_enable" = "0x3c"
register "event7_enable" = "0x01"
register "event8_enable" = "0x7b"
register "event9_enable" = "0xff"
register "eventc_enable" = "0xff"
register "eventd_enable" = "0xff"
register "evente_enable" = "0x9d"
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org