[coreboot] RFC: Post-build control of serial console

[Keith Hui]

Hi Simon,

> Why not CMOS RAM / VVRAM?
- If we allocate some space in CMOS for console / logging settings,
then it would allow a similar feature. But it involves changing
settings on the device. Each board would need to provide some CMOS
options for this feature as part of the layout file. It would not be
possible to enable console output without running some code on the
device to update the CMOS RAM.

(Pardon the formatting; I copied this out of my semi-regular digest)

Many boards already have this space allocated in their cmos.layout.
Take for example my sandybridge board, asus/p8z77-m:

# coreboot config options: console
395  4   e   4debug_level
[...]
# debug_level
4 0 Emergency
4 1 Alert
4 2 Critical
4 3 Error
4 4 Warning
4 5 Notice
4 6 Info
4 7 Debug
4 8 Spew

Setting this to 0 suppresses almost all outputs unless it's a "I'm
going to die()" scream.

For development/hacking we do want to start with debug outputs on the
console. If after ample testing a build has proved itself to be
stable, cmos.default (that is a separate file) in CBFS can be patched
to change the default log level. This would be done through cbfstool
(albeit indirectly - extract, patch, re-insert) or a hex editor. I'd
propose a tool that operates on this binary cmos.layout instead.

In short, in my opinion, we don't need a new construct.

Regards
Keith
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: coreboot has switched the default git branch from "master" to "main"

[Patrick Georgi via coreboot]

12. September 2023 17:59, "Felix Singer"  schrieb:

> it seems people are still able to use refs/for/master. Some patches
> were just pushed for master today, but they are already rebased to the
> main branch now. Can we prevent that or can we only prevent submissions
> to the master branch?

I extended the ACLs to catch more cases. Other than that, we'll monitor the 
situation and move things around if patches end up in the wrong place.


Patrick
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: Patches moved to main branch lost review scores

[Martin Roth via coreboot]

I'll work on running things through jenkins again, but it's going to take a 
while to get all of the patches done. If anyone has a specific patch they need 
to get verified, rebasing it on top of the main branch is a good way to get 
jenkins to pick it up again.

*Please* do not rebase huge patch trains - this ties up the builders for long 
periods of time and prevents other people from getting their patches checked. 5 
or 10 at a time should be okay, but beyond 10 patches, rebase the train in 
stages so that other people can use the builders as well. This isn't just now - 
this is a general rule mentioned in the gerrit guidelines document.

Martin

Sep 12, 2023, 09:44 by felixsin...@posteo.net:

> Hi Jeremy, 
>
> Jenkins builds can be just triggered by editing the commit message
> without doing any changes to it. Just save it, which updates the commit
> date. That is enough to trigger Jenkins.
>
> For instance, run `git commit --amend`, don't do any changes, just save
> it and repush as usual (though with HEAD:refs/for/main now).
>
>
> Felix
>
>
> On Mon, 2023-09-11 at 14:37 -0700, Compostella, Jeremy wrote:
>
>> Hi,
>>
>> Most of my gerrit patches moved to the main branch over the
>> week-end. But they lost reviews score such +2 or V+1. Typically,
>> . If V+1 is mandatory
>> how do I trigger the Jenkins gerrit build ?
>>
>> Regards,
>>
>
> ___
> coreboot mailing list -- coreboot@coreboot.org
> To unsubscribe send an email to coreboot-le...@coreboot.org
>

___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: coreboot has switched the default git branch from "master" to "main"

[Felix Singer]

Hi Martin,

On Sat, 2023-09-09 at 18:20 -0600, coreboot org wrote:
> The master branch will no longer accept pushes.

it seems people are still able to use refs/for/master. Some patches
were just pushed for master today, but they are already rebased to the
main branch now. Can we prevent that or can we only prevent submissions
to the master branch?


Felix
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: Patches moved to main branch lost review scores

[Felix Singer]

Hi Jeremy, 

Jenkins builds can be just triggered by editing the commit message
without doing any changes to it. Just save it, which updates the commit
date. That is enough to trigger Jenkins.

For instance, run `git commit --amend`, don't do any changes, just save
it and repush as usual (though with HEAD:refs/for/main now).


Felix


On Mon, 2023-09-11 at 14:37 -0700, Compostella, Jeremy wrote:
> Hi,
> 
> Most of my gerrit patches moved to the main branch over the
> week-end. But they lost reviews score such +2 or V+1. Typically,
> . If V+1 is mandatory
> how do I trigger the Jenkins gerrit build ?
> 
> Regards,
> 

___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org