Re: [coreboot] Missing ACPI ASL code for Denverton GPIO controller

[Julien Viard de Galbert]

Hi Sumo,

It was more to get some motivation to clean some of the code.

The branch is here: https://review.coreboot.org/c/coreboot/+/25446 


I’ve really not looked on GPIO on ACPI (cause I don’t need it) but I really 
think it should be a better base for your work.
So if you can test in on your board, please report your results and help 
reviewing the code ;-)

Best Regards,

Julien

> Le 28 mars 2018 à 14:10, Sumo  a écrit :
> 
> Hi Julien,
> 
> Yes, I'm interested. But no need to hurry up, do it in your own time. ;)
> 
> Thanks,
> Sumo
> 
> 2018-03-27 6:54 GMT-03:00 Julien Viard de Galbert  >:
> 
> 
>> Le 26 mars 2018 à 21:24, Sumo > > a écrit :
>> 
>> Hi all,
> 
> Hi Sumo,
> 
>> 
>> We have a kernel patch which adds pinctrl/GPIO support for Intel Denverton 
>> SoC (https://patchwork.kernel.org/patch/9879473/ 
>> ) to make possible to access 
>> the GPIO from user space (via sysfs, i.e. /sys/kernel/debug/pinctrl/), 
>> however this patch is expects a "INTC3000" GPIO controller definition in the 
>> ACPI tables.
>> I want to add/implement the INTC3000 in the ASL code, but since I don´t want 
>> to reinvent the wheel I´m asking if such ASL code is already available 
>> somewhere (at least in the Intel Pine Lake CRB there´s no such reference to 
>> INTC3000 in the ACPI tables).
>> 
> 
> I have a set of patches that still need some work 
> (https://review.coreboot.org/c/coreboot/+/24928 
> ) that enable some shared 
> code for GPIO; following I also have more patches to use the ACPI code from 
> common block too (not published yet). I didn’t check but probably apollolake 
> or cannonlake has the ACPI code for GPIO (using common block).
> If you are interested I can probably work on adding the ACPI implementation 
> to Gerrit sooner.
> 
> Best Regards,
> 
> Julien
> 
>> Thanks,
>> Sumo
>> -- 
>> coreboot mailing list: coreboot@coreboot.org 
>> https://mail.coreboot.org/mailman/listinfo/coreboot 
>> 
> --
> Julien Viard de Galbert - jviarddegalb...@online.net 
> 
> Online / Scaleway
> Looking for an amazing job? Join us NOW ! https://careers.scaleway.com/ 
> 
> 
> 
> 
> 
> 
> -- 
> coreboot mailing list: coreboot@coreboot.org
> https://mail.coreboot.org/mailman/listinfo/coreboot

--
Julien Viard de Galbert - jviarddegalb...@online.net
Online / Scaleway
Looking for an amazing job? Join us NOW ! https://careers.scaleway.com/




-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Missing ACPI ASL code for Denverton GPIO controller

[Sumo]

Hi Julien,

Yes, I'm interested. But no need to hurry up, do it in your own time. ;)

Thanks,
Sumo

2018-03-27 6:54 GMT-03:00 Julien Viard de Galbert <
jviarddegalb...@online.net>:

>
>
> Le 26 mars 2018 à 21:24, Sumo  a écrit :
>
> Hi all,
>
>
> Hi Sumo,
>
>
> We have a kernel patch which adds pinctrl/GPIO support for Intel Denverton
> SoC (https://patchwork.kernel.org/patch/9879473/) to make possible to
> access the GPIO from user space (via sysfs, i.e.
> /sys/kernel/debug/pinctrl/), however this patch is expects a "INTC3000"
> GPIO controller definition in the ACPI tables.
> I want to add/implement the INTC3000 in the ASL code, but since I don´t
> want to reinvent the wheel I´m asking if such ASL code is already available
> somewhere (at least in the Intel Pine Lake CRB there´s no such reference to
> INTC3000 in the ACPI tables).
>
> I have a set of patches that still need some work (
> https://review.coreboot.org/c/coreboot/+/24928) that enable some shared
> code for GPIO; following I also have more patches to use the ACPI code from
> common block too (not published yet). I didn’t check but probably
> apollolake or cannonlake has the ACPI code for GPIO (using common block).
> If you are interested I can probably work on adding the ACPI
> implementation to Gerrit sooner.
>
> Best Regards,
>
> Julien
>
> Thanks,
> Sumo
> --
> coreboot mailing list: coreboot@coreboot.org
> https://mail.coreboot.org/mailman/listinfo/coreboot
>
>
> --
> Julien Viard de Galbert - jviarddegalb...@online.net
> Online / Scaleway
> Looking for an amazing job? Join us NOW ! https://careers.scaleway.com/
>
>
>
>
>
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Missing ACPI ASL code for Denverton GPIO controller

[Julien Viard de Galbert]

> Le 26 mars 2018 à 21:24, Sumo  a écrit :
> 
> Hi all,

Hi Sumo,

> 
> We have a kernel patch which adds pinctrl/GPIO support for Intel Denverton 
> SoC (https://patchwork.kernel.org/patch/9879473/ 
> ) to make possible to access the 
> GPIO from user space (via sysfs, i.e. /sys/kernel/debug/pinctrl/), however 
> this patch is expects a "INTC3000" GPIO controller definition in the ACPI 
> tables.
> I want to add/implement the INTC3000 in the ASL code, but since I don´t want 
> to reinvent the wheel I´m asking if such ASL code is already available 
> somewhere (at least in the Intel Pine Lake CRB there´s no such reference to 
> INTC3000 in the ACPI tables).
> 
I have a set of patches that still need some work 
(https://review.coreboot.org/c/coreboot/+/24928) that enable some shared code 
for GPIO; following I also have more patches to use the ACPI code from common 
block too (not published yet). I didn’t check but probably apollolake or 
cannonlake has the ACPI code for GPIO (using common block).
If you are interested I can probably work on adding the ACPI implementation to 
Gerrit sooner.

Best Regards,

Julien

> Thanks,
> Sumo
> -- 
> coreboot mailing list: coreboot@coreboot.org
> https://mail.coreboot.org/mailman/listinfo/coreboot

--
Julien Viard de Galbert - jviarddegalb...@online.net
Online / Scaleway
Looking for an amazing job? Join us NOW ! https://careers.scaleway.com/




-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

[coreboot] Missing ACPI ASL code for Denverton GPIO controller

[Sumo]

Hi all,

We have a kernel patch which adds pinctrl/GPIO support for Intel Denverton
SoC (https://patchwork.kernel.org/patch/9879473/) to make possible to
access the GPIO from user space (via sysfs, i.e.
/sys/kernel/debug/pinctrl/), however this patch is expects a "INTC3000"
GPIO controller definition in the ACPI tables.
I want to add/implement the INTC3000 in the ASL code, but since I don´t
want to reinvent the wheel I´m asking if such ASL code is already available
somewhere (at least in the Intel Pine Lake CRB there´s no such reference to
INTC3000 in the ACPI tables).

Thanks,
Sumo
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot