[coreboot] Re: RFC: Behavior of make *config

[Patrick Georgi via coreboot]

29. November 2023 12:14, "Poeche, Uwe via coreboot"  
schrieb:
> Your above mentioned patch helps (I'm a reviewer of this). When I tried I 
> also noticed that this
> does not point out loudly if you have problems in your config. So the 
> approach without the patch
> (in result more strict) is from my opinion better if we have a workaround 
> beside edit config
> manually. In the parallel thread here Martin mentioned the same workaround as 
> you mentioned on IRC
> on Monday. But I get not work.

Right, because the code checks for the variables' presence, not for their 
value. I was mistaken on that, as was Martin apparently.

I modified the changeset so that it still doesn't fail on warnings during 
*config, but still prints them. That doesn't matter a whole lot with menuconfig 
and nconfig because they proceed to clear the screen immediately after, but 
oldconfig and olddefconfig are somewhat more helpful now:

$ make oldconfig
/home/pgeorgi/coreboot/.config:152:warning: unknown symbol: VBT_DATA_SIZE_KB
*
* Restart config...
*
...

$ make olddefconfig
/home/pgeorgi/coreboot/.config:152:warning: unknown symbol: VBT_DATA_SIZE_KB
#
# configuration written to /home/pgeorgi/coreboot/.config
#

Does that help?


Patrick
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: RFC: Behavior of make *config

[Poeche, Uwe via coreboot]

Hi Patrick,

we two had an IRC conversation on monday about this topic but didn't finish 
this.

Your above mentioned patch helps (I'm a reviewer of this). When I tried I also 
noticed that this does not point out loudly if you have problems in your 
config. So the approach without the patch (in result more strict) is from my 
opinion better if we have a workaround beside edit config manually. In the 
parallel thread here Martin mentioned the same workaround as you mentioned on 
IRC on Monday. But I get not work.
I added for test a line in a working .config with "NOT_KNOWN_SWITCH=1234" which 
produces the error and changed now the coreboot toplevel Makefile according:
-KCONFIG_WERROR:= 1
-KCONFIG_WARN_UNKNOWN_SYMBOLS:= 1
+KCONFIG_WERROR ?= 1
+KCONFIG_WARN_UNKNOWN_SYMBOLS ?= 1

And did as Martin and also you mentioned
make menuconfig KCONFIG_WERROR=0 KCONFIG_WARN_UNKNOWN_SYMBOLS=0

But the error still exist.

Can the cause be a dependency from make? We use v4.2.1 on Red Hat 8.8.

Regards
Uwe



___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org