[coreboot] Re: Unable to get S3 resume to work on new port

2023-03-01 Thread Peter Stuge
Kevin Keijzer via coreboot wrote:
> I found the issue. 3VSBSW# had to be enabled for S3 resume to work.
> 
> It ended up being a oneliner fix in devicetree.cb:
> 
> device pnp 2e.a on
> + irq 0xe4 = 0x10 # + enable 3VSBSW#

Good find!

Can you please push a commit with the fix to gerrit?


Thanks

//Peter
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] Re: Unable to get S3 resume to work on new port

2023-02-28 Thread Kevin Keijzer via coreboot

I found the issue. 3VSBSW# had to be enabled for S3 resume to work.

It ended up being a oneliner fix in devicetree.cb:

device pnp 2e.a on
+   irq 0xe4 = 0x10 # + enable 3VSBSW#

--
With kind regards,

Kevin Keijzer
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] Re: Unable to get S3 resume to work on new port

2023-02-28 Thread Kevin Keijzer via coreboot
Ok, so I just found out that for the H77 Pro4-M port [1], S3 resume is 
listed as working.


I built a ROM for that target and flashed it to my B75M-ITX, and now 
resume from S3 just works. (Other things are broken though, like ethernet.)


So I guess I have to compare these two targets now and find out what 
would be the fix?


[1] https://review.coreboot.org/c/coreboot/+/45317

--
With kind regards,

Kevin Keijzer
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org