Re: [Crash-utility] [External Mail][营销邮件] Re: ramdump support for va_bits_actual
- Original Message - > On Fri, Apr 24, 2020 at 12:59 AM Dave Anderson wrote: > > > > > > Vinayak? > > > > - Original Message - > > > Hi,Vinayakm > > > > > > I don't think it's necessary to judge physvirt_offset if empty in > > > arm64_VTOP,because physvirt_offset always be initialized by > > > arm64_calc_physvirt_offset,so machdep->machspec->physvirt_offset always > > > true.even if older kernel are compatible. > > > > > Ya, that check is not really required. I have removed it. v3 attached. Queued for crash-7.2.9: https://github.com/crash-utility/crash/commit/339ddcd6f26fbd3519f50e96689645da867f6e0f Thanks, Dave > Thanks, > Vinayak > > -- > Crash-utility mailing list > Crash-utility@redhat.com > https://www.redhat.com/mailman/listinfo/crash-utility -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility
Re: [Crash-utility] [External Mail][营销邮件] Re: ramdump support for va_bits_actual
On Fri, Apr 24, 2020 at 12:59 AM Dave Anderson wrote: > > > Vinayak? > > - Original Message - > > Hi,Vinayakm > > > > I don't think it's necessary to judge physvirt_offset if empty in > > arm64_VTOP,because physvirt_offset always be initialized by > > arm64_calc_physvirt_offset,so machdep->machspec->physvirt_offset always > > true.even if older kernel are compatible. > > Ya, that check is not really required. I have removed it. v3 attached. Thanks, Vinayak 0002-fix-the-calculation-of-_stext_vmlinux-for-ramdumps.patch Description: Binary data 0003-get-CONFIG_ARM64_VA_BITS-from-config.patch Description: Binary data 0004-fix-vmemmap_start.patch Description: Binary data 0001-fix-the-arm64-vtop-and-ptov-calculations.patch Description: Binary data -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility
Re: [Crash-utility] [External Mail][营销邮件] Re: ramdump support for va_bits_actual
Vinayak? - Original Message - > Hi,Vinayakm > > I don't think it's necessary to judge physvirt_offset if empty in > arm64_VTOP,because physvirt_offset always be initialized by > arm64_calc_physvirt_offset,so machdep->machspec->physvirt_offset always > true.even if older kernel are compatible. > > so,how about the following change? > > @@ -1148,8 +1155,7 @@ arm64_VTOP(ulong addr) > } > > if (addr >= machdep->machspec->page_offset) > - return machdep->machspec->phys_offset > - + (addr - machdep->machspec->page_offset); > + return (addr + machdep->machspec->physvirt_offset); > > > From: crash-utility-boun...@redhat.com on > behalf of vinayak menon > Sent: Tuesday, April 21, 2020 18:01 > To: Discussion list for crash utility usage, maintenance and development > Subject: [External Mail][营销邮件] Re: [Crash-utility] ramdump support for > va_bits_actual > > Hi Dave, zhaoqianli > > > Yeah, that looks reasonable. But what about the parallel discussion re: > > vmemmap_start? > > > > https://www.redhat.com/archives/crash-utility/2020-April/msg00064.html > > I have picked up the vmemmap_start as 4th patch. The physvirt_offset > based VTOP is already > part of patchset 1. I hope I have not missed anything from those > recommended by Zhaogianli. > > > > > Can you send in an updated patch set with all fixes applied? > > PFA. > > Thanks, > Vinayak > #/**本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ > This e-mail and its attachments contain confidential information from > XIAOMI, which is intended only for the person or entity whose address is > listed above. Any use of the information contained herein in any way > (including, but not limited to, total or partial disclosure, reproduction, > or dissemination) by persons other than the intended recipient(s) is > prohibited. If you receive this e-mail in error, please notify the sender by > phone or email immediately and delete it!**/# > > -- > Crash-utility mailing list > Crash-utility@redhat.com > https://www.redhat.com/mailman/listinfo/crash-utility -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility
Re: [Crash-utility] [External Mail][营销邮件] Re: ramdump support for va_bits_actual
Hi,Vinayakm I don't think it's necessary to judge physvirt_offset if empty in arm64_VTOP,because physvirt_offset always be initialized by arm64_calc_physvirt_offset,so machdep->machspec->physvirt_offset always true.even if older kernel are compatible. so,how about the following change? @@ -1148,8 +1155,7 @@ arm64_VTOP(ulong addr) } if (addr >= machdep->machspec->page_offset) - return machdep->machspec->phys_offset - + (addr - machdep->machspec->page_offset); + return (addr + machdep->machspec->physvirt_offset); From: crash-utility-boun...@redhat.com on behalf of vinayak menon Sent: Tuesday, April 21, 2020 18:01 To: Discussion list for crash utility usage,maintenance and development Subject: [External Mail][营销邮件] Re: [Crash-utility] ramdump support for va_bits_actual Hi Dave, zhaoqianli > Yeah, that looks reasonable. But what about the parallel discussion re: > vmemmap_start? > > https://www.redhat.com/archives/crash-utility/2020-April/msg00064.html I have picked up the vmemmap_start as 4th patch. The physvirt_offset based VTOP is already part of patchset 1. I hope I have not missed anything from those recommended by Zhaogianli. > > Can you send in an updated patch set with all fixes applied? PFA. Thanks, Vinayak #/**本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!**/# -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility
