Re: [Crash-utility] [PATCH] Add REFRESH_TASK_TABLE flag to mount command

2020-04-15 Thread Dave Anderson



- Original Message -
> when we launch a crash first and then create a docker container.
> 
> now we run mount command to see the mount namespaces info, we get
> the error:
> 
> crash> mount -n 2020
> mount: invalid task or pid value: 2020
> 
> This patch fix it by add REFRESH_TASK_TABLE flag to mount command.
> 
> Signed-off-by: Wang Long 

Thanks Wang -- queued for crash-7.2.9:

  
https://github.com/crash-utility/crash/commit/601bccedc3300b16f7ff074ba651876af106ffdc

Dave


  
> 
>  global_data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/global_data.c b/global_data.c
> index cbacc42..a316d1c 100644
> --- a/global_data.c
> +++ b/global_data.c
> @@ -93,7 +93,7 @@ struct command_table_entry linux_command_table[] = {
>   {"mach",cmd_mach,help_mach,0},
>   {"map", cmd_map, help_map, HIDDEN_COMMAND},
>   {"mod", cmd_mod, help_mod, 0},
> - {"mount",   cmd_mount,   help_mount,   0},
> + {"mount",   cmd_mount,   help_mount,   REFRESH_TASK_TABLE},
>   {"net", cmd_net,help_net,  REFRESH_TASK_TABLE},
>   {"p",   cmd_p,   help_p,   0},
>   {"ps",  cmd_ps,  help_ps,  REFRESH_TASK_TABLE},
> --
> 1.8.3.1
> 
> 
> 
> 

--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility



[Crash-utility] [PATCH] Add REFRESH_TASK_TABLE flag to mount command

2020-04-15 Thread Wang Long
when we launch a crash first and then create a docker container.

now we run mount command to see the mount namespaces info, we get
the error:

crash> mount -n 2020
mount: invalid task or pid value: 2020

This patch fix it by add REFRESH_TASK_TABLE flag to mount command.

Signed-off-by: Wang Long 
---
 global_data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/global_data.c b/global_data.c
index cbacc42..a316d1c 100644
--- a/global_data.c
+++ b/global_data.c
@@ -93,7 +93,7 @@ struct command_table_entry linux_command_table[] = {
{"mach",cmd_mach,help_mach,0},
{"map", cmd_map, help_map, HIDDEN_COMMAND},
{"mod", cmd_mod, help_mod, 0},
-   {"mount",   cmd_mount,   help_mount,   0},
+   {"mount",   cmd_mount,   help_mount,   REFRESH_TASK_TABLE},
{"net", cmd_net,help_net,  REFRESH_TASK_TABLE},
{"p",   cmd_p,   help_p,   0},
{"ps",  cmd_ps,  help_ps,  REFRESH_TASK_TABLE},
-- 
1.8.3.1




--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility