RE: patch release tomorrow

[Daniel Stenberg]

On Sun, 7 Aug 2016, Steve Holme wrote:

I also appreciate this is a little subjective but I would have thought 
adding support for NTLM with mbedTLS is also a new functionality - 
previously NTLM wasn't supported with mbedTLS so I wouldn't class that as a 
bug fix.


That's of course a matter of defintion and while it perhaps isn't strictly a 
bug that was fixed, since it was very much deliberate. But I consider it a bug 
when a particualr backend doesn't support the full feature set so when we fix 
that it is a bug fix. I don't view it as a real "change" either since 
supporting NTLM is something we've done for decades. Tricky.


It seems to me that, those 4 weeks of testing and bug fixing aren't going to 
be used as well as they could be. With regards to testing there hasn't been 
much added since the last weeks release so not a huge amount of stuff to 
test.


I beg to differ. We're constantly behind on bug fixing (and associated tests) 
so even without anything added we still have lots of things to fix and test. 
Just see the KNOWN_BUGS and the open issues. Several of those have been around 
for a long time and I struggle to keep up.


I would agree that we're probably not that many people doing this kind of 
debug and test work, so the bugfixing period may actually be taken by some (or 
many) as a hint to go procrastinate until the feature window opens again but 
I'm not sure that's a very good argument for us to change habits.


So, do you or anyone else want another week for adding features until we 
close that for the next release?


Please - and it the chance for other features to drop in as well.


Absolutely! The feature window is hereby extended one week - it'll now close 
on August 17. Let's try to keep the pending release date at September 7th 
anyway.


--

 / daniel.haxx.se
---
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html

RE: patch release tomorrow

[Steve Holme]

> On Sat, 6 Aug 2016, Daniel Stenberg wrote:

> > I've already push Bill's mbedTLS NTLM addition and I'm hoping to get 
> > Sergei's LDAP change pushed this weekend (although I might to step up and 
> > finish the documentation side off!). Is this enough for a major bump as I 
> > probably need to quote version numbers in the docs for LDAP?
> 
> Is it? I'll admit I haven't really followed the details of the LDAP changes 
> but I've not seen anything there that isn't just bugfixes. Am I wrong?
I see Sergei has already responded but I would have said that was a new feature.
I also appreciate this is a little subjective but I would have thought adding 
support for NTLM with mbedTLS is also a new functionality - previously NTLM 
wasn't supported with mbedTLS so I wouldn't class that as a bug fix.
> > I've also been wondering about this process... I know we have our 8 week 
> > release cycle but when a patch release eats into this, I would rather reset 
> > the 8 week cycle so it starts in full from that patch release date
> 
> There are several ways we could do it. We don't do patch release out of the 
> ordinary schedule that often so we haven't made any formal decisions on how 
> to 
> handle it. This time, I figured we could do it this way since we have so many 
> bugs to work on anyway so it would be a general benefit to have a "round" 
> where we have less time for features and more time for bugs. That. and the 
> fact that I wasn't aware of any major changes knocking on the door longing to 
> get in.
Don't get me wrong, I don't have any problems with the patch releases out of 
the 8 week cycle.
> > I appreciate it means updating the calendar and it means you can't 
> > guarantee 
> > a release on say 22 February 2017, but I would be interested to know what 
> > others think as it would allow more time to get features in. From a totally 
> > selfish point of view, as I am struggling to dedicate time to curl at the 
> > moment, it would certainly help me ;-)
> 
> Right, but if you wouldn't manage to reach a mergable state for the change 
> within this week final, there is only another four weeks until the feature 
> window opens again and there's another opportunity. I don't think it should 
> be 
> much of a burden for people as long as we open up for features again soon 
> enough.
It seems to me that, those 4 weeks of testing and bug fixing aren't going to be 
used as well as they could be. With regards to testing there hasn't been much 
added since the last weeks release so not a huge amount of stuff to test.
> An alternative would of course be to make patch releases in a separate branch 
> so that we can do feature merges in the branch heading for the next minor 
> release but I would prefer to avoid such a setup as it would make it more 
> complicated to test and for us to keep track of.
Yeah - I would agree with you there I never like the setup, maintenance and 
management of multiple branch ;-)
> So, do you or anyone else want another week for adding features until we 
> close 
> that for the next release?

Please - and it the chance for other features to drop in as well.
Kind Regards
Steve
  ---
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html

Re: patch release tomorrow

[Sergei Nikulov]

2016-08-06 22:25 GMT+03:00 Daniel Stenberg :
> On Sat, 6 Aug 2016, Steve Holme wrote:
>
>> I've already push Bill's mbedTLS NTLM addition and I'm hoping to get
>> Sergei's LDAP change pushed this weekend (although I might to step up and
>> finish the documentation side off!). Is this enough for a major bump as I
>> probably need to quote version numbers in the docs for LDAP?
>
>
> Is it? I'll admit I haven't really followed the details of the LDAP changes
> but I've not seen anything there that isn't just bugfixes. Am I wrong?
>

It is new feature.
But it's small changes in code - I've reused existing auth options from HTTP.

>
> --
>
>  / daniel.haxx.se
> ---
> List admin: https://cool.haxx.se/list/listinfo/curl-library
> Etiquette:  https://curl.haxx.se/mail/etiquette.html



-- 
Best Regards,
Sergei Nikulov
---
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html