Re: Correct package in vtls/openssl.c

2016-03-08 Thread Daniel Stenberg 

On Tue, 8 Mar 2016, Gisle Vanem wrote:


It does have a 'SSLeay()' prototype in include/openssl/crypto.h:

 /* SSLeay is a compatibility function that returns OPENSSL_VERSION_NUMBER from
  * base.h. */
 OPENSSL_EXPORT unsigned long SSLeay(void);

So I assume it's okay to use for 'OPENSSL_IS_BORINGSSL' too.


Sure, but OPENSSL_VERSION_NUMBER is provided for OpenSSL compatibility so that 
returns 0x10002000 right now. Meaning 1.0.2. I don't think that's a BoringSSL 
version string, that's just what OpenSSL version they think they're compatible 
with.


--

 / daniel.haxx.se
---
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html

Re: Correct package in vtls/openssl.c

2016-03-08 Thread Gisle Vanem 
Daniel Stenberg wrote:

> This is simply because BoringSSL has no version number from what I understand!

It does have a 'SSLeay()' prototype in include/openssl/crypto.h:

  /* SSLeay is a compatibility function that returns OPENSSL_VERSION_NUMBER from
   * base.h. */
  OPENSSL_EXPORT unsigned long SSLeay(void);

So I assume it's okay to use for 'OPENSSL_IS_BORINGSSL'
too.

-- 
--gv
---
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html