Re: TESTFAIL: These test cases failed: 1167
On Tue, 22 Dec 2020, Dennis Clarke wrote: That there is a thing of beauty : Thanks for verifying that. I merged PR #6355 just now! -- / daniel.haxx.se | Commercial curl support up to 24x7 is available! | Private help, bug fixes, support, ports, new features | https://www.wolfssl.com/contact/ --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/22/20 2:43 AM, Daniel Stenberg wrote:
> On Mon, 21 Dec 2020, Dennis Clarke via curl-library wrote:
>
>> On 12/21/20 4:49 PM, Daniel Stenberg wrote:
>>> + if (/^\#\s*\z/) {
>>> + next;
>>> + }
>>
>> I applied that and test 1167 still fails :
>
> I modified the check in an update to just:
>
> if (/^#/) {
> next;
> }
>
> Does that fix the issue?
>
Let's give that a whirl :
alpha $ diff -u badsymbols.pl.orig badsymbols.pl
--- badsymbols.pl.orig Sun Dec 20 12:25:10 2020
+++ badsymbols.pl Tue Dec 22 17:02:03 2020
@@ -90,6 +90,9 @@
if($skipit) {
next;
}
+if (/^#/) {
+next;
+}
if ( /enum\s+(\S+\s+)?{/ .. /}/ ) {
s/^\s+//;
chomp;
alpha $
That there is a thing of beauty :
alpha $ ./runtests.pl -p 1167
* System characteristics
* curl 7.74.0 (sparc64-sun-solaris2.10)
* libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0
* Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM
NTLM_WB SSL TLS-SRP UnixSockets
* Disabled:
* Host: alpha
* System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc
SUNW,SPARC-Enterprise
* OS: solaris
* Servers: HTTP-IPv6 HTTP-unix FTP-IPv6
* Env:
* Seed: 211840
*
test 1167...[Verify curl prefix of public symbols in header files]
---e--- OK (1 out of 1 , remaining: 00:00, took 0.485s, duration:
00:00)
TESTDONE: 1 tests out of 1 reported OK: 100%
TESTDONE: 1 tests were considered during 0 seconds.
alpha $
Also see attached log for perl -I. badsymbols.pl -v .. where we see :
.
.
.
Source: ../include/curl/system.h
Symbol: CURL_ISOCPP
Line #476: #define CURL_ISOCPP
3461 fine symbols found
alpha $
Wonderful !
--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
badsymbols_patched_again.log.xz
Description: application/xz
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On Mon, 21 Dec 2020, Dennis Clarke via curl-library wrote:
On 12/21/20 4:49 PM, Daniel Stenberg wrote:
+ if (/^\#\s*\z/) {
+ next;
+ }
I applied that and test 1167 still fails :
I modified the check in an update to just:
if (/^#/) {
next;
}
Does that fix the issue?
--
/ daniel.haxx.se
| Commercial curl support up to 24x7 is available!
| Private help, bug fixes, support, ports, new features
| https://www.wolfssl.com/contact/---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/21/20 4:49 PM, Daniel Stenberg wrote:
> + if (/^\#\s*\z/) {
> + next;
> + }
I applied that and test 1167 still fails :
alpha $
alpha $ diff -u badsymbols.pl.orig badsymbols.pl
--- badsymbols.pl.orig Sun Dec 20 12:25:10 2020
+++ badsymbols.pl Mon Dec 21 23:30:04 2020
@@ -90,6 +90,9 @@
if($skipit) {
next;
}
+if (/^\#\s*\z/) {
+next;
+}
if ( /enum\s+(\S+\s+)?{/ .. /}/ ) {
s/^\s+//;
chomp;
alpha $
alpha $ ./runtests.pl -p 1167
* System characteristics
* curl 7.74.0 (sparc64-sun-solaris2.10)
* libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0
* Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM
NTLM_WB SSL TLS-SRP UnixSockets
* Disabled:
* Host: alpha
* System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc
SUNW,SPARC-Enterprise
* OS: solaris
* Servers: HTTP-IPv6 HTTP-unix FTP-IPv6
* Env:
* Seed: 211840
*
test 1167...[Verify curl prefix of public symbols in header files]
perl -I. returned 1, when expecting 0
exit FAILED
== Contents of files in the log/ dir after test 1167
=== Start of file commands.log
perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167
=== End of file commands.log
=== Start of file ftpserver.cmd
Testnum 1167
=== End of file ftpserver.cmd
=== Start of file stdout1167
Bad symbols in public header files:
#
#
#
#
.
. lots of these lines
.
#
#
#
#
#
=== End of file stdout1167
- abort tests
TESTDONE: 0 tests out of 1 reported OK: 0%
TESTFAIL: These test cases failed: 1167
TESTDONE: 1 tests were considered during 0 seconds.
alpha $
Also I attached the badsymbols_patched.log.xz here.
Dennis
badsymbols_patched.log.xz
Description: application/xz
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/21/2020 4:49 PM, Daniel Stenberg via curl-library wrote:
On Mon, 21 Dec 2020, Dennis Clarke via curl-library wrote:
Ah ha, well that provides endless buckets of information.
It seems the script doesn't properly ignore lines with nothing but a
single hash ('#') sign on them. My proposed patch:
diff --git a/tests/badsymbols.pl b/tests/badsymbols.pl
index bad037975..e609633bb 100755
--- a/tests/badsymbols.pl
+++ b/tests/badsymbols.pl
@@ -88,10 +88,13 @@ sub scanenums {
next;
}
if($skipit) {
next;
}
+ if (/^\#\s*\z/) {
+ next;
+ }
if ( /enum\s+(\S+\s+)?{/ .. /}/ ) {
s/^\s+//;
chomp;
s/[,\s].*//;
if(($_ !~ /\}(;|)/) &&
Daniel has submitted his patch as a PR [1] and I will follow up there
with comments.
[1]: https://github.com/curl/curl/pull/6355
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On Mon, 21 Dec 2020, Dennis Clarke via curl-library wrote:
Ah ha, well that provides endless buckets of information.
It seems the script doesn't properly ignore lines with nothing but a single
hash ('#') sign on them. My proposed patch:
diff --git a/tests/badsymbols.pl b/tests/badsymbols.pl
index bad037975..e609633bb 100755
--- a/tests/badsymbols.pl
+++ b/tests/badsymbols.pl
@@ -88,10 +88,13 @@ sub scanenums {
next;
}
if($skipit) {
next;
}
+if (/^\#\s*\z/) {
+next;
+}
if ( /enum\s+(\S+\s+)?{/ .. /}/ ) {
s/^\s+//;
chomp;
s/[,\s].*//;
if(($_ !~ /\}(;|)/) &&
--
/ daniel.haxx.se
| Commercial curl support up to 24x7 is available!
| Private help, bug fixes, support, ports, new features
| https://www.wolfssl.com/contact/
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/20/20 3:58 PM, Dan Fandrich via curl-library wrote: > On Sun, Dec 20, 2020 at 03:35:45PM -0500, Dennis Clarke via curl-library > wrote: Will do but I don't see anything different >>> >>> >>> Please run it directly using verbose -v, refer to the command line above >>> >>> >> >> Well throwing in a -v does nothing new : > > It's the badsymbols.pl script that needs the -v. Try this: > > cd tests; perl -I. badsymbols.pl -v .. > --- Ah ha, well that provides endless buckets of information. I attached the compressed log file here and hope it means something. I have not yet even scanned through it as it is over 20,000 lines. I figure I will share it first and then start the scanning/grepping process. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional badsymbols.log.xz Description: application/xz --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On Sun, Dec 20, 2020 at 03:35:45PM -0500, Dennis Clarke via curl-library wrote: > >> Will do but I don't see anything different > > > > > > Please run it directly using verbose -v, refer to the command line above > > > > > > Well throwing in a -v does nothing new : It's the badsymbols.pl script that needs the -v. Try this: cd tests; perl -I. badsymbols.pl -v .. --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/20/2020 3:35 PM, Dennis Clarke via curl-library wrote: Will do but I don't see anything different Please run it directly using verbose -v, refer to the command line above Well throwing in a -v does nothing new : alpha $ alpha $ ./runtests.pl -v -p 1167 Please run badsymbols directly not runtests cd tests perl -I. ./badsymbols.pl -v ./.. --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
>>> >> Will do but I don't see anything different > > > Please run it directly using verbose -v, refer to the command line above > > Well throwing in a -v does nothing new : alpha $ alpha $ ./runtests.pl -v -p 1167 CMD (0): ../src/curl --version 1>log/curlverout.log 2>log/curlvererr.log * System characteristics * curl 7.74.0 (sparc64-sun-solaris2.10) * libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0 * Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM NTLM_WB SSL TLS-SRP UnixSockets * Disabled: * Host: alpha * System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc SUNW,SPARC-Enterprise * OS: solaris * Servers: HTTP-IPv6 HTTP-unix FTP-IPv6 * Env: * Seed: 211840 * Unix socket paths: * HTTP-Unix:http4229.sock * * starts no server test 1167...[Verify curl prefix of public symbols in header files] perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 CMD (256): perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 perl -I. returned 1, when expecting 0 exit FAILED == Contents of files in the log/ dir after test 1167 === Start of file commands.log perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 === End of file commands.log === Start of file ftpserver.cmd Testnum 1167 === End of file ftpserver.cmd === Start of file stdout1167 Bad symbols in public header files: # # # # . . . etc etc etc Dennis --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/20/2020 7:29 AM, Dennis Clarke via curl-library wrote: I'm working on adding a verbose mode to badsymbols [1][2], can you patch and try it out: cd tests perl -I. ./badsymbols.pl -v ./.. [1]:https://github.com/curl/curl/pull/6349 [2]:https://patch-diff.githubusercontent.com/raw/curl/curl/pull/6349.diff Will do but I don't see anything different Please run it directly using verbose -v, refer to the command line above --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
> > I'm working on adding a verbose mode to badsymbols [1][2], can you patch > and try it out: > > cd tests > perl -I. ./badsymbols.pl -v ./.. > > > [1]: https://github.com/curl/curl/pull/6349 > [2]: https://patch-diff.githubusercontent.com/raw/curl/curl/pull/6349.diff > Will do but I don't see anything different : alpha $ curl -4 -L --url 'https://patch-diff.githubusercontent.com/raw/curl/curl/pull/6349.diff' -o curl_6349.patch % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 16480 16480 0 2980 0 --:--:-- --:--:-- --:--:-- 2974 alpha $ wc -l curl_6349.patch 61 curl_6349.patch alpha $ alpha $ mv curl_6349.patch ../curl-7.74.0_sunos5.10_sparcv9.003_curl_6349.patch alpha $ alpha $ alpha $ patch --backup --verbose -p1 -i ../curl-7.74.0_sunos5.10_sparcv9.003_curl_6349.patch Hmm... Looks like a unified diff to me... The text leading up to this was: -- |diff --git a/tests/badsymbols.pl b/tests/badsymbols.pl |index 8ce536d0477..bad037975d9 100755 |--- a/tests/badsymbols.pl |+++ b/tests/badsymbols.pl -- patching file tests/badsymbols.pl Using Plan A... Hunk #1 succeeded at 45. Hunk #2 succeeded at 61. Hunk #3 succeeded at 74. Hunk #4 succeeded at 98. Hunk #5 succeeded at 115. done alpha $ alpha $ cd tests alpha $ alpha $ alpha $ pwd /opt/bw/build/curl-7.74.0_sunos5.10_sparcv9.003/tests alpha $ ./runtests.pl -p 1167 * System characteristics * curl 7.74.0 (sparc64-sun-solaris2.10) * libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0 * Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM NTLM_WB SSL TLS-SRP UnixSockets * Disabled: * Host: alpha * System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc SUNW,SPARC-Enterprise * OS: solaris * Servers: HTTP-IPv6 HTTP-unix FTP-IPv6 * Env: * Seed: 211840 * test 1167...[Verify curl prefix of public symbols in header files] perl -I. returned 1, when expecting 0 exit FAILED == Contents of files in the log/ dir after test 1167 === Start of file commands.log perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 === End of file commands.log === Start of file ftpserver.cmd Testnum 1167 === End of file ftpserver.cmd === Start of file stdout1167 Bad symbols in public header files: # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # === End of file stdout1167 - abort tests TESTDONE: 0 tests out of 1 reported OK: 0% TESTFAIL: These test cases failed: 1167 TESTDONE: 1 tests were considered during 0 seconds. alpha $ Looks the same. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/19/2020 9:58 PM, Dennis Clarke via curl-library wrote: alpha $ alpha $ ./runtests.pl -p 1167 * System characteristics * curl 7.74.0 (sparc64-sun-solaris2.10) * libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0 * Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM NTLM_WB SSL TLS-SRP UnixSockets * Disabled: * Host: alpha * System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc SUNW,SPARC-Enterprise * OS: solaris * Servers: HTTP-IPv6 HTTP-unix FTP-IPv6 * Env: * Seed: 211840 * test 1167...[Verify curl prefix of public symbols in header files] perl -I. returned 1, when expecting 0 exit FAILED == Contents of files in the log/ dir after test 1167 === Start of file commands.log perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 === End of file commands.log === Start of file ftpserver.cmd Testnum 1167 === End of file ftpserver.cmd === Start of file stdout1167 Bad symbols in public header files: # # # . . a pile of lines which are all just # . # # # # === End of file stdout1167 - abort tests TESTDONE: 0 tests out of 1 reported OK: 0% TESTFAIL: These test cases failed: 1167 TESTDONE: 1 tests were considered during 0 seconds. alpha $ echo $? 1 alpha $ I'm working on adding a verbose mode to badsymbols [1][2], can you patch and try it out: cd tests perl -I. ./badsymbols.pl -v ./.. [1]: https://github.com/curl/curl/pull/6349 [2]: https://patch-diff.githubusercontent.com/raw/curl/curl/pull/6349.diff --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
> > ./runtests.pl -p 1167 > > okay .. lets do that : alpha $ alpha $ ./runtests.pl -p 1167 * System characteristics * curl 7.74.0 (sparc64-sun-solaris2.10) * libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0 * Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM NTLM_WB SSL TLS-SRP UnixSockets * Disabled: * Host: alpha * System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc SUNW,SPARC-Enterprise * OS: solaris * Servers: HTTP-IPv6 HTTP-unix FTP-IPv6 * Env: * Seed: 211840 * test 1167...[Verify curl prefix of public symbols in header files] perl -I. returned 1, when expecting 0 exit FAILED == Contents of files in the log/ dir after test 1167 === Start of file commands.log perl -I. ./badsymbols.pl ./.. >log/stdout1167 2>log/stderr1167 === End of file commands.log === Start of file ftpserver.cmd Testnum 1167 === End of file ftpserver.cmd === Start of file stdout1167 Bad symbols in public header files: # # # . . a pile of lines which are all just # . # # # # === End of file stdout1167 - abort tests TESTDONE: 0 tests out of 1 reported OK: 0% TESTFAIL: These test cases failed: 1167 TESTDONE: 1 tests were considered during 0 seconds. alpha $ echo $? 1 alpha $ -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On 12/19/2020 11:15 AM, Dennis Clarke via curl-library wrote: on Solaris 10 sparcv9 : OK (1376 out of 1376, remaining: 00:00, took 0.134s, duration: 11:18) TESTDONE: 1091 tests out of 1092 reported OK: 99% TESTFAIL: These test cases failed: 1167 TESTDONE: 1388 tests were considered during 679 seconds. So what can I do to dig out the details ? ./runtests.pl -p 1167 --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
Re: TESTFAIL: These test cases failed: 1167
On Sat, 19 Dec 2020, Dennis Clarke via curl-library wrote: on Solaris 10 sparcv9 : TESTFAIL: These test cases failed: 1167 So what can I do to dig out the details ? Test 1167 runs the tests/badsymbols.pl script and verifies that it returns 0. You can run that script manually in the source tree root and it will output the symbols it found that it considered "wrong" - but since the script works on a lot of machines and platforms, we can assume that it is a false positive on your machine. Probably because your cpp outputs something in a different way that makes the script do wrong. Figuring that out is be a matter of debugging the script with the cpp outputs on your machine. It runs cpp on each .h file in include/curl and makes sure there are no public symbols defined in *our headers* that don't start with (lib)curl (case insensitively). -- / daniel.haxx.se | Commercial curl support up to 24x7 is available! | Private help, bug fixes, support, ports, new features | https://www.wolfssl.com/contact/ --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
TESTFAIL: These test cases failed: 1167
on Solaris 10 sparcv9 : OK (1376 out of 1376, remaining: 00:00, took 0.134s, duration: 11:18) TESTDONE: 1091 tests out of 1092 reported OK: 99% TESTFAIL: These test cases failed: 1167 TESTDONE: 1388 tests were considered during 679 seconds. So what can I do to dig out the details ? -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
