Suspend broken (6.99.40, swcrypto)
Hello. # sysctl -w hw.acpi.sleep.state=3 is (trivially) broken due: Devices without power management support: swcrypto0. I think there were some recent refactoring-like changes in this department. Since this happens ever so often, I'll write a test case for this once I get the sources sorted out, but in the meantime, please add the dummy hooks. - Jukka.
Re: Suspend broken (6.99.40, swcrypto)
In article pine.neb.4.64.1404130652200.9...@screamer.whooppee.com, Paul Goyette p...@whooppee.com wrote: Hmmm, not quite so trivial as you might thing. pmf_device_register() needs to have the device_t as the first argument. swcrypto attaches using config_attach_pseudo(), which as far as I can tell ends up calling the swcryptoattach(int) initialization routine. This routine doesn't get passed a device_t so nothing available to give to pmf_device_register() ... There is self in swcrypto_attach so you could put the pmf_stuff there. Other pseudo devices which already handle pmf_device_register() (for example, cgd, vnd, fss) are attached with calls to devsw_attach() which seems to call the othe initialization routine xxx_attach(device_t, device_t void *) (as declared in the CFATTACH_DECL). None of the refactoring changes I made to swcrypto removed anything, so this failure-to-suspend should have been a pre-existing condition. It is also not clear to me why crypto0 is not also listed as lacking pmf support... (Its attachment seems to call both devsw_attach() and config_attach_pseudo(), but nowhere does it call pmf_device_register()!) Same there. Give it a try. christos
daily CVS update output
Updating src tree: P src/distrib/notes/common/postinstall P src/sys/arch/arm/arm32/arm32_kvminit.c P src/sys/arch/arm/arm32/fault.c P src/sys/arch/arm/arm32/pmap.c P src/sys/arch/arm/cortex/a9wdt.c P src/sys/arch/arm/cortex/gic.c P src/sys/arch/arm/cortex/gtmr.c P src/sys/arch/arm/include/armreg.h U src/sys/arch/arm/samsung/exynos4_loc.c U src/sys/arch/arm/samsung/exynos4_reg.h U src/sys/arch/arm/samsung/exynos5_loc.c U src/sys/arch/arm/samsung/exynos5_reg.h U src/sys/arch/arm/samsung/exynos_intr.h U src/sys/arch/arm/samsung/exynos_io.c U src/sys/arch/arm/samsung/exynos_io.h U src/sys/arch/arm/samsung/exynos_reg.h U src/sys/arch/arm/samsung/exynos_smc.S U src/sys/arch/arm/samsung/exynos_soc.c U src/sys/arch/arm/samsung/exynos_space.c U src/sys/arch/arm/samsung/exynos_sscom.c U src/sys/arch/arm/samsung/exynos_var.h U src/sys/arch/arm/samsung/exynos_wdt.c U src/sys/arch/arm/samsung/files.exynos U src/sys/arch/arm/samsung/mct.c U src/sys/arch/arm/samsung/mct_reg.h U src/sys/arch/arm/samsung/mct_var.h U src/sys/arch/arm/samsung/smc.h U src/sys/arch/arm/samsung/sscom.c U src/sys/arch/arm/samsung/sscom_reg.h U src/sys/arch/arm/samsung/sscom_var.h U src/sys/arch/evbarm/conf/ODROID U src/sys/arch/evbarm/conf/ODROID_INSTALL U src/sys/arch/evbarm/conf/files.odroid U src/sys/arch/evbarm/conf/mk.odroid U src/sys/arch/evbarm/conf/std.odroid U src/sys/arch/evbarm/odroid/genassym.cf U src/sys/arch/evbarm/odroid/odroid_machdep.c U src/sys/arch/evbarm/odroid/odroid_start.S U src/sys/arch/evbarm/odroid/platform.h P src/sys/arch/sparc/include/asm.h P src/sys/ddb/db_cpu.c P src/sys/external/bsd/vchiq/dist/interface/compat/vchi_bsd.c P src/sys/external/bsd/vchiq/dist/interface/compat/vchi_bsd.h P src/sys/external/bsd/vchiq/dist/interface/vchiq_arm/vchiq_2835_arm.c P src/sys/kern/kern_exec.c P src/sys/netinet/if_arp.c P src/sys/rump/librump/rumpkern/vm.c P src/usr.bin/asa/asa.1 P src/usr.bin/cap_mkdb/cap_mkdb.1 P src/usr.bin/comm/comm.1 P src/usr.bin/ctags/ctags.1 P src/usr.bin/getconf/getconf.1 P src/usr.bin/pmap/pmap.1 P src/usr.bin/printf/printf.1 P src/usr.bin/progress/progress.1 P src/usr.bin/stat/stat.1 Updating xsrc tree: Killing core files: Running the SUP scanner: SUP Scan for current starting at Sun Apr 13 04:30:44 2014 SUP Scan for current completed at Sun Apr 13 06:04:34 2014 SUP Scan for mirror starting at Sun Apr 13 06:04:34 2014 SUP Scan for mirror completed at Sun Apr 13 14:14:35 2014 Updating file list: -rw-rw-r-- 1 srcmastr netbsd 37922506 Apr 13 18:42 ls-lRA.gz
