Re: VirtualBox guest additions build failure
Thanks! I recall previously, when the major changes I couldn't even load the module; now the module loads despite the major change. I also have to chmod 666 /dev/vboxguest; otherwise VBoxClient --clipboard complains. BTW - completely unrelated to the NetBSD VirtualBox additions, the last released VirtualBox (6.1.22) has trouble working under at least the latest insider builds of Windows 10 - none of the network adapters are seen by the guests. Chavdar On Sun, 9 May 2021 at 01:10, Valery Ushakov wrote: > > On Wed, Apr 28, 2021 at 19:38:39 +0100, Chavdar Ivanov wrote: > > > Anyway, thanks; now works as before (the daemon still exits but the > > reason is different, as before - > [...] > > 10:19:44.966110 main Error: Failed to connect to the guest > > property service! Error: VERR_NOT_SUPPORTED > > 10:19:44.966128 main Error: Service 'timesync' failed pre-init: > > VERR_NOT_SUPPORTED > > This is the usual problem of not having a fixed major. Some new > devices were added, so the old /dev/vboxguest device points to the > wrong driver. > > -uwe --
Re: VirtualBox guest additions build failure
On Wed, Apr 28, 2021 at 19:38:39 +0100, Chavdar Ivanov wrote: > Anyway, thanks; now works as before (the daemon still exits but the > reason is different, as before - [...] > 10:19:44.966110 main Error: Failed to connect to the guest > property service! Error: VERR_NOT_SUPPORTED > 10:19:44.966128 main Error: Service 'timesync' failed pre-init: > VERR_NOT_SUPPORTED This is the usual problem of not having a fixed major. Some new devices were added, so the old /dev/vboxguest device points to the wrong driver. -uwe
Re: VirtualBox guest additions build failure
On Wed, 28 Apr 2021 at 15:43, Jason Thorpe wrote: > > > > On Apr 28, 2021, at 1:11 AM, Chavdar Ivanov wrote: > > > > --- src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG > > 2021-04-28 08:30:19.546105988 +0100 > > +++ src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c > > 2021-04-28 08:35:01.833286272 +0100 > > @@ -416,7 +416,12 @@ > > if (RT_FAILURE(rc)) > > goto fail; > > > > + > > +#if __NetBSD_Version__ >= 999008200 > > +config_found(sc->sc_dev, , wsmousedevprint, CFARG_IATTR, > > "wsmouswdev", CFARG_EOL); > > +#else > > sc->sc_wsmousedev = config_found_ia(sc->sc_dev, "wsmousedev", > > , wsmousedevprint); > > +#endif > > if (sc->sc_wsmousedev == NULL) > > goto fail; > > > > > > got me a panic; the crash dump was apparently taken, but savecore > > didn't find anything. I am in a hurry and have no time at the moment > > to transcribe the output, but as the png files are small, so I am > > attaching them. > > That's because there's a typo ... "wsmouswdev" is not "wsmousedev". If you > attempt to attach children with an interface attribute the device doesn't > carry, that is also an error that a KASSERT() will fire on. Thick fingers... w next to e... In my excuse, I had 15 minutes between receiving the mail with the suggested patch and leaving for a customer. Anyway, thanks; now works as before (the daemon still exits but the reason is different, as before - 10:19:44.965506 main VBoxService 6.1.20 r143896 (verbosity: 0) netbsd.amd64 (Apr 27 2021 21:25:13) release log 10:19:44.965518 main Log opened 2021-04-28T10:19:44.965483000Z 10:19:44.965951 main OS Product: NetBSD 10:19:44.965994 main OS Release: 9.99.82 10:19:44.966011 main OS Version: NetBSD 9.99.82 (GENERIC_KASLR) #0: Mon Apr 26 04:13:54 BST 2021 sysbuild@ymir:/home/sysbuild/amd64/obj/home/sysbuild/src/sys/arch/amd64/compile/GENERIC_KASLR 10:19:44.966026 main Executable: /usr/local/bin/additions/VBoxService 10:19:44.966033 main Process ID: 14065 10:19:44.966041 main Package type: BSD_64BITS_GENERIC 10:19:44.966110 main Error: Failed to connect to the guest property service! Error: VERR_NOT_SUPPORTED 10:19:44.966128 main Error: Service 'timesync' failed pre-init: VERR_NOT_SUPPORTED But Xorg works as expected. > > Honestly, if the parent device in question only has a single interface > attribute (I don't know because I haven't looked at the VirtualBox code), > then the best choice is to simply omit it from the config_found() call. > > -- thorpej > --
Re: VirtualBox guest additions build failure
> On Apr 28, 2021, at 1:11 AM, Chavdar Ivanov wrote: > > --- src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG > 2021-04-28 08:30:19.546105988 +0100 > +++ src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c > 2021-04-28 08:35:01.833286272 +0100 > @@ -416,7 +416,12 @@ > if (RT_FAILURE(rc)) > goto fail; > > + > +#if __NetBSD_Version__ >= 999008200 > +config_found(sc->sc_dev, , wsmousedevprint, CFARG_IATTR, > "wsmouswdev", CFARG_EOL); > +#else > sc->sc_wsmousedev = config_found_ia(sc->sc_dev, "wsmousedev", > , wsmousedevprint); > +#endif > if (sc->sc_wsmousedev == NULL) > goto fail; > > > got me a panic; the crash dump was apparently taken, but savecore > didn't find anything. I am in a hurry and have no time at the moment > to transcribe the output, but as the png files are small, so I am > attaching them. That's because there's a typo ... "wsmouswdev" is not "wsmousedev". If you attempt to attach children with an interface attribute the device doesn't carry, that is also an error that a KASSERT() will fire on. Honestly, if the parent device in question only has a single interface attribute (I don't know because I haven't looked at the VirtualBox code), then the best choice is to simply omit it from the config_found() call. -- thorpej
Re: VirtualBox guest additions build failure
> On Apr 27, 2021, at 5:23 PM, Valery Ushakov wrote: > > On Tue, Apr 27, 2021 at 21:45:10 +0100, Chavdar Ivanov wrote: > >> I switched early today my VirtualBox NetBSD-current guest; as usual, I >> rebuilt the additions (it works without them, but it is better to have >> them - e.g. without them the X cursor is almost invisible). There are >> a couple of patches I always have to apply under -current, which I >> did; it failed further with an error due to implicit function >> declaration >> >> ... >> src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c:419:25: error: >> implicit declaration of function ?config_found_ia?; did you mean >> ?config_found?? [-Werror=implicit-function-declaration] > > This is probably the recent config changes committed by thorpej@. > > I'd appreciate a quick TL;DR and the condition to check to choose the > new API and I will make the change in the VBox tree. #if __NetBSD_Version__ >= 999008200 config_found(parent, aux, printfn, CFARG_IATTR, "whatever", CFARG_EOL); #else config_found_ia(...); #endif FWIW, I've also updated the autoconf(9) man page. -- thorpej
Re: VirtualBox guest additions build failure
On Tue, Apr 27, 2021 at 21:45:10 +0100, Chavdar Ivanov wrote: > I switched early today my VirtualBox NetBSD-current guest; as usual, I > rebuilt the additions (it works without them, but it is better to have > them - e.g. without them the X cursor is almost invisible). There are > a couple of patches I always have to apply under -current, which I > did; it failed further with an error due to implicit function > declaration > > ... > src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c:419:25: error: > implicit declaration of function ?config_found_ia?; did you mean > ?config_found?? [-Werror=implicit-function-declaration] This is probably the recent config changes committed by thorpej@. I'd appreciate a quick TL;DR and the condition to check to choose the new API and I will make the change in the VBox tree. -uwe
Re: VirtualBox guest additions build failure
Chavdar Ivanov wrote: >I switched early today my VirtualBox NetBSD-current guest; as usual, I >rebuilt the additions (it works without them, but it is better to have >them - e.g. without them the X cursor is almost invisible). There are >a couple of patches I always have to apply under -current, which I >did; it failed further with an error due to implicit function >declaration > >... >src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c:419:25: error: >implicit declaration of function ‘config_found_ia’; did you mean >‘config_found’? [-Werror=implicit-function-declaration] >... > >I replaced all > -Werror-implicit-function-delcaration >in Config.kmk with > -Wno-error=implicit-function-declaration I wouldn't expect it to work with an undefined function, you will need to replace the call to config_found_ia() with one to config_found() and change the arguments, there are examples in the tree to copy.
