Re: Recent new atf test failures

2014-03-27 Thread Andreas Gustafsson
Paul Goyette wrote:
 Some time in the last two weeks, we've had a few new test cases failing 
 in my amd64 test-bed.
 
 Tests that used to pass, but currently failing
 
   lib/csu/t_crt0/initfini3
   atf/atf-c/macros_test/detect_unused_tests
   atf/atf-c++/macros_test/detect_unused_tests

These started failing with Christos' commit of src/share/mk/bsd.own.mk
1.784 on 2014-03-11 23:22:36, with the commit message switch amd64 to
gcc-4.8.
-- 
Andreas Gustafsson, g...@gson.org


Re: Recent new atf test failures

2014-03-27 Thread Martin Husemann
On Thu, Mar 27, 2014 at 09:33:40AM +0200, Andreas Gustafsson wrote:
  atf/atf-c/macros_test/detect_unused_tests
  atf/atf-c++/macros_test/detect_unused_tests
 
 These started failing with Christos' commit of src/share/mk/bsd.own.mk
 1.784 on 2014-03-11 23:22:36, with the commit message switch amd64 to
 gcc-4.8.

The detect_unused_tests are generic gcc 4.8.x bugs, there are upstream
tickets for it (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57201).

Martin


Recent new atf test failures

2014-03-26 Thread Paul Goyette
Some time in the last two weeks, we've had a few new test cases failing 
in my amd64 test-bed.


Tests that used to pass, but currently failing

lib/csu/t_crt0/initfini3
atf/atf-c/macros_test/detect_unused_tests
atf/atf-c++/macros_test/detect_unused_tests

Tests that currently fail, but don't seem to exist in older builds

lib/libm/t_exp/exp2_powers
lib/libm/t_exp/exp2_values



-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


Re: Recent new atf test failures

2014-03-26 Thread David Laight
On Wed, Mar 26, 2014 at 12:25:53PM -0700, Paul Goyette wrote:
 Some time in the last two weeks, we've had a few new test cases failing 
 in my amd64 test-bed.
 
 Tests that used to pass, but currently failing
 
   lib/csu/t_crt0/initfini3
   atf/atf-c/macros_test/detect_unused_tests
   atf/atf-c++/macros_test/detect_unused_tests
 
 Tests that currently fail, but don't seem to exist in older builds
 
   lib/libm/t_exp/exp2_powers
   lib/libm/t_exp/exp2_values

Those are some more extensive tests for exp2().

The exp2_powers tests are failing to generate an 'overflow' result.
They work for me on a real system - so it might be a qemu issue?

Maybe qemu is using the x87 fpu (with 80 bit precision) to emulate
the 64bit (and 32bit) SSE2 double (and float) maths - so the large
mutiplies used to generate overflow fail.

Actually, I wonder, have you rebuilt qemu since jeorg changed the
default x87 precision to 80bits?
That might be the difference between your tests and gson's tests
(which only show some minor errors for exp2f(7.7) and exp2f(8.8).

The exp2_values tests is showing up something odd in FP maths.
I've not changes the exp2f() code, but I'm seeing different
errors in my own testing (native on amd64) from earlier tests.
However it might just be that the allowed error is too small.

I've a local version of exp2() that uses the x87 'f2xm1' and 'fscale'
instructions on both i386 and amd64.
I do need to do a clock-count comparison for 'f2xm1', but I expect it
to be faster than the table lookup and 5th degree polynomial.
Intel claim these functions are monatonic, I bet the polynomial
version isn't.

David

-- 
David Laight: da...@l8s.co.uk


Re: Recent new atf test failures

2014-03-26 Thread Paul Goyette

On Wed, 26 Mar 2014, David Laight wrote:


On Wed, Mar 26, 2014 at 12:25:53PM -0700, Paul Goyette wrote:

Some time in the last two weeks, we've had a few new test cases failing
in my amd64 test-bed.

Tests that used to pass, but currently failing

lib/csu/t_crt0/initfini3
atf/atf-c/macros_test/detect_unused_tests
atf/atf-c++/macros_test/detect_unused_tests

Tests that currently fail, but don't seem to exist in older builds

lib/libm/t_exp/exp2_powers
lib/libm/t_exp/exp2_values


Those are some more extensive tests for exp2().

The exp2_powers tests are failing to generate an 'overflow' result.
They work for me on a real system - so it might be a qemu issue?

Maybe qemu is using the x87 fpu (with 80 bit precision) to emulate
the 64bit (and 32bit) SSE2 double (and float) maths - so the large
mutiplies used to generate overflow fail.


Ah, OK.



Actually, I wonder, have you rebuilt qemu since jeorg changed the
default x87 precision to 80bits?
That might be the difference between your tests and gson's tests
(which only show some minor errors for exp2f(7.7) and exp2f(8.8).


No, I have not updated my qemu recently (several months).



The exp2_values tests is showing up something odd in FP maths.
I've not changes the exp2f() code, but I'm seeing different
errors in my own testing (native on amd64) from earlier tests.
However it might just be that the allowed error is too small.


-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


Re: Recent new atf test failures

2014-03-26 Thread David Laight
On Wed, Mar 26, 2014 at 02:57:15PM -0700, Paul Goyette wrote:
 On Wed, 26 Mar 2014, David Laight wrote:
 
 Actually, I wonder, have you rebuilt qemu since jeorg changed the
 default x87 precision to 80bits?
 That might be the difference between your tests and gson's tests
 (which only show some minor errors for exp2f(7.7) and exp2f(8.8).
 
 No, I have not updated my qemu recently (several months).

That change was somewhere near the end of last year.
The behaviour depends on the binutils version at the time the program
was linked.
There isn't a sysctl to force 64 or 80 bit modes.

David

-- 
David Laight: da...@l8s.co.uk