Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-19 Thread Christos Zoulas
In article <20140908120242.1123c17f...@rebar.astron.com>,
Christos Zoulas  wrote:
>On Sep 8, 12:47pm, a...@absd.org (David Brownlee) wrote:
>-- Subject: Re: Wedges & sysinst (Was: Wedges enabled on -current)
>
>| Its been three weeks since wedges mbr and disklabels was enabled in
>| current, breaking sysinst installs.
>| 
>| If people do not have time to look at updating sysinst right now, could I
>| suggest switching it back off for at least disklabels (maybe leaving
>| enabled for mbrlabel and others), so we are at least building usable
>| current images?
>| 
>| Or is there a plan/timeline for updating sysinst?
>
>There is no plan for fixing sysinst, switch it back. We learned what we needed
>to learn.

And we've switched back to no wedge autodiscovery for bsd and mbr labels.

christos



Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-14 Thread Robert Elz
Date:Sun, 14 Sep 2014 23:12:32 +0100
From:Justin Cormack 
Message-ID:  


  | There are some gpt options, in partition manager you can switch from
  | MBR to GPT.

I know (from reading the sources) that it is supposed to be there (and
I think "switch from mbr" should work to initialize a blank drive with gpt)
but for me, those menu items did not appear - or not anywhere I could find
them.)

I also tried a NetBSD 7_BETA install (where the switch to autodiscovery of
wedges has not been made) and there were no GPT menu items visible
anywhere I could see there either.

kre



Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-14 Thread Justin Cormack
On Sat, Sep 13, 2014 at 11:03 AM, Martin Husemann  wrote:
> On Sat, Sep 13, 2014 at 08:25:24AM +0700, Robert Elz wrote:
>> I cannot get any mention of gpt partitioning to appear anywhere - using
>> an amd64 xen domU install kernel 7.99.1 (from a day or two ago).
>
> It checks wether some binaries are available in $PATH and hides menus
> (for gpt, lvm, cgd, ...) silently if they are not found - I haven't
> tried that install kernel image yet, and also there may be bugs in the
> "hiding" code.

There are some gpt options, in partition manager you can switch from
MBR to GPT. Unfortunately you cant install into the dk* devices, and
cant install into the raw devices either, so its all rather broken.

Justin


Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-13 Thread Martin Husemann
On Sat, Sep 13, 2014 at 08:25:24AM +0700, Robert Elz wrote:
> I cannot get any mention of gpt partitioning to appear anywhere - using
> an amd64 xen domU install kernel 7.99.1 (from a day or two ago).

It checks wether some binaries are available in $PATH and hides menus
(for gpt, lvm, cgd, ...) silently if they are not found - I haven't
tried that install kernel image yet, and also there may be bugs in the
"hiding" code.

Need to have a closer look...

Martin


Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-12 Thread Robert Elz
Date:Sat, 23 Aug 2014 14:15:14 +0200
From:Martin Husemann 
Message-ID:  <20140823121514.gc21...@mail.duskware.de>

  | Sysinst allows creating gpt partitions already,

I had never seen any sign of that, but I knew that could have been
just from a lack of observation (expecting the way sysinst would work
and just going through the motions on auto-pilot).  But today I got
a chance to do some tests, and I still haven't see any sign of that
(operationally - I can see what looks to be code to attempt it in the
sysinst sources).

I cannot get any mention of gpt partitioning to appear anywhere - using
an amd64 xen domU install kernel 7.99.1 (from a day or two ago).

Where should I be seeing it?

  | but there are "issues" to be fixed (probably lots of them),

One obvious one I see is that the code does ...

   "sh -c 'gpt show %s |grep -e Pri\\ GPT\\ table'", dev);

to see if there's already a GPT label ... but that cannot work (in this
setup anyway) as there's no grep command to run on the mini-root (md0a
in the install kernel).   Maybe other install kernel images have one, but
not the one I was using (it does have grep() defined as a function using
sed in /.profile but that's useless for this purpose, even if it were found,
as sed doesn't set its exit code based upon whether the pattern is found or
not the way grep does.)

It would be useful if the gpt command either had a subcommand to test
(and return an exit code) to see whether there's already a GPT label,
or if the exit code of gpt show could be used for that purpose (at the
minute, assuming correct usage, it always seems to exit(0), whether there's
a GPT label or not.)  Then the grep looking for a string, which could in
theory change for almost any reason, wouldn't be needed.

That is not the underlying cause of my not seeing any gpt related menu
entries however, I was installing to a virgin disk partition, it had no
labels of any kind on it (no mbr, no disklabel, no gpt) so whether that
command failed for lack of grep, or for lack of a GPT table, really
makes no difference (if it succeeded, as I read the code, it should have
been forcing GPT partitioning, and that certainly didn't happen.)

I tried creating a GPT table by hand (/sbin/gpt is in the root) which
worked, but made no difference at all to sysinst.

  | and right now in -current it does not deal well with the wedge
  | autodetection.

Yes, I understand that issue (I think) - that's a problem for mbr/disklabel
based installs, right? - I wanted to install into a gpt partitioned drive,
which if sysinst supports it at all, would have to be able to use wedges.
But I didn't get that far...

kre



Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-09-08 Thread Christos Zoulas
On Sep 8, 12:47pm, a...@absd.org (David Brownlee) wrote:
-- Subject: Re: Wedges & sysinst (Was: Wedges enabled on -current)

| Its been three weeks since wedges mbr and disklabels was enabled in
| current, breaking sysinst installs.
| 
| If people do not have time to look at updating sysinst right now, could I
| suggest switching it back off for at least disklabels (maybe leaving
| enabled for mbrlabel and others), so we are at least building usable
| current images?
| 
| Or is there a plan/timeline for updating sysinst?

There is no plan for fixing sysinst, switch it back. We learned what we needed
to learn.

christos


Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-08-23 Thread Martin Husemann
On Sat, Aug 23, 2014 at 06:20:39AM +0700, Robert Elz wrote:
> I suspect that (instead of enabling auto wedge detection on existing labels
> as the next step forward - ie: undoing what was recently done) sysinst be
> updated (for i386 and amd64 at least) to offer GPT instead of disklabel
> installs (as the default for amd64 & i386 - other ports probably need more
> investigation to see how GPT can fit into the existing partitioning scheme so
> booting still works).

Sysinst allows creating gpt partitions already, but there are "issues"
to be fixed (probably lots of them), and right now in -current it does
not deal well with the wedge autodetection.

Martin


Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-08-22 Thread Christos Zoulas
On Aug 23,  6:20am, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: Wedges & sysinst (Was: Wedges enabled on -current)

| I had been meaning to ask that too, but with a slightly different emphasis.
| 
| I suspect that (instead of enabling auto wedge detection on existing labels
| as the next step forward - ie: undoing what was recently done) sysinst be
| updated (for i386 and amd64 at least) to offer GPT instead of disklabel
| installs (as the default for amd64 & i386 - other ports probably need more
| investigation to see how GPT can fit into the existing partitioning scheme so
| booting still works).
| 
| That will get more people using wedges, in a more natural way than by
| forcing existing labels to convert, and so allow more of the remaining
| other issues to be solved, before breaking things for people with existing
| setups just doing a kernel update.

Could be. The reason for turning it on was really to see what we were missing,
what new problems wedges create, and if and how thy improve the status quo.
For years we have been avoiding the issue

christos


Re: Wedges & sysinst (Was: Wedges enabled on -current)

2014-08-22 Thread Robert Elz
Date:Fri, 22 Aug 2014 21:00:52 +0100
From:David Brownlee 
Message-ID:  


  | Is there a plan to update sysinst?

I had been meaning to ask that too, but with a slightly different emphasis.

I suspect that (instead of enabling auto wedge detection on existing labels
as the next step forward - ie: undoing what was recently done) sysinst be
updated (for i386 and amd64 at least) to offer GPT instead of disklabel
installs (as the default for amd64 & i386 - other ports probably need more
investigation to see how GPT can fit into the existing partitioning scheme so
booting still works).

That will get more people using wedges, in a more natural way than by
forcing existing labels to convert, and so allow more of the remaining
other issues to be solved, before breaking things for people with existing
setups just doing a kernel update.

kre



Wedges & sysinst (Was: Wedges enabled on -current)

2014-08-22 Thread David Brownlee
On 18 August 2014 07:28, Christos Zoulas  wrote:
> Hi,
>
> Now that we have branched 7, I am planning to enable full wedge support for
> kernels that used wedges before. What this means is that disks with mbr and
> bsd labels will now create dkN devices for each partition in found. This
> should be generally transparent, because fstab offers backwards compatibility
> support. I.e. in the general case, your machine should boot and work fine
> without requiring any changes. There are some corner cases:
> [...]

Is there a plan to update sysinst?

I just tried to boot the HEAD amd64 install.img to try to test DRMKMS
and it first failed to find sysinst, and when run manually it prompted
to install onto the base sdX devices and choked. I could install
manually, but I only had a little time to test and didn't want to run
headlong into any other wedge issues.