re: current USE_SSP=yes build failure

2022-08-12 Thread matthew green
i've commited my fix for this after testing it.


.mrg.


re: current USE_SSP=yes build failure

2022-08-01 Thread matthew green
rudolf writes:
> Hi,
>
> I have "USE_SSP=yes" in mk.conf and the build is failing with:
>
> --- dependall-drivers ---
> /usr/xsrc/external/mit/xorg-server/dist/hw/xfree86/drivers/modesetting/drmmode_display.c:
>  
> In function 'drmmode_crtc_gamma_set':
> /usr/xsrc/external/mit/xorg-server/dist/hw/xfree86/drivers/modesetting/drmmode_display.c:1768:1:
>  
> error: stack protector not protecting local variables: variable length 
> buffer [-Werror=stack-protector]
>   1768 | drmmode_crtc_gamma_set(xf86CrtcPtr crtc, uint16_t * red, 
> uint16_t * green,
>| ^~
>
> Is this to be expected? Am I doing something wrong? The function itself 
> is very simple.

ah, this comes from the call this function makes:

if (drmmode_crtc->use_gamma_lut) {
drmmode_set_gamma_lut(drmmode_crtc, red, green, blue, size);

which is:

drmmode_set_gamma_lut(drmmode_crtc_private_ptr drmmode_crtc,
  uint16_t * red, uint16_t * green, uint16_t * blue,
  int size)
[ ... ]
struct drm_color_lut lut[size];


i'll figure out a fix or workaround.  thanks.


.mrg.


current USE_SSP=yes build failure

2022-08-01 Thread rudolf

Hi,

I have "USE_SSP=yes" in mk.conf and the build is failing with:

--- dependall-drivers ---
/usr/xsrc/external/mit/xorg-server/dist/hw/xfree86/drivers/modesetting/drmmode_display.c: 
In function 'drmmode_crtc_gamma_set':
/usr/xsrc/external/mit/xorg-server/dist/hw/xfree86/drivers/modesetting/drmmode_display.c:1768:1: 
error: stack protector not protecting local variables: variable length 
buffer [-Werror=stack-protector]
 1768 | drmmode_crtc_gamma_set(xf86CrtcPtr crtc, uint16_t * red, 
uint16_t * green,

  | ^~

Is this to be expected? Am I doing something wrong? The function itself 
is very simple.


Thanks,

r.