Re: [UPDATE] base-passwd (Was Re: base-passwd sets weird permissions)

2009-05-11 Thread Corinna Vinschen
John,

On May  4 10:51, John Morrison wrote:
 Hi Corinna,
 
 Patch applied...
 
 md5sum for base-passwd-3.0-1.tar.bz2 479cb2a678f712b326dc09a24d329cfe
 http://homepage.ntlworld.com/j-n-s.morrison/john/cygwin/base-passwd/base-passwd-3.0-1.tar.bz2
 
 http://homepage.ntlworld.com/j-n-s.morrison/john/cygwin/base-passwd/md5sum
 
 (not changed...)
 http://homepage.ntlworld.com/j-n-s.morrison/john/cygwin/base-passwd/setup.hint
 
 Let me know if there are any issues :)

Unfortunately there are:

  -cp -f /etc/group /tmp/group.mkgroup  \
  +cp -fp /etc/group /tmp/group.mkgroup  \
   ( [ -w /etc/group ] || chmod --silent a+w /etc/group ; )  \
   echo root:S-1-5-32-544:0:  /etc/group  \
  -sed -e '/:S-1-1-0:/d' -e '/root:S-1-5-32-544:0:/d' /tmp/group.mkgroup 
  /etc/group  \
  +sed -e '/root:S-1-5-32-544:0:/d' /tmp/group.mkgroup  /etc/group  \
   chmod --silent --reference=/etc/passwd /etc/group
   rm -f /tmp/group.mkgroup

At this point in the patch you also removed the 

  echo root:S-1-5-32-544:0:  /etc/group  \

line for some reason.  The result is now that the /etc/group file
contains all entries twice, and the root entry is still missing.
That's a problem.  Can you please update the base-passwd package?


Thanks,
Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader  cygwin AT cygwin DOT com
Red Hat


Re: [UPDATE] base-passwd (Was Re: base-passwd sets weird permissions)

2009-05-11 Thread John Morrison
Sorry.  Please revert and I'll try and find the time tonight to do it again.

J.



Re: [Patch] Clear button for setup.exe package search

2009-05-11 Thread Corinna Vinschen
On May  8 10:56, Thrall, Bryan wrote:
 Add a button to clear the setup.exe package search filter.
 
 ChangeLog:
 
 2009-05-08  Bryan Thrall  bryan.thr...@flightsafety.com
   * choose.cc (ChooserPage::OnMessageCmd): Clear search filter
 when clear button clicked.
   * res.rc (IDD_CHOOSE_DIALOG): Add IDC_CHOOSE_CLEAR_SEARCH
 button.
   * resource.h (IDC_CHOOSE_CLEAR_SEARCH): New button resource ID.

Thanks.  I applied a slightly tweaked version of the patch.


Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader  cygwin AT cygwin DOT com
Red Hat


Re: [1.7] Setup.exe default ownership of files in fresh install [Admin:None?]

2009-05-11 Thread Corinna Vinschen
On May  9 12:33, Chris Rodgers wrote:
 Dear List,

 I have two admin accounts on a Windows XP Pro machine. I installed  
 Cygwin 1.7 beta using Admin1 initially. This morning, I tried to update  
 some packages from account Admin2.

 I kept getting errors about not being able to update files because they  
 were in use.

 It turned out that I just needed to blow away all the permissions from  
 the cygwin tree and add an inheritable ACL for the Administrators group.

So you removed all the carefully crafted POSIX permissions.  Oh well.

 But - as the other posters have said, shouldn't setup just default to  
 installing as Administrators rather than a specific admin user so that  
 it is possible to share the cygwin tree between users?

I applied a patch to setup which allows all admins to replace files in a
given installation without falling back to non-POSIX permissions.  I
just uploaded setup version 2.621 to http://cygwin.com/setup-1.7.exe
which contains that patch.


Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader  cygwin AT cygwin DOT com
Red Hat


Re: Two other quick things about setup.exe

2009-05-11 Thread Corinna Vinschen
On May  9 12:35, Chris Rodgers wrote:
 Dear List,

 I noticed two other small things this morning:

 (1) Pressing ENTER in the search box at the top of the package  
 selection screen causes installation to continue to the next stage.

 Would it be possible to ignore ENTER in that box?

I would love that, too.  I'm not fluent enough in gooey programming to
implement that, unfortunately.


Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader  cygwin AT cygwin DOT com
Red Hat


Re: [UPDATE] base-passwd (Was Re: base-passwd sets weird permissions)

2009-05-11 Thread Corinna Vinschen
On May 11 11:47, John Morrison wrote:
 Sorry.  Please revert and I'll try and find the time tonight to do it again.

I uploaded a fixed 3.1-1 package instead.  I hope you don't mind.


Corinna

-- 
Corinna Vinschen  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader  cygwin AT cygwin DOT com
Red Hat


Re: [UPDATE] base-passwd (Was Re: base-passwd sets weird permissions)

2009-05-11 Thread John Morrison
On Mon, May 11, 2009 12:26 pm, Corinna Vinschen wrote:
 On May 11 11:47, John Morrison wrote:
 Sorry.  Please revert and I'll try and find the time tonight to do it
 again.

 I uploaded a fixed 3.1-1 package instead.  I hope you don't mind.

Nope, heck you know more about what it does than I do!

J.



[PATCH] Change setup.exe local directory screen description depending on install type

2009-05-11 Thread Thrall, Bryan

setup.exe's current local directory screen doesn't accurately describe
the purpose of the local directory when the user is installing from a
local mirror (rather than downloading or download-and-installing), which
can be confusing. The attached patch changes the description based on
what the install type is.

ChangeLog entry:

2009-05-11  Bryan Thrall  bryan.thr...@flightsafety.com

* localdir.cc (load_dialog): Choose description string based on
install type.
* res.rc (IDD_LOCAL_DIR): Replace static description text with
IDC_LOCAL_DIR_DESC.
* resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
(IDS_LOCAL_DIR_INSTALL): Likewise.
(IDC_LOCAL_DIR_DESC): New text control resource id.

--
Bryan Thrall
FlightSafety International
bryan.thr...@flightsafety.com
 


localdir_desc.patch
Description: localdir_desc.patch


Re: [PATCH] Change setup.exe local directory screen description depending on install type

2009-05-11 Thread Christopher Faylor
On Mon, May 11, 2009 at 10:50:41AM -0500, Thrall, Bryan wrote:
2009-05-11  Bryan Thrall  bryan.thr...@flightsafety.com

   * localdir.cc (load_dialog): Choose description string based on install 
 type.
   * res.rc (IDD_LOCAL_DIR): Replace static description text with 
 IDC_LOCAL_DIR_DESC.
   * resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
   (IDS_LOCAL_DIR_INSTALL): Likewise.
   (IDC_LOCAL_DIR_DESC): New text control resource id.

Applied.  Thanks.

cgf