Re: [ITA] base-files
Hi Achim,
On Mar 15 18:45, Achim Gratz wrote:
Since the current maintainer David Le Sastre Medina seems to have gone
missing, here's my attempt to wrap up the changes that were implemented
after the 4.1-2 package was published as experimental (and then never
released). The pertinent discussions on the Cygwin ML are listed in the
ChangeLog.
Change Log
--
4.1-3
* Eliminate Windows PATH from default PATH if CYGWIN_NOWINPATH is
set. Record the Windows PATH in ORIGINAL_PATH unless that
variable is already set.
* Better guard for non-existent /etc/skel.
* Improve profile_d function.
cygwin.com/ml/cygwin/2012-08/msg00488.html
* Add /etc/shells.
cygwin.com/ml/cygwin/2014-03/msg00039.html
* Use full path for tools and avoid DOS file warning when creating
service files.
cygwin.com/ml/cygwin/2013-07/msg00114.html
Git repository (originally cloned from GitHub):
http://repo.or.cz/w/cygwin-base-files.git
Test package:
--8---cut here---start-8---
wget=wget -rxnH --cut-dirs=2 http://cygwin.stromeko.net/noarch/release;
${wget}/base-files/base-files/base-files-4.1-3.tar.xz
^
There's one base-files too much.
A few (rather minor) notes:
- I think you should bump the version number. 4.2 or whatever.
- In etc/postinstall/base-files-mketc.sh:
/usr/bin/chmod 1777 /tmp 2/dev/null
This looks gratuitious. Setup itself already sets /tmp to 1777.
I never heard of somebody changing the permission of /tmp to
something else, so it probably doesn't hurt...
- In etc/defaults/etc/profile:
Just a heads-up. Be prepared to remove the entire section about
mkpasswd/mkgroup checking. It won't work as expected anymore as soon
as my AD integration code goes release. Along these lines, I will
update the base-cygwin package not to create passwd and group files
anymore.
- Do we still need etc/defaults/etc/profile.d/1777fix.sh? How long has
it been?
Other than that, it looks good to me. I'd say, let's go for it when
you're ready.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
pgps351IR7_kG.pgp
Description: PGP signature
Re: [ITA] base-files
Corinna Vinschen writes:
--8---cut here---start-8---
wget=wget -rxnH --cut-dirs=2 http://cygwin.stromeko.net/noarch/release;
${wget}/base-files/base-files/base-files-4.1-3.tar.xz
^
There's one base-files too much.
Thanks for catching that, sorry. The middle button of my mouse acts up
since a few days and produces additional clicks sometimes…
A few (rather minor) notes:
- I think you should bump the version number. 4.2 or whatever.
I've no problem doing that once everything else is finalized.
- In etc/postinstall/base-files-mketc.sh:
/usr/bin/chmod 1777 /tmp 2/dev/null
This looks gratuitious. Setup itself already sets /tmp to 1777.
I never heard of somebody changing the permission of /tmp to
something else, so it probably doesn't hurt...
That has been in there since the 4.0 release. I cannot find out what
problem it was supposed to solve (it was introduced at the end of 2010).
I can remove it if setup.exe already does that.
- In etc/defaults/etc/profile:
Just a heads-up. Be prepared to remove the entire section about
mkpasswd/mkgroup checking. It won't work as expected anymore as soon
as my AD integration code goes release. Along these lines, I will
update the base-cygwin package not to create passwd and group files
anymore.
:-)
- Do we still need etc/defaults/etc/profile.d/1777fix.sh? How long has
it been?
Almost exactly two years. Again I can't really follow what the original
problem was, but if it's been solved in a different way in the meantime,
then that script certainly can be removed.
Other than that, it looks good to me. I'd say, let's go for it when
you're ready.
I still need to wait for Chuck to create an inetutils package without
/etc/defaults/etc/shells. Then we'll probably need someone with
sourceware access to create the four !ready files so that the upload
gets done in synchrony.
Regards,
Achim.
--
+[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]+
SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada
Re: [ITA] base-files
On Sun, Mar 16, 2014 at 06:09:22PM +0100, Achim Gratz wrote: Corinna Vinschen writes: Other than that, it looks good to me. I'd say, let's go for it when you're ready. I still need to wait for Chuck to create an inetutils package without /etc/defaults/etc/shells. Then we'll probably need someone with sourceware access to create the four !ready files so that the upload gets done in synchrony. The files are moved a 14 minutes past the hour. Just don't upload a couple of minutes befor that time and you won't require error-prone external help. cgf
