Re: Putting packages up for adoption

[Andrew Schulman via Cygwin-apps]

> On Mar 19 23:47, Yaakov Selkowitz wrote:
> > Hello Cygwin package maintainers,

 
> > To that end, in the best interest of the community, please consider my
> > packages up for adoption. 


> > Yaakov
> 
> There's no number of goldstars or plush hippos which would do justice to
> what you did for Cygwin, Yaakov.  If there's something like the ULTIMATE
> PLUSH HIPPO REPLACING EVRY OTHER PLUSH HIPPO, you should get it.

Well that's what I get for not checking the list for a week.

I'm happy to oblige, and I have sort of a picture in my head of what that
might look like, but I'm not skilled at rendering it. If anyone has any
recommendations, please send to me directly by email.

Andrew

Re: Putting packages up for adoption

[Jan Nijtmans via Cygwin-apps]

Op di 24 mrt. 2020 om 15:25 schreef Yaakov Selkowitz:
> Fedora, and possibly other distros as well, set a default search path
> for tcl that conforms with their desired filesystem layout -- having
> all extensions under /usr/{lib,share}/tclX.Y instead of scattered
> throughout /usr/{lib,share}.

Thank you! It's 100% clear to me now. It's just about customising
to Fedora's directory layout. They have the right to do that, I have
the right to ignore it ;-).

Regards,
Jan Nijtmans


Regards,
 Jan Nijtmans

Re: Putting packages up for adoption

[Yaakov Selkowitz]

On Tue, 2020-03-24 at 15:11 +0100, Jan Nijtmans via Cygwin-apps wrote:
> Op di 24 mrt. 2020 om 14:51 schreef Yaakov Selkowitz:
> > > However, I created a "fedora" branch in (upstream) Tcl, in which
> > > I merged the two patches from fedora. Result:
> > >  
> > 
> > The errors I see there are "Test file error: can't find package
> > tcltests", which sounds like an issue with the test environment and not
> > on those changes.
> 
> The point is, Tcl has a specific order of paths where it searches its
> environment, like an $auto_path variable. The test-suite tests
> this algorithm, and - apparently - the outcome of the algorith
> changed. You can add additional paths, but you cannot change
> the order of existing paths that are searched. So, sorry, but
> I respectfully disagree. The test-suite adds a path where it
> can find the "tcltests" package, the fedora changes result
> in not finding that package any more. That's a bug in the
> path search algorithm, which is modified by the fedora patch.

Fedora, and possibly other distros as well, set a default search path
for tcl that conforms with their desired filesystem layout -- having
all extensions under /usr/{lib,share}/tclX.Y instead of scattered
throughout /usr/{lib,share}.  Customing the directory layout of
interpreted language extensions is a common and accepted downstream
practice.  Therefore, it would be a bug in the test environment, e.g.
in not using the Tcl it is testing to determine where tcltests should
be installed.

--
Yaakov

Re: Putting packages up for adoption

[Jan Nijtmans via Cygwin-apps]

Op di 24 mrt. 2020 om 14:51 schreef Yaakov Selkowitz:
> > However, I created a "fedora" branch in (upstream) Tcl, in which
> > I merged the two patches from fedora. Result:
> >  
>
> The errors I see there are "Test file error: can't find package
> tcltests", which sounds like an issue with the test environment and not
> on those changes.

The point is, Tcl has a specific order of paths where it searches its
environment, like an $auto_path variable. The test-suite tests
this algorithm, and - apparently - the outcome of the algorith
changed. You can add additional paths, but you cannot change
the order of existing paths that are searched. So, sorry, but
I respectfully disagree. The test-suite adds a path where it
can find the "tcltests" package, the fedora changes result
in not finding that package any more. That's a bug in the
path search algorithm, which is modified by the fedora patch.

Regards,
 Jan Nijtmans

Re: Putting packages up for adoption

[Yaakov Selkowitz]

On Tue, 2020-03-24 at 12:41 +0100, Jan Nijtmans via Cygwin-apps wrote:
> Op di 24 mrt. 2020 om 00:38 schreef Yaakov Selkowitz:
> > > Hm. It appears that they did:
> > >  
> > 
> > I meant their mingw-tcl package.
> 
> Indeed, you are right!
> 
> However, I created a "fedora" branch in (upstream) Tcl, in which
> I merged the two patches from fedora. Result:
>  

The errors I see there are "Test file error: can't find package
tcltests", which sounds like an issue with the test environment and not
on those changes.

> So, I wonder if they ran the Tcl test suite  this gives not
> much thrust, since they changes assumptions made
> in the test-cases, assumptions that user-applications
> and other environments could depend on.

--
Yaakov

Re: Putting packages up for adoption

[Jan Nijtmans via Cygwin-apps]

Op di 24 mrt. 2020 om 00:38 schreef Yaakov Selkowitz:
> > Hm. It appears that they did:
> >  
>
> I meant their mingw-tcl package.

Indeed, you are right!

However, I created a "fedora" branch in (upstream) Tcl, in which
I merged the two patches from fedora. Result:
 

So, I wonder if they ran the Tcl test suite  this gives not
much thrust, since they changes assumptions made
in the test-cases, assumptions that user-applications
and other environments could depend on.

Regards,
 Jan Nijtmans