Re: [cygport PATCH] Check for pythonXX-wheel when using python-wheel

2023-10-27 Thread Jon Turney via Cygwin-apps 

On 27/10/2023 09:41, Adam Dinwoodie via Cygwin-apps wrote:

The python wheel package is required for building using the python-wheel
cygclass, but nothing in cygport verifies its existence, and the error
from the Python commands themselves aren't particularly helpful either.
To avoid other people wasting the time I just did trying to debug Python
build errors, check if the relevant wheel executable is installed, and
complain if it isn't.


Thanks. Applied.

Depending on the path taken to hit the error, this seems like it might 
well be an oversight in 2596f685, for which I apologise.



---
  cygclass/python-wheel.cygclass | 1 +
  1 file changed, 1 insertion(+)

diff --git a/cygclass/python-wheel.cygclass b/cygclass/python-wheel.cygclass
index 4f71639d..3f274b98 100644
--- a/cygclass/python-wheel.cygclass
+++ b/cygclass/python-wheel.cygclass
@@ -111,6 +111,7 @@ do
esac
  
  	check_prog_req pip${ver} python${ver//.}-pip

+   check_prog_req wheel-${ver} python${ver//.}-wheel
  done
  
  #o* python-wheel.cygclass/PKG_NAMES (python-wheel)

[cygport PATCH] Check for pythonXX-wheel when using python-wheel

2023-10-27 Thread Adam Dinwoodie via Cygwin-apps 
The python wheel package is required for building using the python-wheel
cygclass, but nothing in cygport verifies its existence, and the error
from the Python commands themselves aren't particularly helpful either.
To avoid other people wasting the time I just did trying to debug Python
build errors, check if the relevant wheel executable is installed, and
complain if it isn't.
---
 cygclass/python-wheel.cygclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cygclass/python-wheel.cygclass b/cygclass/python-wheel.cygclass
index 4f71639d..3f274b98 100644
--- a/cygclass/python-wheel.cygclass
+++ b/cygclass/python-wheel.cygclass
@@ -111,6 +111,7 @@ do
esac
 
check_prog_req pip${ver} python${ver//.}-pip
+   check_prog_req wheel-${ver} python${ver//.}-wheel
 done
 
 #o* python-wheel.cygclass/PKG_NAMES (python-wheel)
-- 
2.40.1