Re: [Review] sgrep-1.92.1-1 - No good to go yet
Jari == Jari Aalto writes: Jari Based on comments for sgrep I've repackaged the project. Please review. Jari http://tierra.dyndns.org:81/cygwin/sgrep/setup.hint Jari http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1-src.tar.bz2 Jari http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1.tar.bz2 Hi Jari o From the cygwin specific README: Build instructions: unpack sgrep-1.92.1-1-src.tar.bz2 if you use setup to install this src package, it will be unpacked under /usr/src automatically cd /usr/src ./cygbuild*.sh all But the build script is sgrep-1.92.1-1.sh o The packaging list claims that the sample sgreprc file is located under /etc/defaults/etc/sample.sgreprc but it actually is under /etc/defaults/sgreprc Is this the right location anyway ? and shouldn't it get copied to /usr/share in a postinstall script ? o The man page says that sgreprc would be searched under /usr/lib/sgreprc Can we patch this to /usr/share o There is still an error in the build script: When I run bash ./sgrep*sh -v all I get -- cygbuild.sh 2004-01-26 1.230 http://cygbuild.sourceforge.net/ -- Wait, examining environment and preparing variables ./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected ./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected -- Extracting /tmp/sgrep/sgrep-1.92.1.tar.gz Other than that, it seems to work fine. Ciao Volker
RE: [Review] sgrep-1.92.1-1 - No good to go yet
From: Dr. Volker Zell o The packaging list claims that the sample sgreprc file is located under /etc/defaults/etc/sample.sgreprc but it actually is under /etc/defaults/sgreprc Is this the right location anyway ? and shouldn't it get copied to /usr/share in a postinstall script ? it should be /etc/defaults/etc/.sgreprc if it is to be copied to /etc/.sgreprc or /etc/defaults/usr/share/sample.sgreprc if it to be copied to /usr/share/sample.sgreprc J. This e-mail has come from Experian International: winner of the UK's National Business of the Year Award 2003. == Information in this e-mail and any attachments are confidential, and may not be copied or used by anyone other than the addressee, nor disclosed to any third party without our permission. There is no intention to create any legally binding contract or other binding commitment through the use of this electronic communication unless it is issued in accordance with the Experian Limited standard terms and conditions of purchase or other express written agreement between Experian Limited and the recipient Experian Limited (registration number 653331) Registered office: Talbot House, Talbot Street, Nottingham NG80 1TH Although Experian has taken reasonable steps to ensure that this communication and any attachments are free from computer virus, you are advised to take your own steps to ensure that they are actually virus free.
Re: [Review] sgrep-1.92.1-1 - No good to go yet
* Tue 2004-01-27 Dr. Volker Zell [EMAIL PROTECTED] list.cygwin-apps * Message-Id: [EMAIL PROTECTED] | Jari == Jari Aalto writes: | | o From the cygwin specific README: | | Build instructions: | unpack sgrep-1.92.1-1-src.tar.bz2 | if you use setup to install this src package, it will be | unpacked under /usr/src automatically | cd /usr/src | ./cygbuild*.sh all | | But the build script is sgrep-1.92.1-1.sh Fixed. | o The packaging list claims that the sample sgreprc file is located under | | /etc/defaults/etc/sample.sgreprc | | but it actually is under | | /etc/defaults/sgreprc | | Is this the right location anyway ? and shouldn't it get copied to | /usr/share in a postinstall script ? | | o The man page says that sgreprc would be searched under /usr/lib/sgreprc | | Can we patch this to /usr/share I'm confused about the use of different directories. I'll ask about this more in separate topic. | o There is still an error in the build script: | | When I run bash ./sgrep*sh -v all I get | | -- cygbuild.sh 2004-01-26 1.230 http://cygbuild.sourceforge.net/ | -- Wait, examining environment and preparing variables | ./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected | ./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected | -- Extracting /tmp/sgrep/sgrep-1.92.1.tar.gz Can you run it with debug and send me the results, since I can't reproduce the bug: bash -x ./sgrep*sh -v all (Just send all to me). New package rolled to include those fixes: http://tierra.dyndns.org:81/cygwin/sgrep/setup.hint http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1-src.tar.bz2 http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1.tar.bz2 lynx -dump http://tierra.dyndns.org:81/cygwin/sgrep/get.sh | sh Jari -- http://tiny-tools.sourceforge.net/ Swatch @time http://www.mir.com.my/iTime/itime.htm http://www.ryanthiessen.com/swatch/resources.htm Use Licenses! http://www.linuxjournal.com/article.php?sid=6225 Which Licence? http://www.linuxjournal.com/article.php?sid=4825 OSI Licences http://www.opensource.org/licenses/
