Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 8/9/11 11:51 AM, Peter Li wrote: In light of this, perhaps I should benchmark the cygwin compiled version to make sure it is reasonable to use this rather than insisting on the windows binary. Will report back. P Not too surprising, but the Cygwin version does fine. Rough benchmarks on my 2 core hyperthreaded laptop decompressing a 900K block size 1.5 GB data file: bzip2: ~ 180 s pbzip2 Cygwin: 93 s pbzip2 win32 native: 86 s Will announce. P
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On Aug 8 09:46, Peter Li wrote: On 08/08/2011 01:01 AM, Corinna Vinschen wrote: On Aug 7 20:31, Peter Li wrote: This builds out of the box; I just pulled the packaging files from cygports (thanks!). Think it's worth adding to main distro though. It's in most distros: https://admin.fedoraproject.org/pkgdb/acls/name/pbzip2?_csrf_token=ad400067b7e05d4afe0cb7e74860399022796bce http://packages.ubuntu.com/natty/pbzip2 http://packages.debian.org/search?keywords=pbzip2 http://www.freebsd.org/cgi/cvsweb.cgi/ports/archivers/pbzip2/ category: Archive requires: libbz2_1 libgcc1 libstdc++6 sdesc: Parallel BZIP2 de/compressor ldesc: PBZIP2 is a parallel implementation of the bzip2 block-sorting file compressor that uses pthreads and achieves near-linear speedup on SMP machines. The output of this version is fully compatible with bzip2. If I get a green light I'll go ahead and upload the package from my laptop when I get a moment. Sure. Usually you ITP with URLs to the package files already. It's not so much a question of allowance, but of your intention to maintain a package in the Cygwin distro. As they distribute a windows binary with cygwin.dll, I presume there will be minimal build problems in future. The maintainers seem active and responsive. So I think I can commit to maintain the Cygwin package. wget -x -nH --cut-dirs=2 \ http://chichilnisky.salk.edu/peterli/cygwin/pbzip2/pbzip2-1.1.5-1-src.tar.bz2 http://chichilnisky.salk.edu/peterli/cygwin/pbzip2/pbzip2-1.1.5-1.tar.bz2 Uploaded. Please announce. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 8/8/11 9:08 PM, Peter Li wrote: On 8/8/2011 4:23 PM, Charles Wilson wrote: On 8/8/2011 12:46 PM, Peter Li wrote: As they distribute a windows binary with cygwin.dll, So, if the pbzip2 devs distribute a copy of cygwin1.dll, I assume they also abide by the GPL and distribute the sources for that copy of cygwin? Huh, I seem to have invented this; they are not using cygwin1.dll after all. There are still plenty of such cases of course. I'm still willing to maintain the package. In light of this, perhaps I should benchmark the cygwin compiled version to make sure it is reasonable to use this rather than insisting on the windows binary. Will report back. P
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On Aug 7 20:31, Peter Li wrote: This builds out of the box; I just pulled the packaging files from cygports (thanks!). Think it's worth adding to main distro though. It's in most distros: https://admin.fedoraproject.org/pkgdb/acls/name/pbzip2?_csrf_token=ad400067b7e05d4afe0cb7e74860399022796bce http://packages.ubuntu.com/natty/pbzip2 http://packages.debian.org/search?keywords=pbzip2 http://www.freebsd.org/cgi/cvsweb.cgi/ports/archivers/pbzip2/ category: Archive requires: libbz2_1 libgcc1 libstdc++6 sdesc: Parallel BZIP2 de/compressor ldesc: PBZIP2 is a parallel implementation of the bzip2 block-sorting file compressor that uses pthreads and achieves near-linear speedup on SMP machines. The output of this version is fully compatible with bzip2. If I get a green light I'll go ahead and upload the package from my laptop when I get a moment. Sure. Usually you ITP with URLs to the package files already. It's not so much a question of allowance, but of your intention to maintain a package in the Cygwin distro. Separately, I'm curious what the upshot was on this earlier discussion of pbzip2 incompatibilities: http://cygwin.com/ml/cygwin-apps/2011-03/msg00160.html I think that's fixed in setup. Jon applied a couple of patches to setup on 2011-04-08 which are related, AFAICS. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 08/08/2011 01:01 AM, Corinna Vinschen wrote: On Aug 7 20:31, Peter Li wrote: This builds out of the box; I just pulled the packaging files from cygports (thanks!). Think it's worth adding to main distro though. It's in most distros: https://admin.fedoraproject.org/pkgdb/acls/name/pbzip2?_csrf_token=ad400067b7e05d4afe0cb7e74860399022796bce http://packages.ubuntu.com/natty/pbzip2 http://packages.debian.org/search?keywords=pbzip2 http://www.freebsd.org/cgi/cvsweb.cgi/ports/archivers/pbzip2/ category: Archive requires: libbz2_1 libgcc1 libstdc++6 sdesc: Parallel BZIP2 de/compressor ldesc: PBZIP2 is a parallel implementation of the bzip2 block-sorting file compressor that uses pthreads and achieves near-linear speedup on SMP machines. The output of this version is fully compatible with bzip2. If I get a green light I'll go ahead and upload the package from my laptop when I get a moment. Sure. Usually you ITP with URLs to the package files already. It's not so much a question of allowance, but of your intention to maintain a package in the Cygwin distro. As they distribute a windows binary with cygwin.dll, I presume there will be minimal build problems in future. The maintainers seem active and responsive. So I think I can commit to maintain the Cygwin package. wget -x -nH --cut-dirs=2 \ http://chichilnisky.salk.edu/peterli/cygwin/pbzip2/pbzip2-1.1.5-1-src.tar.bz2 http://chichilnisky.salk.edu/peterli/cygwin/pbzip2/pbzip2-1.1.5-1.tar.bz2 Separately, I'm curious what the upshot was on this earlier discussion of pbzip2 incompatibilities: http://cygwin.com/ml/cygwin-apps/2011-03/msg00160.html I think that's fixed in setup. Jon applied a couple of patches to setup on 2011-04-08 which are related, AFAICS. Thanks! I guess ultimately what I'm keen to know is whether this was a problem that is pbzip2's fault (and did bugs get submitted to them) or a problem that was purely setup.exe's fault or some other category... Best, P
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 08/08/2011 17:46, Peter Li wrote: On 08/08/2011 01:01 AM, Corinna Vinschen wrote: On Aug 7 20:31, Peter Li wrote: Separately, I'm curious what the upshot was on this earlier discussion of pbzip2 incompatibilities: http://cygwin.com/ml/cygwin-apps/2011-03/msg00160.html I think that's fixed in setup. Jon applied a couple of patches to setup on 2011-04-08 which are related, AFAICS. Thanks! I guess ultimately what I'm keen to know is whether this was a problem that is pbzip2's fault (and did bugs get submitted to them) or a problem that was purely setup.exe's fault or some other category... This was definitely a bug in setup. The bug was that a bzip2 compressed file may contain multiple compressed streams, which should be decompressed and concatenated, but setup assumed that only a single stream would be present. Files compressed using pbzip2 usually contains multiple streams (The technique which pbzip uses to parallelize compression should be obvious :-)), whereas files compressed using bzip2 seem to only contain one stream, so no problem was noticed until attempting to use files compressed using pbzip2. Google seemed to indicate that this was a popular mistake to make in libbz2-using applications :-)
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 8/8/2011 10:13 AM, Jon TURNEY wrote: On 08/08/2011 17:46, Peter Li wrote: Thanks! I guess ultimately what I'm keen to know is whether this was a problem that is pbzip2's fault (and did bugs get submitted to them) or a problem that was purely setup.exe's fault or some other category... This was definitely a bug in setup. The bug was that a bzip2 compressed file may contain multiple compressed streams, which should be decompressed and concatenated, but setup assumed that only a single stream would be present. Files compressed using pbzip2 usually contains multiple streams (The technique which pbzip uses to parallelize compression should be obvious :-)), whereas files compressed using bzip2 seem to only contain one stream, so no problem was noticed until attempting to use files compressed using pbzip2. Google seemed to indicate that this was a popular mistake to make in libbz2-using applications :-) Ah, thanks much for the details. So essentially pbzip2 doesn't do anything wrong, yet it may still break things unexpectedly... :)
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 8/8/2011 12:46 PM, Peter Li wrote: As they distribute a windows binary with cygwin.dll, So, if the pbzip2 devs distribute a copy of cygwin1.dll, I assume they also abide by the GPL and distribute the sources for that copy of cygwin? -- Chuck
Re: [ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)
On 8/8/2011 4:23 PM, Charles Wilson wrote: On 8/8/2011 12:46 PM, Peter Li wrote: As they distribute a windows binary with cygwin.dll, So, if the pbzip2 devs distribute a copy of cygwin1.dll, I assume they also abide by the GPL and distribute the sources for that copy of cygwin? Huh, I seem to have invented this; they are not using cygwin1.dll after all. There are still plenty of such cases of course. I'm still willing to maintain the package.
