Re: [PATCH] Checking integrity of installed packages in cygcheck
On Sat, 9 Aug 2003, Charles Wilson wrote: Christopher Faylor wrote: I'll check this in but it would be nice if (WBNI) this used a mingw gzip library rather than calling gzip directly. That's a fair amount of work but I could resurrect the zlib library in winsup if necessary. Yes, I found the bzip2 library, but there was no zlib in the mingw subtree, and I wasn't in the mood to experiment with the makefile magic to make it work. I wonder why setup is using gzip rather than bzip2 for the package files... the setup tree contains its own copies of the zlib and bzlib trees; thue, they are compiled under the same runtime that setup is. If setup is a 'mingw' app, then so are the internal, statically linked libz and bz2lib. I imagine that the reason Igor used popen and zcat is simply that it was easier than directly interfacing to the library. Perhaps that issue could be addressed in a later patch (along the lines of the compress_gz class, which also provides uncompression capabilities?) Chuck That's exactly my plan. If there were a mingw zlib example somewhere in the code, I'd've used that, but I didn't want to venture into unknown territory without a guide. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED] |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! I have since come to realize that being between your mentor and his route to the bathroom is a major career booster. -- Patrick Naughton
Re: [PATCH] Checking integrity of installed packages in cygcheck
On Sat, Aug 09, 2003 at 12:29:39PM -0400, Christopher Faylor wrote: On Sat, Aug 09, 2003 at 12:12:11PM -0400, Christopher Faylor wrote: On Thu, Aug 07, 2003 at 06:50:10PM -0400, Igor Pechtchanski wrote: Hi, This patch adds most of the capability of the script from http://cygwin.com/ml/cygwin-apps/2003-08/msg00106.html to cygcheck. It is triggered by the -c flag to cygcheck. Integrity is a rather strong word, actually, as all this checks for is the existence of files and directories, but this could be further built upon (for example, tar has a diff option that could be useful). The patch is against cvs HEAD with my previous micropatch (http://cygwin.com/ml/cygwin-patches/2003-q3/msg00058.html) applied. Comments and suggestions welcome. I'm getting some odd errors when I apply this patch: 4NT: Unknown command f: (as you can see I use 4NT). I haven't had time to debug where these are coming from but I get one for every file displayed. The enclosed patch fixes that. I'll check this in but it would be nice if (WBNI) this used a mingw gzip library rather than calling gzip directly. That's a fair amount of work but I could resurrect the zlib library in winsup if necessary. I wonder why setup is using gzip rather than bzip2 for the package files... On checking this patch a little further, I see that it gives a misleading OK when the package file is missing. Could you detect that case? cgf
Re: [PATCH] stdint.h define of INT32_MIN
On Fri, Aug 08, 2003 at 01:37:51PM +0200, Gerrit P. Haase wrote: Hallo , Hello xyz.c:2: warning: this decimal constant is unsigned only in ISO C90 Both of the below patches are ok. for me to build perl and also there are no warnings issued, the first is the way it is defined on Linux too, the second seems to be alright according to the SUS specs: $ diff -udp stdint.h~ stdint.h --- stdint.h~ 2003-08-08 13:14:19.248036800 +0200 +++ stdint.h2003-08-08 13:14:36.452776000 +0200 @@ -70,7 +70,7 @@ typedef unsigned long long uintmax_t; #define INT8_MIN (-128) #define INT16_MIN (-32768) -#define INT32_MIN (-2147483648) +#define INT32_MIN (-2147483647-1) #define INT64_MIN (-9223372036854775808) #define INT8_MAX (127) # END I've applied the above patch. Thanks. cgf
