[PATCH] cygcheck: don't fail integrity check on empty package
Hi,
This patch fixes the erroneous failure of cygcheck -c when the package
is empty (and thus the file list for it is missing), e.g., XFree86-base.
Igor
==
ChangeLog:
2003-09-05 Igor Pechtchanski [EMAIL PROTECTED]
* dump_setup.cc (dump_setup): Don't fail on empty packages.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster. -- Patrick NaughtonIndex: winsup/utils/dump_setup.cc
===
RCS file: /cvs/src/src/winsup/utils/dump_setup.cc,v
retrieving revision 1.12
diff -u -p -r1.12 dump_setup.cc
--- winsup/utils/dump_setup.cc 17 Aug 2003 17:26:08 - 1.12
+++ winsup/utils/dump_setup.cc 6 Sep 2003 00:39:40 -
@@ -266,9 +266,8 @@ check_package_files (int verbose, char *
if (!fp)
{
if (verbose)
- printf (Can't open file list /etc/setup/%s.lst.gz for package %s\n,
-package, package);
- return false;
+ printf (Empty package %s\n, package);
+ return true;
}
bool result = true;
Re: [PATCH] cygcheck: don't fail integrity check on empty package
On Fri, 5 Sep 2003, Igor Pechtchanski wrote:
Hi,
This patch fixes the erroneous failure of cygcheck -c when the package
is empty (and thus the file list for it is missing), e.g., XFree86-base.
Igor
Sorry, I've messed up the ChangeLog entry. The correct one is included
below.
==
ChangeLog:
2003-09-05 Igor Pechtchanski [EMAIL PROTECTED]
* dump_setup.cc (check_package_files): Don't fail on empty package.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster. -- Patrick NaughtonIndex: winsup/utils/dump_setup.cc
===
RCS file: /cvs/src/src/winsup/utils/dump_setup.cc,v
retrieving revision 1.12
diff -u -p -r1.12 dump_setup.cc
--- winsup/utils/dump_setup.cc 17 Aug 2003 17:26:08 - 1.12
+++ winsup/utils/dump_setup.cc 6 Sep 2003 00:39:40 -
@@ -266,9 +266,8 @@ check_package_files (int verbose, char *
if (!fp)
{
if (verbose)
- printf (Can't open file list /etc/setup/%s.lst.gz for package %s\n,
-package, package);
- return false;
+ printf (Empty package %s\n, package);
+ return true;
}
bool result = true;
Re: [PATCH] cygcheck: don't fail integrity check on empty package
On Fri, Sep 05, 2003 at 08:53:54PM -0400, Igor Pechtchanski wrote: On Fri, 5 Sep 2003, Igor Pechtchanski wrote: This patch fixes the erroneous failure of cygcheck -c when the package is empty (and thus the file list for it is missing), e.g., XFree86-base. Sorry, I've messed up the ChangeLog entry. The correct one is included below. == ChangeLog: 2003-09-05 Igor Pechtchanski [EMAIL PROTECTED] * dump_setup.cc (check_package_files): Don't fail on empty package. I'll check this in but I wonder if the printfs here shouldn't be fprintf(stderr since they are sort of an error condition. cgf
Re: [PATCH] cygcheck: don't fail integrity check on empty package
On Fri, 5 Sep 2003, Christopher Faylor wrote: On Fri, Sep 05, 2003 at 08:53:54PM -0400, Igor Pechtchanski wrote: On Fri, 5 Sep 2003, Igor Pechtchanski wrote: This patch fixes the erroneous failure of cygcheck -c when the package is empty (and thus the file list for it is missing), e.g., XFree86-base. Sorry, I've messed up the ChangeLog entry. The correct one is included below. == ChangeLog: 2003-09-05 Igor Pechtchanski [EMAIL PROTECTED] * dump_setup.cc (check_package_files): Don't fail on empty package. I'll check this in but I wonder if the printfs here shouldn't be fprintf(stderr since they are sort of an error condition. cgf Perhaps, but they are only printed if verbose output is requested, so presumably the user wants to see them on stdout. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_[EMAIL PROTECTED] |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! I have since come to realize that being between your mentor and his route to the bathroom is a major career booster. -- Patrick Naughton
