Re: [PATCH v2 0/2] proc(5) man page
On Dec 1 09:49, Brian Inglis wrote: > On 2020-12-01 02:55, Corinna Vinschen wrote: > > On Nov 30 17:57, Brian Inglis wrote: > > > On 2020-11-30 03:47, Corinna Vinschen wrote: > > > > On Nov 24 23:49, Brian Inglis wrote: > > > > > Brian Inglis (2): > > > > > specialnames.xml: add proc(5) Cygwin man page > > > > > winsup/doc/Makefile.in: create man5 dir and install generated > > > > > proc.5 > > > > > > > > > >winsup/doc/Makefile.in |4 + > > > > >winsup/doc/specialnames.xml | 2094 > > > > > +++ > > > > >2 files changed, 2098 insertions(+) > > > > > > > It would be helpful if you could outline the changes from v1. > > > > > > Those were fairly minor fixes to content and some processing outlined in > > > the > > > (lengthy) responses to Jon's (lengthy) comments under: > > > https://sourceware.org/pipermail/cygwin-patches/2020q4/010829.html > > > > > > and I have copied them below, so please clarify if the below is not what > > > you want? > > > > I was after a short list with bullet points, ratehr than copying > > an email I have in my inbox anyway :} > > > > Jon, can you please take another look, too? > > * patches are sent directly from git send-email > * trailing whitespace only in Makefile.in context lines so left as is > * comment changed to "based on" Linux manpages project proc(5) > * dates retained to show how current content is, rather than when last built > * /proc/loadavg 'D' state mention removed > * /proc/registry Windows changed to Cygwin to clarify this variation > * /proc/version kernel changed to Cygwin > * Notes subsection missing title and Copyright subsection not included in > standalone man page due to Colophon subsection messing up man rendering > * removed Colophon subsection and Notes reappears properly and Copyright is > included; other system show these under Notes except RH uses Caveats > * retain remap attributes as Docbook rendering hints > > -- > Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada > > This email may be disturbing to some readers as it contains > too much technical detail. Reader discretion is advised. > [Data in binary units and prefixes, physical quantities in SI.] Thanks, pushed. Corinna
Re: [PATCH v2 0/2] proc(5) man page
On 2020-12-01 02:55, Corinna Vinschen wrote: On Nov 30 17:57, Brian Inglis wrote: On 2020-11-30 03:47, Corinna Vinschen wrote: On Nov 24 23:49, Brian Inglis wrote: Brian Inglis (2): specialnames.xml: add proc(5) Cygwin man page winsup/doc/Makefile.in: create man5 dir and install generated proc.5 winsup/doc/Makefile.in |4 + winsup/doc/specialnames.xml | 2094 +++ 2 files changed, 2098 insertions(+) It would be helpful if you could outline the changes from v1. Those were fairly minor fixes to content and some processing outlined in the (lengthy) responses to Jon's (lengthy) comments under: https://sourceware.org/pipermail/cygwin-patches/2020q4/010829.html and I have copied them below, so please clarify if the below is not what you want? I was after a short list with bullet points, ratehr than copying an email I have in my inbox anyway :} Jon, can you please take another look, too? * patches are sent directly from git send-email * trailing whitespace only in Makefile.in context lines so left as is * comment changed to "based on" Linux manpages project proc(5) * dates retained to show how current content is, rather than when last built * /proc/loadavg 'D' state mention removed * /proc/registry Windows changed to Cygwin to clarify this variation * /proc/version kernel changed to Cygwin * Notes subsection missing title and Copyright subsection not included in standalone man page due to Colophon subsection messing up man rendering * removed Colophon subsection and Notes reappears properly and Copyright is included; other system show these under Notes except RH uses Caveats * retain remap attributes as Docbook rendering hints -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.]
Re: [PATCH v2 0/2] proc(5) man page
On Nov 30 17:57, Brian Inglis wrote: > On 2020-11-30 03:47, Corinna Vinschen wrote: > > On Nov 24 23:49, Brian Inglis wrote: > > > Brian Inglis (2): > > >specialnames.xml: add proc(5) Cygwin man page > > >winsup/doc/Makefile.in: create man5 dir and install generated proc.5 > > > > > > winsup/doc/Makefile.in |4 + > > > winsup/doc/specialnames.xml | 2094 +++ > > > 2 files changed, 2098 insertions(+) > > > It would be helpful if you could outline the changes from v1. > > Those were fairly minor fixes to content and some processing outlined in the > (lengthy) responses to Jon's (lengthy) comments under: > https://sourceware.org/pipermail/cygwin-patches/2020q4/010829.html > > and I have copied them below, so please clarify if the below is not what you > want? I was after a short list with bullet points, ratehr than copying an email I have in my inbox anyway :} Jon, can you please take another look, too? Thanks, Corinna
Re: [PATCH v2 0/2] proc(5) man page
On 2020-11-30 03:47, Corinna Vinschen wrote: On Nov 24 23:49, Brian Inglis wrote: Brian Inglis (2): specialnames.xml: add proc(5) Cygwin man page winsup/doc/Makefile.in: create man5 dir and install generated proc.5 winsup/doc/Makefile.in |4 + winsup/doc/specialnames.xml | 2094 +++ 2 files changed, 2098 insertions(+) It would be helpful if you could outline the changes from v1. Those were fairly minor fixes to content and some processing outlined in the (lengthy) responses to Jon's (lengthy) comments under: https://sourceware.org/pipermail/cygwin-patches/2020q4/010829.html and I have copied them below, so please clarify if the below is not what you want? I'm not sure how you generated this email. But sending the patch inline (using 'git-send-email'?), rather than as an attachment makes it a lot easier to make review comments inline. It's right from git send-email which creates the MIME sections in the patches: " ... X-Mailer: git-send-email 2.29.2 ... This is a multi-part message in MIME format. --2.29.2 Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit --- winsup/doc/specialnames.xml | 2100 +++ 1 file changed, 2100 insertions(+) --2.29.2 Content-Type: text/x-patch; name="0001-specialnames.xml-add-proc-5-Cygwin-man- page.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="0001-specialnames.xml-add-proc-5-Cygwin-man-page.patch" ..." so it may be down to how your MUA displays those, and we are running the same release of TB, which on mine shows the patch "inline" after a filename separator like any other text attachment. Ctrl-U displays email source including headers; search for 'User-Agent:' or 'Mailer:' in headers. > A few lines have trailing whitespace, which should be removed. Not in the patched lines, which appear in *RED* in git diff, and I just rechecked that they are in context lines, so I left them alone for separate cleanup, as I have been chastised on previous occasions. ;^> >> diff --git a/winsup/doc/specialnames.xml b/winsup/doc/specialnames.xml >> index a1f7401e16b9..6b86187f39e9 100644 >> --- a/winsup/doc/specialnames.xml >> +++ b/winsup/doc/specialnames.xml >> @@ -486,6 +486,2106 @@ one in Linux, but it provides significant capabilities. The >> procps package contains several utilities >> that use it. >> >> + >> +
Re: [PATCH v2 0/2] proc(5) man page
Hi Brian, On Nov 24 23:49, Brian Inglis wrote: > Brian Inglis (2): > specialnames.xml: add proc(5) Cygwin man page > winsup/doc/Makefile.in: create man5 dir and install generated proc.5 > > winsup/doc/Makefile.in |4 + > winsup/doc/specialnames.xml | 2094 +++ > 2 files changed, 2098 insertions(+) > > -- > 2.29.2 It would be helpful if you could outline the changes from v1. Thanks, Corinna
