Re: [PATCH] Add -p option to ps command
Hi Jerry, On Feb 16 07:58, Jerry D. Hedden wrote: On Feb 14 07:12, Jerry D. Hedden wrote: Attached is a patch to add a -p option to the ps command to show information for only a single PID: ps -p PID Corrina Vinschen replied: Thanks for the patch. It's barely short enough so that we decided to put it in despite the fact that you have no copyright assignment in place. I will send one in today. your copyright assignment arrived and is signed. So, no worries about that anymore for further patches :-) Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
Re: [PATCH] Add -p option to ps command
On Feb 16 10:46, Jerry D. Hedden wrote: Original Message Subject: Re: [PATCH] Add -p option to ps command From: Corinna Vinschen [EMAIL PROTECTED]) Would you please don't copy raw email addresses in your replies? http://cygwin.com/acronyms/#PCYMTNQREAIYR 2006-02-16 Jerry D. Hedden [EMAIL PROTECTED] * ps.cc (main): -p implies -a I've applied the patch, but your ChangeLog entry is a bit short. I've changed it to Set aflag if -p option is given. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
Re: [PATCH] Add -p option to ps command
On Feb 14 07:12, Jerry D. Hedden wrote: Attached is a patch to add a -p option to the ps command to show information for only a single PID: ps -p PID This option is available on other implementations of ps (e.g., Solaris). Thanks for the patch. It's barely short enough so that we decided to put it in despite the fact that you have no copyright assignment in place. Please read http://cygwin.com/contrib.html for further information about how to contribute. Note especially the fact that we need your copyright assignment for any substantial patch. I applied your patch with some minor changes. I fixed the wrongly set curly braces at one point, I added the descriptive text to utils.sgml (cygwin-ug-net.sgml is only a generated file) and, most important, I added a ChangeLog entry. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
RE: [PATCH] Add -p option to ps command
On Feb 14 07:12, Jerry D. Hedden wrote: Attached is a patch to add a -p option to the ps command to show information for only a single PID: ps -p PID Corrina Vinschen replied: Thanks for the patch. It's barely short enough so that we decided to put it in despite the fact that you have no copyright assignment in place. I will send one in today. I applied your patch with some minor changes. Thanks. I realized one minor oversight. Using -p should imply -a so that even if the PID is not owned by the current user, it will still get listed. I've attached a patch for this (just a one line addition) that builds on top of the previous patch (i.e., apply it against version 1.20 of ps.cc). Thanks again. Index: src/winsup/utils/ps.cc === --- ps.cc 1.20 +++ ps.cc @@ -286,6 +286,7 @@ break; case 'p': proc_id = atoi (optarg); + aflag = 1; break; case 's': sflag = 1;
Re: [PATCH] Add -p option to ps command
On Feb 16 07:58, Jerry D. Hedden wrote: Thanks. I realized one minor oversight. Using -p should imply -a so that even if the PID is not owned by the current user, it will still get listed. I've attached a patch for this (just a one line addition) that builds on top of the previous patch (i.e., apply it against version 1.20 of ps.cc). Thanks again. Index: src/winsup/utils/ps.cc === --- ps.cc 1.20 +++ ps.cc @@ -286,6 +286,7 @@ break; case 'p': proc_id = atoi (optarg); + aflag = 1; break; case 's': sflag = 1; What about the ChangeLog entry? http://cygwin.com/contrib.html Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat
RE: [PATCH] Add -p option to ps command
Original Message Subject: Re: [PATCH] Add -p option to ps command From: Corinna Vinschen [EMAIL PROTECTED] Date: Thu, February 16, 2006 10:09 am To: cygwin-patches@cygwin.com On Feb 16 07:58, Jerry D. Hedden wrote: Thanks. I realized one minor oversight. Using -p should imply -a so that even if the PID is not owned by the current user, it will still get listed. I've attached a patch for this (just a one line addition) that builds on top of the previous patch (i.e., apply it against version 1.20 of ps.cc). Thanks again. Index: src/winsup/utils/ps.cc === --- ps.cc 1.20 +++ ps.cc @@ -286,6 +286,7 @@ break; case 'p': proc_id = atoi (optarg); + aflag = 1; break; case 's': sflag = 1; What about the ChangeLog entry? http://cygwin.com/contrib.html I'll get this right one of these days. Thanks for your patience. Changelog entry: 2006-02-16 Jerry D. Hedden [EMAIL PROTECTED] * ps.cc (main): -p implies -a
