Re: [PATCH] Cygwin: pty: Reduce buffer size in get_console_process_id().
On Jan 20 19:40, Takashi Yano via Cygwin-patches wrote: > On Wed, 20 Jan 2021 10:50:24 +0100 > Corinna Vinschen wrote: > > On Jan 20 09:57, Takashi Yano via Cygwin-patches wrote: > > > - The buffer used in get_console_process_id(), introduced by commit > > > 72770148, is too large and ERROR_NOT_ENOUGH_MEMORY occurs in Win7. > > > > Huh, funny! Will we ever be happy with just 8192 processes per > > console? :) > > According to my test, when the buffer size is larger than 15683, > this error occurs. Test environment is Win7 x64. Both inside and > outside of WOW64, the maximum allowed size seems to be the same. > > Shall we increase to 15683? :p Ugh, please, no :D 8K processes per console is fine. The machine will probably be out of memory before this is a concern. Corinna
Re: [PATCH] Cygwin: pty: Reduce buffer size in get_console_process_id().
On Wed, 20 Jan 2021 10:50:24 +0100 Corinna Vinschen wrote: > On Jan 20 09:57, Takashi Yano via Cygwin-patches wrote: > > - The buffer used in get_console_process_id(), introduced by commit > > 72770148, is too large and ERROR_NOT_ENOUGH_MEMORY occurs in Win7. > > Huh, funny! Will we ever be happy with just 8192 processes per > console? :) According to my test, when the buffer size is larger than 15683, this error occurs. Test environment is Win7 x64. Both inside and outside of WOW64, the maximum allowed size seems to be the same. Shall we increase to 15683? :p -- Takashi Yano
Re: [PATCH] Cygwin: pty: Reduce buffer size in get_console_process_id().
On Jan 20 09:57, Takashi Yano via Cygwin-patches wrote: > - The buffer used in get_console_process_id(), introduced by commit > 72770148, is too large and ERROR_NOT_ENOUGH_MEMORY occurs in Win7. Huh, funny! Will we ever be happy with just 8192 processes per console? :) > Therefore, the buffer size has been reduced. > --- > winsup/cygwin/fhandler_tty.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Pushed. THanks, Corinna
