Re: [PATCH] [v5] quote arguments in xtrace output

[Herbert Xu]

Martijn Dekker  wrote:
> 
> The xtrace (set -x) output in dash is a bit of a pain, because arguments
> containing whitespace aren't quoted. This can it impossible to tell
> which bit belongs to which argument:

Sorry, but one of the key goals of dash is to be as small as
possible.  So that means no features unless absolutely necessary.

As such I cannot accept this patch as it is.

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [v5] quote arguments in xtrace output

[Martijn Dekker]

Op 19-04-18 om 12:14 schreef Herbert Xu:

Sorry, but one of the key goals of dash is to be as small as
possible.  So that means no features unless absolutely necessary.

As such I cannot accept this patch as it is.


Would you accept it if it were a configure option, disabled by default 
(like linking with libedit)?


- Martijn

--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Add subdir-objects to AM_INIT_AUTOMAKE

[Herbert Xu]

Jason Bowen  wrote:
> [-- text/plain, encoding 7bit, charset: UTF-8, 10 lines --]
> 
> I've attached a patch which adds the subdir-objects option to 
> AM_INIT_AUTOMAKE.
> 
> For a while now when I've compiled dash I received a warning from
> automake that there are source files in a subdirectory but that the
> subdir-objects automake option was not supplied. I've just been adding
> it myself, but I finally got around to submitting a patch. The code
> still compiles for now (i'm using automake 1.15.1), but warning text
> is rarely nice to see and, if the warning text is to be believed, then
> the warning will eventually become an error.

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] expand: remove unnecessary code in backquote expansion

[Ron Yorston]

Herbert Xu  wrote:
>Unfortunately we may need this at some point in the future due
>to changes in POSIX.  So let's keep it around for now until we
>get things such as `jobs -p` to work.

As you wish.

Something even more trivial I noticed later:  the TRACE at the end of
expbackq incorrectly refers to the function as evalbackq.

Ron
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: dash bug

[sylvain . bertrand]

On Thu, Apr 19, 2018 at 06:22:19PM +0800, Herbert Xu wrote:
> sylvain.bertr...@gmail.com wrote:
> > Hi, 
> > 
> > after commit:ab1cecb4047864afb247a6ed691e7f59ce716f2c
> > the following script snippet won't work anymore (extracted from libtool)
> > 
> > test.sh:
> > ---
> > #!/bin/sh
> > 
> > : ${SHELL="${CONFIG_SHELL-/bin/sh}"}
> > ---
> > 
> > dash will output the following error:
> > ./test.sh: Syntax error: Unterminated quoted string
> 
> Sorry, I was a bit slack in pushing out the pending patches.  It
> should be fixed in the git tree now.

Thx!

-- 
Sylvain
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html