Re: DateTime::Spanset doc typo on cpan

2016-05-17 Thread Flavio S. Glock
DateTime::Set 0.37 in CPAN has a more consistent API:
- max() and end() are exactly the same;
- min() and start() are exactly the same;
- docs and tests are updated

2016-05-17 10:14 GMT+02:00 Flavio S. Glock :
> min() and start(), and max() and end() do exactly the same thing.
>
> DateTime::SpanSet has it right (implemented and documented).
>
> DateTime::Span has it implemented, but not documented (the example should 
> work).
>
> DateTime::Set has min() and max(), but start() and end() are not implemented.
>
> The docs are also inconsistent, this needs a review:
>
> "It is also possible that these methods may return a
> scalar containing infinity or negative infinity."
>
> "It is also possible that these methods
> may return a C or
> C object."
>
>
>
> 2016-05-17 9:42 GMT+02:00 Vincent Berger :
>> Hi,
>> thanks for your package !
>>
>> according to spanset doc on span
>> http://search.cpan.org/~fglock/DateTime-Set-0.3600/lib/DateTime/SpanSet.pm
>> iterator section
>>
>> $iter = $spanset->iterator;
>> while ( $dt = $iter->next ) {
>> # $dt is a DateTime::Span
>> print $dt->min->ymd;   # first date of span
>> print $dt->max->ymd;   # last date of span
>> }
>>
>>
>> but max and min are not Span functions
>>
>> you mean
>> print $dt->start->ymd
>> print $dt->end->ymd;
>> isn't it ?
>>
>> have a good day
>> Vincent
>>


Re: DateTime::Spanset doc typo on cpan

2016-05-17 Thread Flavio S. Glock
min() and start(), and max() and end() do exactly the same thing.

DateTime::SpanSet has it right (implemented and documented).

DateTime::Span has it implemented, but not documented (the example should work).

DateTime::Set has min() and max(), but start() and end() are not implemented.

The docs are also inconsistent, this needs a review:

"It is also possible that these methods may return a
scalar containing infinity or negative infinity."

"It is also possible that these methods
may return a C or
C object."



2016-05-17 9:42 GMT+02:00 Vincent Berger :
> Hi,
> thanks for your package !
>
> according to spanset doc on span
> http://search.cpan.org/~fglock/DateTime-Set-0.3600/lib/DateTime/SpanSet.pm
> iterator section
>
> $iter = $spanset->iterator;
> while ( $dt = $iter->next ) {
> # $dt is a DateTime::Span
> print $dt->min->ymd;   # first date of span
> print $dt->max->ymd;   # last date of span
> }
>
>
> but max and min are not Span functions
>
> you mean
> print $dt->start->ymd
> print $dt->end->ymd;
> isn't it ?
>
> have a good day
> Vincent
>