Re: [Dbix-class] Re: DBIx::Class::Helper::ResultSet::Random and Oracle

2013-01-10 Thread fREW Schmidt
Thanks fellas, patch has been merged and released.

On Wed, Dec 19, 2012 at 01:00:36AM -0800, José Diaz Seng wrote:
 Peter Rabbitson-2 wrote
  This is an implementation bug (and yes, he does say it is ghetto in a
  comment). The code needs to do an -isa check against all available
  keys, starting with longest class first (i.e. try DBI::ODBC::X before
  DBI::X). Could you help the author by submitting a patch to that effect?

 I will be happy to submit a patch then.

--
fREW Schmidt
http://blog.afoolishmanifesto.com


pgp8_4H_EYv7N.pgp
Description: PGP signature
___
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk

[Dbix-class] Re: DBIx::Class::Helper::ResultSet::Random and Oracle

2012-12-19 Thread José Diaz Seng
Peter Rabbitson-2 wrote
 This is an implementation bug (and yes, he does say it is ghetto in a 
 comment). The code needs to do an -isa check against all available 
 keys, starting with longest class first (i.e. try DBI::ODBC::X before 
 DBI::X). Could you help the author by submitting a patch to that effect?

I will be happy to submit a patch then.




--
View this message in context: 
http://dbix-class.35028.n2.nabble.com/DBIx-Class-Helper-ResultSet-Random-and-Oracle-tp7577877p7577880.html
Sent from the DBIx-Class mailing list archive at Nabble.com.

___
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk


[Dbix-class] Re: DBIx::Class::Helper::ResultSet::Random and Oracle

2012-12-19 Thread José Diaz Seng
I have just submitted the patch to rt.cpan.org.



--
View this message in context: 
http://dbix-class.35028.n2.nabble.com/DBIx-Class-Helper-ResultSet-Random-and-Oracle-tp7577877p7577881.html
Sent from the DBIx-Class mailing list archive at Nabble.com.

___
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk