Re: [PATCH 1/1][TFRC]: Hide tx history details from the CCIDs

2007-11-30 Thread Herbert Xu 
On Thu, Nov 29, 2007 at 11:58:12PM -0200, Arnaldo Carvalho de Melo wrote:
 
   Please consider pulling from:
 
   master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25

Pulled.  Thanks Arnaldo!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC]: tfrc_tx_hist_rtt

2007-11-30 Thread Arnaldo Carvalho de Melo 
Em Fri, Nov 30, 2007 at 12:19:36PM +, Gerrit Renker escreveu:
 Sorry I only got this email today and it is a busy day, too.
 
 The changes look good and are in general a further improvement on the
 code. I like the idea of hiding the internals of the list structure in 
 the source file.
 
 I wonder if one could go one step further and also take the timestamp
 directly when looking up the previous history sample, e.g.
 
   u32 tfrc_tx_hist_rtt(struct tfrc_tx_hist_entry *head, const u64 seqno)
   {
   u32 rtt = 0;
   struct tfrc_tx_hist_entry *packet = 
 tfrc_tx_hist_find_entry(head, seqno);
   
   if (packet != NULL) {
   rtt = ktime_us_delta(ktime_get_real(), packet-stamp);
   /*
* Garbage-collect older (irrelevant) entries:
*/
   tfrc_tx_hist_purge(packet-next);
   }
   
   return rtt;
   }
 
 Just a suggestion.

I thought about that, but ccid3_hc_tx_packet_recv needs a timestamp some
lines below, when we reuse the ktime_get_real call.

- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC]: tfrc_tx_hist_rtt

2007-11-30 Thread Gerrit Renker 
Sorry I only got this email today and it is a busy day, too.

The changes look good and are in general a further improvement on the
code. I like the idea of hiding the internals of the list structure in 
the source file.

I wonder if one could go one step further and also take the timestamp
directly when looking up the previous history sample, e.g.

u32 tfrc_tx_hist_rtt(struct tfrc_tx_hist_entry *head, const u64 seqno)
{
u32 rtt = 0;
struct tfrc_tx_hist_entry *packet = 
tfrc_tx_hist_find_entry(head, seqno);

if (packet != NULL) {
rtt = ktime_us_delta(ktime_get_real(), packet-stamp);
/*
 * Garbage-collect older (irrelevant) entries:
 */
tfrc_tx_hist_purge(packet-next);
}

return rtt;
}

Just a suggestion.

Thanks for looking through this.
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC]: tfrc_tx_hist_rtt

2007-11-30 Thread Gerrit Renker 
|  I wonder if one could go one step further and also take the timestamp
|  directly when looking up the previous history sample, e.g.
|  
snip
| 
| I thought about that, but ccid3_hc_tx_packet_recv needs a timestamp some
| lines below, when we reuse the ktime_get_real call.
| 
Oh, of course - that was real stupid of me. I think it is even in two occasions 
where a 
timestamp is needed, below in the same function.

I am really hoping that some time there is a robust RFC1323-like algorithm,
this could solve all the RTT sampling for both CCID2 and CCID3 (also CCID4),
and then there would be a RTT available in the main module (e.g. for better
estimating the Close/CloseReq retransmission timeout).


-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html