[PATCH 3/8] [TFRC/CCID3]: Remove now unused functions / function calls

2007-12-08 Thread Gerrit Renker
This removes two things which now have become redundant:
 1. The function tfrc_rx_hist_entry_delete() is no longer referenced anywhere.
 2. The CCID3 HC-receiver still inserted timestamps, but received timestamps
are not parsed/referenced/used by the HC-sender, it serves no function.

Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
---
 net/dccp/ccids/ccid3.c  |3 +--
 net/dccp/ccids/lib/packet_history.c |5 -
 2 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index a5246f7..60fcb31 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -750,8 +750,7 @@ static int ccid3_hc_rx_insert_options(struct sock *sk, 
struct sk_buff *skb)
x_recv = htonl(hcrx-ccid3hcrx_x_recv);
pinv   = htonl(hcrx-ccid3hcrx_pinv);
 
-   if (dccp_insert_option_timestamp(sk, skb) ||
-   dccp_insert_option(sk, skb, TFRC_OPT_LOSS_EVENT_RATE,
+   if (dccp_insert_option(sk, skb, TFRC_OPT_LOSS_EVENT_RATE,
   pinv, sizeof(pinv)) ||
dccp_insert_option(sk, skb, TFRC_OPT_RECEIVE_RATE,
   x_recv, sizeof(x_recv)))
diff --git a/net/dccp/ccids/lib/packet_history.c 
b/net/dccp/ccids/lib/packet_history.c
index af0db71..4d37396 100644
--- a/net/dccp/ccids/lib/packet_history.c
+++ b/net/dccp/ccids/lib/packet_history.c
@@ -183,11 +183,6 @@ void tfrc_rx_hist_add_packet(struct tfrc_rx_hist *h,
 }
 EXPORT_SYMBOL_GPL(tfrc_rx_hist_add_packet);
 
-static inline void tfrc_rx_hist_entry_delete(struct tfrc_rx_hist_entry *entry)
-{
-   kmem_cache_free(tfrc_rx_hist_slab, entry);
-}
-
 /**
  * tfrc_rx_hist_entry - return the n-th history entry after loss_start
  */
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/8] [TFRC/CCID3]: Remove now unused functions / function calls

2007-12-08 Thread Arnaldo Carvalho de Melo
Em Sat, Dec 08, 2007 at 10:06:23AM +, Gerrit Renker escreveu:
 This removes two things which now have become redundant:
  1. The function tfrc_rx_hist_entry_delete() is no longer referenced anywhere.
  2. The CCID3 HC-receiver still inserted timestamps, but received timestamps
 are not parsed/referenced/used by the HC-sender, it serves no function.
 
 Signed-off-by: Gerrit Renker [EMAIL PROTECTED]

Thanks, applying as two separate patches.

- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html