Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Hello, Alex ARNAUD, on mer. 15 mars 2017 11:19:43 +0100, wrote: > Le 14/03/2017 à 22:52, Samuel Thibault a écrit : > > Testers: Ping? > > I would like to test but I'm using Debian 8.7 Jessie. I should build a > version for Jessie to be able to test. I have uploaded one to deb http://people.debian.org/~sthibault/tmp/ ./ To include my gpg key to apt: gpg --search-key 900CB024B67931D40F82304BD0178C767D069EE6 gpg --export 900CB024B67931D40F82304BD0178C767D069EE6 | sudo apt-key add - Samuel
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 14/03/2017 à 22:52, Samuel Thibault a écrit : Hello, Testers: Ping? I would like to test but I'm using Debian 8.7 Jessie. I should build a version for Jessie to be able to test. Best regards. -- Alex ARNAUD
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Hi Samuel Thibault schrieb am 14.03.2017, 22:52 +0100: >Testers: Ping? I had a similar issue, but didn't experience it for quite a while now. I just tried it a few times with given package and so no problem with it. Thanks Sebastian signature.asc Description: PGP signature
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Hello, Testers: Ping? Thibaut Paumard, on sam. 04 mars 2017 09:11:56 +0100, wrote: > I've uploaded the patched firefox-esr, built on stretch, here: > https://people.debian.org/~thibaut/firefox-esr/ > > All the .deb are there. The main package is at: > https://people.debian.org/~thibaut/firefox-esr/firefox-esr_45.7.0esr-4+a11y1_amd64.deb > > This is not a repository, you'll need to download the individual > packages manually and install them e.g. with > > sudo gdebi firefox-esr_45.7.0esr-4+a11y1_amd64.deb > > It would be great if some affected user could try this package and see > whether this fixes it for them. Samuel
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 02/03/2017 à 11:26, Thibaut Paumard a écrit : > I attach a corrected patch that does apply cleanly. I am currently > building the package under stretch and will upload it to some public > space when done. > Hi, I've uploaded the patched firefox-esr, built on stretch, here: https://people.debian.org/~thibaut/firefox-esr/ All the .deb are there. The main package is at: https://people.debian.org/~thibaut/firefox-esr/firefox-esr_45.7.0esr-4+a11y1_amd64.deb This is not a repository, you'll need to download the individual packages manually and install them e.g. with sudo gdebi firefox-esr_45.7.0esr-4+a11y1_amd64.deb It wpuld be great if some affected user could try this package and see whether this fixes it for them. Regards, Thibaut.
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 01/03/2017 à 23:54, Mike Hommey a écrit :
> Thanks. This points to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1273020
>
> which points to
> https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a
>
> Can someone try to apply this patch and see how it goes for them?
Hi,
This patch does not apply cleanly on firefox-esr (45.7.0esr-4).
I attach a corrected patch that does apply cleanly. I am currently
building the package under stretch and will upload it to some public
space when done.
I won't be able to test though, as I can't reproduce the crash.
Regards, Thibaut.
diff --git a/accessible/generic/ApplicationAccessible.h b/accessible/generic/ApplicationAccessible.h
--- a/accessible/generic/ApplicationAccessible.h
+++ b/accessible/generic/ApplicationAccessible.h
@@ -55,39 +55,45 @@ public:
virtual void InvalidateChildren() override;
// ActionAccessible
virtual KeyBinding AccessKey() const override;
// ApplicationAccessible
void AppName(nsAString& aName) const
{
-nsAutoCString cname;
-mAppInfo->GetName(cname);
-AppendUTF8toUTF16(cname, aName);
+if (mAppInfo) {
+ nsAutoCString cname;
+ mAppInfo->GetName(cname);
+ AppendUTF8toUTF16(cname, aName);
+}
}
void AppVersion(nsAString& aVersion) const
{
-nsAutoCString cversion;
-mAppInfo->GetVersion(cversion);
-AppendUTF8toUTF16(cversion, aVersion);
+if (mAppInfo) {
+ nsAutoCString cversion;
+ mAppInfo->GetVersion(cversion);
+ AppendUTF8toUTF16(cversion, aVersion);
+}
}
void PlatformName(nsAString& aName) const
{
aName.AssignLiteral("Gecko");
}
void PlatformVersion(nsAString& aVersion) const
{
-nsAutoCString cversion;
-mAppInfo->GetPlatformVersion(cversion);
-AppendUTF8toUTF16(cversion, aVersion);
+if (mAppInfo) {
+ nsAutoCString cversion;
+ mAppInfo->GetPlatformVersion(cversion);
+ AppendUTF8toUTF16(cversion, aVersion);
+}
}
protected:
virtual ~ApplicationAccessible() {}
// Accessible
virtual void CacheChildren() override;
virtual Accessible* GetSiblingAtOffset(int32_t aOffset,
nsresult *aError = nullptr) const override;
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Hi, Frankly I don't understand anything in Mozilla bugzilla. Could you please give me a link to the patch, so that I try building firefox-esr again? Or a link to a built package? Many thanks Regards, Le 02/03/2017 à 00:32, Mike Hommey a écrit : > On Thu, Mar 02, 2017 at 12:14:50AM +0100, Alex ARNAUD wrote: >> Le 01/03/2017 à 23:54, Mike Hommey a écrit : >>> Thanks. This points to >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 >>> >>> which points to >>> https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a >> >> Thanks a lot for pointing me these links, I've commented the upstream bug. >> >>> Can someone try to apply this patch and see how it goes for them? >> >> Do you plan to integrate the patch into the Debian package? > > If they fix the issue (which they likely do), yes. But there's a > chicken-and-egg problem here. > >> If yes, could >> you tell me what is the procedure to test and build a Firefox ESR with the >> patch? > > Take the firefox-esr source, apply the patch, and build a new package > with dpkg-buildpackage -b. That's all there is to do. > > Mike > > -- Jean-Philippe MENGUAL HYPRA, progressons ensemble Tél.: 01 84 73 06 61 Mail: cont...@hypra.fr Site Web: http://hypra.fr
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Oh sorry, thanks. I understand better why I didn't understand what I read. I'll try to download it. Regards, Le 02/03/2017 à 01:30, Mike Hommey a écrit : > On Thu, Mar 02, 2017 at 01:13:48AM +0100, MENGUAL Jean-Philippe wrote: >> Hi, >> >> Frankly I don't understand anything in Mozilla bugzilla. Could you >> please give me a link to the patch, so that I try building firefox-esr >> again? Or a link to a built package? > > The second link is the patch. > > Mike > > >> Le 02/03/2017 à 00:32, Mike Hommey a écrit : >>> On Thu, Mar 02, 2017 at 12:14:50AM +0100, Alex ARNAUD wrote: Le 01/03/2017 à 23:54, Mike Hommey a écrit : > Thanks. This points to > https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 > > which points to > https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a Thanks a lot for pointing me these links, I've commented the upstream bug. > Can someone try to apply this patch and see how it goes for them? Do you plan to integrate the patch into the Debian package? >>> >>> If they fix the issue (which they likely do), yes. But there's a >>> chicken-and-egg problem here. >>> If yes, could you tell me what is the procedure to test and build a Firefox ESR with the patch? >>> >>> Take the firefox-esr source, apply the patch, and build a new package >>> with dpkg-buildpackage -b. That's all there is to do. >>> >>> Mike >>> >>> >> >> -- >> >> Jean-Philippe MENGUAL >> >> HYPRA, progressons ensemble >> >> Tél.: 01 84 73 06 61 >> Mail: cont...@hypra.fr >> >> Site Web: http://hypra.fr >> >> ___ >> pkg-mozilla-maintainers mailing list >> pkg-mozilla-maintain...@lists.alioth.debian.org >> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozilla-maintainers > -- Jean-Philippe MENGUAL HYPRA, progressons ensemble Tél.: 01 84 73 06 61 Mail: cont...@hypra.fr Site Web: http://hypra.fr
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
On Thu, Mar 02, 2017 at 01:13:48AM +0100, MENGUAL Jean-Philippe wrote: > Hi, > > Frankly I don't understand anything in Mozilla bugzilla. Could you > please give me a link to the patch, so that I try building firefox-esr > again? Or a link to a built package? The second link is the patch. Mike > Le 02/03/2017 à 00:32, Mike Hommey a écrit : > > On Thu, Mar 02, 2017 at 12:14:50AM +0100, Alex ARNAUD wrote: > >> Le 01/03/2017 à 23:54, Mike Hommey a écrit : > >>> Thanks. This points to > >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 > >>> > >>> which points to > >>> https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a > >> > >> Thanks a lot for pointing me these links, I've commented the upstream bug. > >> > >>> Can someone try to apply this patch and see how it goes for them? > >> > >> Do you plan to integrate the patch into the Debian package? > > > > If they fix the issue (which they likely do), yes. But there's a > > chicken-and-egg problem here. > > > >> If yes, could > >> you tell me what is the procedure to test and build a Firefox ESR with the > >> patch? > > > > Take the firefox-esr source, apply the patch, and build a new package > > with dpkg-buildpackage -b. That's all there is to do. > > > > Mike > > > > > > -- > > Jean-Philippe MENGUAL > > HYPRA, progressons ensemble > > Tél.: 01 84 73 06 61 > Mail: cont...@hypra.fr > > Site Web: http://hypra.fr > > ___ > pkg-mozilla-maintainers mailing list > pkg-mozilla-maintain...@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozilla-maintainers
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
On Thu, Mar 02, 2017 at 12:14:50AM +0100, Alex ARNAUD wrote: > Le 01/03/2017 à 23:54, Mike Hommey a écrit : > > Thanks. This points to > > https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 > > > > which points to > > https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a > > Thanks a lot for pointing me these links, I've commented the upstream bug. > > > Can someone try to apply this patch and see how it goes for them? > > Do you plan to integrate the patch into the Debian package? If they fix the issue (which they likely do), yes. But there's a chicken-and-egg problem here. > If yes, could > you tell me what is the procedure to test and build a Firefox ESR with the > patch? Take the firefox-esr source, apply the patch, and build a new package with dpkg-buildpackage -b. That's all there is to do. Mike
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 01/03/2017 à 23:54, Mike Hommey a écrit : Thanks. This points to https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 which points to https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a Thanks a lot for pointing me these links, I've commented the upstream bug. Can someone try to apply this patch and see how it goes for them? Do you plan to integrate the patch into the Debian package? If yes, could you tell me what is the procedure to test and build a Firefox ESR with the patch? Best regards and thank you very much for your help. -- Alex ARNAUD Visual-Impairment Project Manager Hypra - "Humanizing technology"
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
On Wed, Mar 01, 2017 at 11:22:54PM +0100, Alex ARNAUD wrote: > Le 01/03/2017 à 23:04, Mike Hommey a écrit : > > Has anyone submitted such a crash report and if so, can they give the > > crash id? (look in about:crashes) > > Dear Mike, > > Yes, I've submitted crashes reports. You could find the last two reports > here : > - > https://crash-stats.mozilla.com/report/index/cf1f9951-c735-4b4a-a85c-3c7892170228 > - > https://crash-stats.mozilla.com/report/index/60bda391-530d-445c-8df3-bcc4c2170220 Thanks. This points to https://bugzilla.mozilla.org/show_bug.cgi?id=1273020 which points to https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a Can someone try to apply this patch and see how it goes for them? Mike
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
On Wed, Mar 01, 2017 at 03:10:13PM +0100, Thibaut Paumard wrote: > Dear Firefox maintainers, > > We have several users confirming this bug: > https://lists.debian.org/debian-accessibility/2017/02/msg00062.html > > More precisely and although I have not been able to reproduce it, it > appears that for those users, firefox-esr crashes upon exit when the > orca screen reader is running. > > The symptom that firefox crashes is the crash report window popping-up. > > The original bug reporter also mentioned in the thread above that he is > using orca as well. Has anyone submitted such a crash report and if so, can they give the crash id? (look in about:crashes) Mike
Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 01/03/2017 à 23:04, Mike Hommey a écrit : Has anyone submitted such a crash report and if so, can they give the crash id? (look in about:crashes) Dear Mike, Yes, I've submitted crashes reports. You could find the last two reports here : - https://crash-stats.mozilla.com/report/index/cf1f9951-c735-4b4a-a85c-3c7892170228 - https://crash-stats.mozilla.com/report/index/60bda391-530d-445c-8df3-bcc4c2170220 Best regards. -- Alex ARNAUD Visual-Impairment Project Manager Hypra - "Humanizing technology"
