Bug#686502: pxz produces archives broken for busybox's unxz

2012-12-24 Thread Abou Al Montacir
On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
 What happens if a stream ends at a buffer boundary, followed by
 padding?  Or if padding doesn't fit in the buffer, for that
 matter?
That make very low probability but could happe indeed. I will upload a
new patch which fixes this case too.

Thank you for your review.

Cheers,


signature.asc
Description: This is a digitally signed message part


Bug#696521: marked as done (Bépo keyboard layout missing in Debian installer)

2012-12-24 Thread Anton Zinoviev
On Sat, Dec 22, 2012 at 10:36:03AM +, Debian Bug Tracking System wrote:
 
 The set of keymaps that are offerred at installation is limited on
 purpose (size and memory constraints as well as avoiding too many
 options that are confusing for users).

Just a little clarification.  The memory constraints are more or less 
irrelevant here because even with all supported by XKB keyboard layouts, 
variants and options the required additional memory space is very small. 
The only important thing here is not to confuse the users with too many 
options.

Anton Zinoviev


-- 
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121224115000.ga10...@debian.lan



Re: Bug#696521: marked as done (Bépo keyboard layout missing in Debian installer)

2012-12-24 Thread Samuel Thibault
Anton Zinoviev, le Mon 24 Dec 2012 13:50:00 +0200, a écrit :
 Just a little clarification.  The memory constraints are more or less 
 irrelevant here because even with all supported by XKB keyboard layouts, 
 variants and options the required additional memory space is very small. 

Memory also includes the initrd room for storing them, which is not so
neglectible.

Samuel


-- 
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121224134830.GG6317@type



[bts-link] source package busybox

2012-12-24 Thread bts-link-upstream
#
# bts-link upstream status pull for source package busybox
# see http://lists.debian.org/debian-devel-announce/2006/05/msg1.html
#

user bts-link-upstr...@lists.alioth.debian.org

# remote status report for #695862 (http://bugs.debian.org/695862)
# Bug title: [busybox] fgrep -w not working
#  * https://bugs.busybox.net/show_bug.cgi?id=5792
#  * remote status changed: (?) - NEW
usertags 695862 + status-NEW

thanks


--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20121224165543.19724.80905.btsl...@sonntag.debian.org



[bts-link] source package src:busybox

2012-12-24 Thread bts-link-upstream
#
# bts-link upstream status pull for source package src:busybox
# see http://lists.debian.org/debian-devel-announce/2006/05/msg1.html
#

user bts-link-upstr...@lists.alioth.debian.org

# remote status report for #686502 (http://bugs.debian.org/686502)
# Bug title: busybox unxz silently fails to decompress multiple compressed 
streams on input
#  * https://bugs.busybox.net/show_bug.cgi?id=5804
#  * remote status changed: (?) - NEW
usertags 686502 + status-NEW

thanks


--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20121224165544.19724.8442.btsl...@sonntag.debian.org



Bug#696615: grub2: no possibility to install from usb media

2012-12-24 Thread Cyril Brulebois
Control: tag -1 confirmed

Hi Gert,

Gert Schulte g...@trash-mail.com (24/12/2012):
 Dear Maintainer,
 
 Installing from usb with mini.iso in expert mode and normal user mode. Grub2
 wants to install in /dev/sda, which is the MBR of the install media and 
 luckily
 fails. (Last year it did even overwrite the install media).
 There is no option to select any different installation location for grub 
 which
 leads to non-bootable systems for many users.
 
 I had to chroot into my fresh installation to install grub2.
 
 Sorry, this did always happen the last months with several mini.iso on several
 systems but I did not get to report it.
 
 Please have the install choose the right MBR (e.g. the HD you installed the
 system on) and have an option to choose a different location for expert modus
 and for normal user modus if installation fails.
 
 Thanks

I must say I've been trying to reproduce some issues with grub-install
vs. MBR lately, and I think there are basically two of them: one with
non-sensical strings, which Wouter has been trying to diagnose, and
finally worked around:
  http://packages.qa.debian.org/g/grub-installer/news/20121216T164729Z.html

and the one where the wrong /dev/sdFOO gets chosen.

I've just tried the following, instead of using some mini.iso (or any
official iso) in a CD-Rom drive:
 - convert it to a VDI image:
 VBoxManage convertfromraw dest/netboot/gtk/mini.iso 
dest/netboot/gtk/mini.vdi
 - attach the resulting VDI image to SATA port 0 in virtualbox.
 - use guided partitioning, everything in a single partition, into
   /dev/sdb (SATA port 1)
 - enjoy the attempted “grub-install /dev/sda” call.

I'll be trying to fix that before rc1.

Thanks for the reminder/bug report.

Mraw,
KiBi.


signature.asc
Description: Digital signature


Processed: Re: Bug#696615: grub2: no possibility to install from usb media

2012-12-24 Thread Debian Bug Tracking System
Processing control commands:

 tag -1 confirmed
Bug #696615 [debian-installer-7.0-netboot-amd64] grub2: no possibility to 
install from usb media
Added tag(s) confirmed.

-- 
696615: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696615
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.b696615.13563703372990.transcr...@bugs.debian.org



Bug#696615: grub2: no possibility to install from usb media

2012-12-24 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (24/12/2012):
 I've just tried the following, instead of using some mini.iso (or any
 official iso) in a CD-Rom drive:
  - convert it to a VDI image:
  VBoxManage convertfromraw dest/netboot/gtk/mini.iso 
 dest/netboot/gtk/mini.vdi
  - attach the resulting VDI image to SATA port 0 in virtualbox.
  - use guided partitioning, everything in a single partition, into
/dev/sdb (SATA port 1)
  - enjoy the attempted “grub-install /dev/sda” call.
 
 I'll be trying to fix that before rc1.

Here's what happens in grub-installer, with comments inline:
| # Try to avoid using (hd0) as a boot device name.  Something which can be
| # turned into a stable by-id name is better.
| default_bootdev_os=$($chroot $ROOT grub-mkdevicemap --no-floppy -m - | head 
-n1 | cut -f2)

Notice the head -n1 here. If you're booting from /dev/sda, that's what
you get, no matter what.

For reference, here's what it looks like for two disks:
  (hd0) /dev/disk/by-id/ata-VBOX_HARDDISK_id1-id2
  (hd1) /dev/disk/by-id/ata-VBOX_HARDDISK_id3-id4

| if [ $default_bootdev_os ]; then
| default_bootdev=$($chroot $ROOT readlink -f $default_bootdev_os)

That one turns the former top line into:
  /dev/sda

| else
| default_bootdev=(hd0)
| fi
| 
| # Set a sensible default boot device, so that we aren't installing GRUB to
| # installation media which may be removed later.  The disk containing /cdrom
| # is very unlikely to be a sensible default.  If we had to fall back to
| # (hd0), then we can't tell exactly which disk that is, but if /cdrom seems
| # to be a USB stick then (hd0) may not be safe.  If we hit either of those
| # checks, then try the disk containing /boot instead.
| # The same goes for /hd-media, so avoid installing there as well.
| cdsrc=$(mount | grep on /cdrom  | cut -d' ' -f1)
| cdfs=$(mount | grep on /cdrom  | cut -d' ' -f5)
| hdsrc=$(mount | grep on /hd-media  | cut -d' ' -f1)

Unfortunately, that kind of filtering can't really work for the boot
from USB case, since no /dev/sda shows up in mount's output (or in
/proc/mounts). All we have about it is presumably:
  rootfs / rw 0 0

which isn't exactly sufficient. Otherwise, we could just insert some
“grep -v $foo” before the head/cut pair in the first line I quoted.

Another way I see would be:
 1. use /etc/fstab in /target to see whether there's a /boot there,
and fall back to / if needed.
 2. use readlink on /dev/disk/by-uuid/$UUID to get the appropriate
partition (say /dev/sdb1 for a full disk installation in my case),
and get back to the actual disk (/dev/sdb).
 3. use that as the default.

Let's see whether a big red man pops up tonight with a clever(er) idea.

Mraw,
KiBi.


signature.asc
Description: Digital signature


Setting up the clock progress bar jumpy

2012-12-24 Thread Bob Proulx
I see somewhat strange behavior on the display when the installer gets
to the part about setting up the clock and contacting the ntp server.
The progress bar says 0%, then 3%, then 0%, then 3%, then 0%, then 3%,
back and forth several times for the space of many seconds before it
eventually proceeds onward.  This is obviously very minor.  But it
caught my eye and just appeared very strange.

This is using Installer build: 20121224-00:11 as a PXE booted
netinst.  I updated the bits today.

Bob


signature.asc
Description: Digital signature


Bug#686502: pxz produces archives broken for busybox's unxz

2012-12-24 Thread Abou Al Montacir
On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
 
 What happens if a stream ends at a buffer boundary, followed by
 padding?  Or if padding doesn't fit in the buffer, for that
 matter?
 
 Hope that helps,

Please find attached new debdiff with fix of above mentioned issues.

Cheers,
diff -Nru busybox-1.20.0/debian/changelog busybox-1.20.0/debian/changelog
--- busybox-1.20.0/debian/changelog	2012-09-20 08:32:55.0 +0200
+++ busybox-1.20.0/debian/changelog	2012-12-21 21:59:39.0 +0100
@@ -1,3 +1,10 @@
+busybox (1:1.20.0-7.1) unstable; urgency=low
+
+  * Fix decompression of multi stream XZ compressed files
+(Closes: Bug#bug#686502)
+
+ -- Abou Al Montacir abou.almonta...@sfr.fr  Thu, 21 Dec 2012 22:00:00 +0100
+
 busybox (1:1.20.0-7) unstable; urgency=low
 
   * set CONFIG_FEATURE_COPYBUF_KB from 4 to 64 for all flavours.  This
diff -Nru busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch
--- busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch	1970-01-01 01:00:00.0 +0100
+++ busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch	2012-12-24 23:12:05.0 +0100
@@ -0,0 +1,74 @@
+Author: Abou Al Montacir abou.almonta...@sfr.fr
+Purpose: Fix decompression of multi stream XZ compressed files
+ (Closes: bug#686502)
+
+--- busybox-1.20.0/archival/libarchive/decompress_unxz.c	2012-12-24 21:21:47.0 +0100
 busybox-1.20.0/debian/build/deb/archival/libarchive/decompress_unxz.c	2012-12-24 23:10:35.0 +0100
+@@ -44,6 +44,7 @@
+ 	struct xz_dec *state;
+ 	unsigned char *membuf;
+ 	IF_DESKTOP(long long) int total = 0;
++	enum xz_ret r;
+ 
+ 	if (!global_crc32_table)
+ 		global_crc32_table = crc32_filltable(NULL, /*endian:*/ 0);
+@@ -59,12 +60,10 @@
+ 		strcpy((char*)membuf, HEADER_MAGIC);
+ 		iobuf.in_size = HEADER_MAGIC_SIZE;
+ 	} /* else: let xz code read  check it */
+-
+-	/* Limit memory usage to about 64 MiB. */
+-	state = xz_dec_init(XZ_DYNALLOC, 64*1024*1024);
++	/* First stream is identical to starting a new stream after finishing decoding an old one */
++	r = XZ_STREAM_END;
+ 
+ 	while (1) {
+-		enum xz_ret r;
+ 
+ 		if (iobuf.in_pos == iobuf.in_size) {
+ 			int rd = safe_read(src_fd, membuf, BUFSIZ);
+@@ -73,9 +72,25 @@
+ total = -1;
+ break;
+ 			}
++			/* No more bytes in stream. Stop */
++			if (rd == 0) {
++break;
++			}
+ 			iobuf.in_size = rd;
+ 			iobuf.in_pos = 0;
+ 		}
++		if (r == XZ_STREAM_END) {
++			/* Eat padding. Stream never starts with zeros */
++			while ((iobuf.in_pos  iobuf.in_size)  (iobuf.in[iobuf.in_pos] == 0)) {
++	iobuf.in_pos += 1;
++			}
++			/* Reached end of buffer. Fill it again from stream */
++			if (iobuf.in_pos == iobuf.in_size) {
++continue;
++			}
++			/* Initialize decoder for new stream. Limit memory usage to about 64 MiB. */
++			state = xz_dec_init(XZ_DYNALLOC, 64*1024*1024);
++		}
+ //		bb_error_msg(in pos:%d size:%d out pos:%d size:%d,
+ //iobuf.in_pos, iobuf.in_size, iobuf.out_pos, iobuf.out_size);
+ 		r = xz_dec_run(state, iobuf);
+@@ -87,7 +102,9 @@
+ 			iobuf.out_pos = 0;
+ 		}
+ 		if (r == XZ_STREAM_END) {
+-			break;
++			xz_dec_end(state);
++			/* Look for any other streams */
++			continue;
+ 		}
+ 		if (r != XZ_OK  r != XZ_UNSUPPORTED_CHECK) {
+ 			bb_error_msg(corrupted data);
+@@ -95,7 +112,6 @@
+ 			break;
+ 		}
+ 	}
+-	xz_dec_end(state);
+ 	free(membuf);
+ 
+ 	return total;
diff -Nru busybox-1.20.0/debian/patches/series busybox-1.20.0/debian/patches/series
--- busybox-1.20.0/debian/patches/series	2012-09-19 22:58:00.0 +0200
+++ busybox-1.20.0/debian/patches/series	2012-12-20 21:54:21.0 +0100
@@ -25,3 +25,6 @@
 dont-force-no-alignment-for-s390.patch
 
 stop-checking-ancient-kernel-version.patch
+
+# http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686502
+fix-unxz-with-multiple-streams.patch


signature.asc
Description: This is a digitally signed message part


Bug#686502: pxz produces archives broken for busybox's unxz

2012-12-24 Thread Jonathan Nieder
Abou Al Montacir wrote:
 On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:

 What happens if a stream ends at a buffer boundary, followed by
 padding?  Or if padding doesn't fit in the buffer, for that
 matter?
[...]
 Please find attached new debdiff with fix of above mentioned issues.

Getting closer.  Does this correctly handle the case of a file with
zero streams?  (It should error out.)  How about a file with leading
NUL bytes, which is also invalid?

Does this implementation meet the following requirement (from the
spec)?

| Stream Padding MUST contain only null bytes. To preserve the
| four-byte alignment of consecutive Streams, the size of Stream
| Padding MUST be a multiple of four bytes. Empty Stream Padding
| is allowed. If these requirements are not met, the decoder MUST
| indicate an error.

Thanks for your patient work.
Jonathan


-- 
To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121225011143.GA23669@elie.Belkin



Bug#696651: doesn't load saved XKBOPTIONS

2012-12-24 Thread David Paleino
Package: keyboard-configuration
Version: 1.88
Severity: normal

Hello,

today I had to write some Merry Christmas messages to my Esperantists friends
and.. I found out that my Multi_key didn't work anymore!

It is correctly set in /etc/default/keyboard (compose:rwin) -- and in fact
it worked, I hadn't changed anything -- but xev revealed that rwin actually
triggered:

  state 0x0, keycode 133 (keysym 0xffeb, Super_L), same_screen YES,

instead of the expected:

  state 0x40, keycode 133 (keysym 0xff20, Multi_key), same_screen YES,

After putting keycode 133 = Multi_key in ~/.xmodmap, and loading it, it
started working again, and xev shows the correct key being input.

I'm not sure whether this is the correct package to file this bug against,
please reassign as appropriate.

Dankegon,
David

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.6-trunk-686-pae (SMP w/1 CPU core)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages keyboard-configuration depends on:
ii  debconf 1.5.48
ii  initscripts 2.88dsf-35
ii  liblocale-gettext-perl  1.05-7+b1

keyboard-configuration recommends no packages.

keyboard-configuration suggests no packages.

Versions of packages console-setup depends on:
ii  console-setup-linux  1.88
ii  debconf  1.5.48
ii  xkb-data 2.5.1-2.1

Versions of packages console-setup suggests:
ii  locales2.16-0experimental1
ii  locales-all [locales]  2.16-0experimental1
ii  lsb-base   4.1+Debian9

Versions of packages console-setup-linux depends on:
ii  kbd  1.15.3-9

Versions of packages console-setup-linux suggests:
ii  console-setup  1.88

Versions of packages keyboard-configuration is related to:
pn  console-common  none
pn  console-datanone
pn  console-tools   none
ii  kbd 1.15.3-9

-- debconf information:
  console-setup/codeset47: # Latin1 and Latin5 - western Europe and Turkic
languages keyboard-configuration/layout:
  keyboard-configuration/xkb-keymap: it
  keyboard-configuration/variant: Italiana
  debian-installer/console-setup-udeb/title:
  keyboard-configuration/unsupported_options: true
  console-setup/framebuffer_only:
  keyboard-configuration/ctrl_alt_bksp: true
  keyboard-configuration/variantcode:
  console-setup/guess_font:
  console-setup/store_defaults_in_debconf_db: true
  keyboard-configuration/other:
  keyboard-configuration/optionscode:
lv3:ralt_switch,compose:lwin,terminate:ctrl_alt_bksp
console-setup/use_system_font: console-setup/fontsize: 8x16
  keyboard-configuration/modelcode: pc105
  keyboard-configuration/unsupported_config_options: true
  console-setup/fontface47: Fixed
  keyboard-configuration/unsupported_config_layout: true
  keyboard-configuration/toggle: No toggling
  console-setup/fontsize-text47: 8x16
  keyboard-configuration/compose: Left Logo key
  keyboard-configuration/switch: No temporary switch
  console-setup/charmap47: UTF-8
  keyboard-configuration/altgr: Right Alt (AltGr)
  console-setup/codesetcode: Lat15
  keyboard-configuration/unsupported_layout: true
  keyboard-configuration/model: Generica 105 tasti (Intl) PC
  keyboard-configuration/layoutcode: it
  console-setup/fontsize-fb47: 8x16
  keyboard-configuration/store_defaults_in_debconf_db: true



-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 | http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


signature.asc
Description: PGP signature