Bug#870448: hw-detect - stop using modprobe -l

2017-08-01 Thread Vincent McIntyre 
Package: hw-detect
Version: 1.124
Severity: normal
Tags: patch

I keep seeing this in installer logs, back to jessie.

Aug  2 01:52:11 main-menu[193]: (process:224): modprobe: invalid option -- 'l'


I rated this normal rather than minor because the way it is working
now the is_available() function always returns 1 (failure)

My suggestion is to use modinfo instead.
This will return multiline output inside the quotes but
a couple of tests suggests that is ok.
It does fail with some modules (nvidia), not sure if we care.

diff --git a/hw-detect.sh b/hw-detect.sh
index 7977814..d8196c1 100755
--- a/hw-detect.sh
+++ b/hw-detect.sh
@@ -43,7 +43,7 @@ is_not_loaded() {
 }
 
 is_available () {
-   [ "$(modprobe -l $1)" ] || return 1
+   [ "$(modinfo $1)" ] || return 1
 }
 
 # Module as first parameter, description of device the second.

Kind regards
Vince

Bug#759553: suggested patch

2017-08-01 Thread Steve McIntyre 
Control: tag -1 +pending

On Wed, Aug 02, 2017 at 10:26:12AM +1000, Vincent McIntyre wrote:
>Tags: patch
>Thanks
>
>Can this be fixed please? I wasted an hour tracking this down
>while trying to resolve another issue.
>
>
>--- lib/auto-lvm.sh.org 2017-08-02 10:24:35.773321165 +1000
>+++ lib/auto-lvm.sh 2017-08-02 10:24:49.709392154 +1000
>@@ -302,7 +302,7 @@
>defvgname="$RET"
> 
># Check that the volume group name is not in use
>-   if ! vg_get_info "$defvgname" && ! stat "/dev/$defvgname"; then
>+   if ! vg_get_info "$defvgname" && [ ! -e "/dev/$defvgname" ]; 
>then
>break
>fi
>noninteractive="bail_out vg_exists"

Cool, thanks for the patch. I've just pushed the fix into git now.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"You can't barbecue lettuce!" -- Ellie Crane

Processed: Re: Bug#759553: suggested patch

2017-08-01 Thread Debian Bug Tracking System 
Processing control commands:

> tag -1 +pending
Bug #759553 [partman-auto-lvm] partman-auto-lvm: Script uses nonexisting 'stat' 
binary in d-i
Added tag(s) pending.

-- 
759553: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759553
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#759553: suggested patch

2017-08-01 Thread Vincent McIntyre 
Tags: patch
Thanks


Can this be fixed please? I wasted an hour tracking this down
while trying to resolve another issue.


--- lib/auto-lvm.sh.org 2017-08-02 10:24:35.773321165 +1000
+++ lib/auto-lvm.sh 2017-08-02 10:24:49.709392154 +1000
@@ -302,7 +302,7 @@
defvgname="$RET"
 
# Check that the volume group name is not in use
-   if ! vg_get_info "$defvgname" && ! stat "/dev/$defvgname"; then
+   if ! vg_get_info "$defvgname" && [ ! -e "/dev/$defvgname" ]; 
then
break
fi
noninteractive="bail_out vg_exists"

Kind regards
Vince

Bug#870331: installation-reports: Fails to install grub in the MBR of second device via menu item

2017-08-01 Thread Andrea Brenci 
Package: installation-reports
Severity: normal
Tags: d-i

Dear Maintainer,

-- Package-specific info:

Boot method: CD
Image version: 
https://cdimage.debian.org/cdimage/daily-builds/daily/arch-latest/i386/iso-cd/debian-testing-i386-netinst.iso
 - 20170725-09:50
Date: 25 July 2017

Machine: Laptop Acer TM4002
Partitions: 
File systemTipo 1K-blocchi   Usati Disponib. Uso% Montato su
udev   devtmpfs 618560   0618560   0% /dev
tmpfs  tmpfs1255084220121288   4% /run
/dev/sdb6  ext2   23780504 3859820  18712672  18% /
tmpfs  tmpfs6275286968620560   2% /dev/shm
tmpfs  tmpfs  5120   4  5116   1% /run/lock
tmpfs  tmpfs627528   0627528   0% /sys/fs/cgroup
tmpfs  tmpfs125504  16125488   1% /run/user/1000


Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it

Initial boot:   [O]
Detect network card:[O]
Configure network:  [O]
Detect CD:  [O]
Load installer modules: [O]
Clock/timezone setup:   [O]
User/password setup:[O]
Detect hard drives: [O]
Partition hard drives:  [O]
Install base system:[O]
Install tasks:  [O]
Install boot loader:[E]
Overall install:[O]

Comments/Problems:



Installation of grub in the MBR of /dev/sdb using menu item (expert install, 
not gui) failed.
Installation of grub in the MBR of /dev/sdb setting it by hand (expert install) 
was successful.

-- 

Please make sure that the hardware-summary log file, and any other
installation logs that you think would be useful are attached to this
report. Please compress large files using gzip.

Once you have filled out this report, mail it to sub...@bugs.debian.org.

==
Installer lsb-release:
==
DISTRIB_ID=Debian
DISTRIB_DESCRIPTION="Debian GNU/Linux installer"
DISTRIB_RELEASE="9 (stretch) - installer build 20170725-00:33"
X_INSTALLATION_MEDIUM=cdrom

==
Installer hardware-summary:
==
uname -a: Linux (none) 4.11.0-2-686 #1 SMP Debian 4.11.11-1 (2017-07-22) i686 
GNU/Linux
lspci -knn: 00:00.0 Host bridge [0600]: Intel Corporation 82852/82855 
GM/GME/PM/GMV Processor to I/O Controller [8086:3580] (rev 02)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel driver in use: agpgart-intel
lspci -knn: 00:00.1 System peripheral [0880]: Intel Corporation 82852/82855 
GM/GME/PM/GMV Processor to I/O Controller [8086:3584] (rev 02)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: 00:00.3 System peripheral [0880]: Intel Corporation 82852/82855 
GM/GME/PM/GMV Processor to I/O Controller [8086:3585] (rev 02)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: 00:02.0 VGA compatible controller [0300]: Intel Corporation 
82852/855GM Integrated Graphics Device [8086:3582] (rev 02)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: 00:02.1 Display controller [0380]: Intel Corporation 82852/855GM 
Integrated Graphics Device [8086:3582] (rev 02)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: 00:1d.0 USB controller [0c03]: Intel Corporation 82801DB/DBL/DBM 
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 [8086:24c2] (rev 03)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel driver in use: uhci_hcd
lspci -knn: Kernel modules: uhci_hcd
lspci -knn: 00:1d.1 USB controller [0c03]: Intel Corporation 82801DB/DBL/DBM 
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 [8086:24c4] (rev 03)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel driver in use: uhci_hcd
lspci -knn: Kernel modules: uhci_hcd
lspci -knn: 00:1d.2 USB controller [0c03]: Intel Corporation 82801DB/DBL/DBM 
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 [8086:24c7] (rev 03)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel driver in use: uhci_hcd
lspci -knn: Kernel modules: uhci_hcd
lspci -knn: 00:1d.7 USB controller [0c03]: Intel Corporation 82801DB/DBM 
(ICH4/ICH4-M) USB2 EHCI Controller [8086:24cd] (rev 03)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel driver in use: ehci-pci
lspci -knn: Kernel modules: ehci_pci
lspci -knn: 00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI 
Bridge [8086:2448] (rev 83)
lspci -knn: 00:1f.0 ISA bridge [0601]: Intel Corporation 82801DBM (ICH4-M) LPC 
Interface Bridge [8086:24cc] (rev 03)
lspci -knn: 00:1f.1 IDE interface [0101]: Intel Corporation 82801DBM (ICH4-M) 
IDE Controller [8086:24ca] (rev 03)
lspci -knn: Subsystem: Acer Incorporated [ALI] Device [1025:0064]
lspci -knn: Kernel