Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread John Paul Adrian Glaubitz
On 10/8/18 5:33 PM, Philipp Kern wrote:
>> Controversial opinion: It should use sbuild instead of pbuilder. sbuild
>> is more actively maintained and more reliable in my experience. sbuild
>> is also what the buildds are using.
> 
> sbuild doesn't solve this particular problem either. You need to pass in 
> DEB_BUILD_OPTIONS=parallel=n rather than setting --jobs. The latter is mapped 
> to -j, which breaks (because it's put into MAKEFLAGS) and the former maps to 
> -J.

Ok, I've never used "-j" though which is probably why I have never run into
this problem. Sounds like an obscure option to me after reading the manpage.

> Julien is right in that there is a bug here that's worth fixing but the 
> default build environment which is incredibly hard to discover does not 
> expose them.

What exactly is this particular bug then? Does the rules file of choose-mirror
anything special in this regard?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Philipp Kern

On 2018-10-08 12:42, John Paul Adrian Glaubitz wrote:

On 10/8/18 12:38 PM, Holger Wansing wrote:

Ok, so we have no package problem at all?


Well, it builds fine on the buildds and it also does not show build 
issues

on reproducible-builds.org:


https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/choose-mirror.html


Should that bug be reassigned to jenkins.debian.org then, to make 
jenkins

happy on that topic, too?
jenkins seems to not having parallel builds activated?
Should probably use similar settings as the buildds, to give 
comparable

results?


Controversial opinion: It should use sbuild instead of pbuilder. sbuild
is more actively maintained and more reliable in my experience. sbuild
is also what the buildds are using.


sbuild doesn't solve this particular problem either. You need to pass in 
DEB_BUILD_OPTIONS=parallel=n rather than setting --jobs. The latter is 
mapped to -j, which breaks (because it's put into MAKEFLAGS) and the 
former maps to -J.


Julien is right in that there is a bug here that's worth fixing but the 
default build environment which is incredibly hard to discover does not 
expose them.


Kind regards
Philipp Kern



Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Julien Cristau
There's a bug in choose-mirror. It's just not serious. 

Julien 

On October 8, 2018 12:38:40 PM GMT+02:00, Holger Wansing  
wrote:
>Hi,
>
>Philipp Kern  wrote:
>> On 2018-10-08 09:08, John Paul Adrian Glaubitz wrote:
>> > On 10/8/18 7:51 AM, Holger Wansing wrote:
>> >> Since version 2.92, choose-mirror fails to build with
>> >> "dpkg-buildpackage -j", the debian/iso_3166.tab file seems to be 
>> >> removed by
>> >> error:
>> >> 
>> >> (can also be seen at jenkins:
>> >>
>https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/
>> >> where I found it initially)
>> > It builds fine here on my machine using sbuild and also fine on the
>
>> > buildds
>> > which are building with sbuild and "parallel=N" with N >= 2 [1].
>> > 
>> > You are building in an unclean build environment unless you are 
>> > building with
>> > something like sbuild and pbuilder, so your build results can have 
>> > unexpected
>> > results.
>> > 
>> > Please create a local sbuild setup and try again.
>> > 
>> > Adrian
>> > 
>> >> [1] 
>> >>
>https://buildd.debian.org/status/package.php?p=choose-mirror=unstable
>> 
>> dpkg-buildpackage -j is like the worst option to ever have been 
>> introduced and not removed. Try -J instead. :(
>
>Ok, so we have no package problem at all?
>
>Should that bug be reassigned to jenkins.debian.org then, to make
>jenkins
>happy on that topic, too?
>jenkins seems to not having parallel builds activated?
>Should probably use similar settings as the buildds, to give comparable
>results?
>
>
>Holger
>
>
>-- 
>Holger Wansing 
>PGP-Finterprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076


Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread John Paul Adrian Glaubitz
On 10/8/18 12:38 PM, Holger Wansing wrote:
> Ok, so we have no package problem at all?

Well, it builds fine on the buildds and it also does not show build issues
on reproducible-builds.org:

> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/choose-mirror.html

> Should that bug be reassigned to jenkins.debian.org then, to make jenkins
> happy on that topic, too?
> jenkins seems to not having parallel builds activated?
> Should probably use similar settings as the buildds, to give comparable
> results?

Controversial opinion: It should use sbuild instead of pbuilder. sbuild
is more actively maintained and more reliable in my experience. sbuild
is also what the buildds are using.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Holger Wansing
Hi,

Philipp Kern  wrote:
> On 2018-10-08 09:08, John Paul Adrian Glaubitz wrote:
> > On 10/8/18 7:51 AM, Holger Wansing wrote:
> >> Since version 2.92, choose-mirror fails to build with
> >> "dpkg-buildpackage -j", the debian/iso_3166.tab file seems to be 
> >> removed by
> >> error:
> >> 
> >> (can also be seen at jenkins:
> >> https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/
> >> where I found it initially)
> > It builds fine here on my machine using sbuild and also fine on the 
> > buildds
> > which are building with sbuild and "parallel=N" with N >= 2 [1].
> > 
> > You are building in an unclean build environment unless you are 
> > building with
> > something like sbuild and pbuilder, so your build results can have 
> > unexpected
> > results.
> > 
> > Please create a local sbuild setup and try again.
> > 
> > Adrian
> > 
> >> [1] 
> >> https://buildd.debian.org/status/package.php?p=choose-mirror=unstable
> 
> dpkg-buildpackage -j is like the worst option to ever have been 
> introduced and not removed. Try -J instead. :(

Ok, so we have no package problem at all?

Should that bug be reassigned to jenkins.debian.org then, to make jenkins
happy on that topic, too?
jenkins seems to not having parallel builds activated?
Should probably use similar settings as the buildds, to give comparable
results?


Holger


-- 
Holger Wansing 
PGP-Finterprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Processed: Re: Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Debian Bug Tracking System
Processing control commands:

> severity -1 wishlist
Bug #910560 [choose-mirror] [choose-mirror] fails to build when parallel build 
is activated
Severity set to 'wishlist' from 'serious'

-- 
910560: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910560
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Julien Cristau
Control: severity -1 wishlist

On 10/08/2018 07:51 AM, Holger Wansing wrote:
> Package: choose-mirror
> Severity: serious
> Version: 2.92
> 
> Since version 2.92, choose-mirror fails to build with
> "dpkg-buildpackage -j", the debian/iso_3166.tab file seems to be removed by 
> error:
> 
> (can also be seen at jenkins:
> https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/ 
> where I found it initially)
> 
> 
Reducing severity, dpkg-buildpackage -j is broken.

Cheers,
Julien



Re: Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread Philipp Kern

On 2018-10-08 09:08, John Paul Adrian Glaubitz wrote:

On 10/8/18 7:51 AM, Holger Wansing wrote:

Since version 2.92, choose-mirror fails to build with
"dpkg-buildpackage -j", the debian/iso_3166.tab file seems to be 
removed by

error:

(can also be seen at jenkins:
https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/
where I found it initially)
It builds fine here on my machine using sbuild and also fine on the 
buildds

which are building with sbuild and "parallel=N" with N >= 2 [1].

You are building in an unclean build environment unless you are 
building with
something like sbuild and pbuilder, so your build results can have 
unexpected

results.

Please create a local sbuild setup and try again.

Adrian

[1] 
https://buildd.debian.org/status/package.php?p=choose-mirror=unstable


dpkg-buildpackage -j is like the worst option to ever have been 
introduced and not removed. Try -J instead. :(


Kind regards
Philipp Kern



Re: Bug#910560: [choose-mirror] fails to build when parallel build is activated

2018-10-08 Thread John Paul Adrian Glaubitz
On 10/8/18 7:51 AM, Holger Wansing wrote:
> Since version 2.92, choose-mirror fails to build with
> "dpkg-buildpackage -j", the debian/iso_3166.tab file seems to be removed by 
> error:
> 
> (can also be seen at jenkins:
> https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/ 
> where I found it initially)
It builds fine here on my machine using sbuild and also fine on the buildds
which are building with sbuild and "parallel=N" with N >= 2 [1].

You are building in an unclean build environment unless you are building with
something like sbuild and pbuilder, so your build results can have unexpected
results.

Please create a local sbuild setup and try again.

Adrian

> [1] 
> https://buildd.debian.org/status/package.php?p=choose-mirror=unstable

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Re: choose-mirror_2.94_source.changes ACCEPTED into unstable

2018-10-08 Thread Holger Wansing
Hi,

Cyril Brulebois  wrote:
> Hi,
> 
> Holger Wansing  (2018-10-07):
> > Since several weeks or even months, choose-mirror fails to build at jenkins:
> > https://jenkins.debian.net/view/d-i_packages/job/d-i_build_choose-mirror/
> > 
> > Is this relevant?
> > 
> > I fail to see, what's causing this, since the last commit before the first
> > failure was just a translation update:
> > https://salsa.debian.org/installer-team/choose-mirror/commit/75b5c3b82c21d058fc9c6a6a22c8e43091ab9af3
> > 
> > And it builds fine here locally.
> > 
> > Any hints?
> 
> Sure, I mentioned that on IRC a while ago but failed to find time to
> file a proper bug report, sorry about that…

Done.

> 2018-09-17 01:34:39-KGB-1:#debian-boot- Failed  
> https://jenkins.debian.net/job/d-i_build_choose-mirror/145
> 2018-09-17 01:38:35[ kibi] that looks like a dependency issue; can 
> reproduce locally with dpkg-buildpackage -j
> 2018-09-17 01:42:16[ kibi] ahah, some targets call clean
> 2018-09-17 01:42:22[ kibi] so the .tab file disappears



-- 
Holger Wansing 
PGP-Finterprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076