Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-24 Thread Frans Pop
On Wednesday 23 July 2008, Joey Hess wrote:
 Frans Pop wrote:
  You change has not yet be committed though, so this could be taken
  along. It would just be:
  ls -1 /sys/class/net | grep -v ^lo$

 I like keeping bugfixes separate from potential bug introduction. :-)
 And your code needs to grep out 'lo/'

No. With '-1' you don't get trailing slashes for directories.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-24 Thread Joey Hess
Frans Pop wrote:
 No. With '-1' you don't get trailing slashes for directories.

FWIW, that's a busyboxism. I'd use find.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-24 Thread Frans Pop
On Thursday 24 July 2008, Joey Hess wrote:
 Frans Pop wrote:
  No. With '-1' you don't get trailing slashes for directories.

 FWIW, that's a busyboxism.

And bashism too then...

 I'd use find. 

Yes, I thought of that. I dislike having to restrict depth but it would 
allow to explicitly select dirs.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Joey Hess
Jérémy Bobbio wrote:
 Wild guess after having a look at the log: is the firmware only
 requested when trying to brought the interface up?
 
 If you still have access to the necessary hardware, can you look how far
 I am from what is really happening?

Hardware is not mine and already in production unfortunatly. But looking at
the log again, I think you may be right, the driver only complains about
microcode once upped by netcfg:

Jul 21 02:40:45 kernel: [   29.419310] iwl4965: Detected Intel Wireless WiFi 
Link 4965AGN
Jul 21 02:40:45 kernel: [   29.469768] iwl4965: Tunable channels: 11 802.11bg, 
13 802.11a channels
Jul 21 02:40:47 main-menu[1466]: INFO: Menu item 'netcfg' selected
Jul 21 02:40:47 kernel: [   30.851885] iwl4965: iwlwifi-4965-1.ucode firmware 
file req failed: Reason -2
Jul 21 02:40:47 kernel: [   30.851892] iwl4965: Could not read microcode: -2

FWIW, this doesn't affect other wifi drivers that use firmware. At least,
the one I can easily test, ipw2200, requests firmware immediatly on load.

 If something close happens, we probably need to find a way to up then
 down every interfaces in ethdetect, just to be sure that we have the
 necessary firmware.

There's another way.. netcfg could run check-missing-firmware after
it ups the interface (either after dhcp fails, or after static configuration).

Or netcfg could bring interfaces up with a fake IP before trying dhcp at all,
to avoid dhcp timeouts. But that may be overkill.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Joey Hess
Joey Hess wrote:
 Hardware is not mine and already in production unfortunatly.

It'll be a week or two until I can even boot a test image on it.

This patch will up and then down every interface. That seems safe enough
to do, especially since netcfg also ups and downs all interfaces when
doing link detection. It does mean that if the network is up, ethdetect
will take it down.

Index: ethdetect.sh
===
--- ethdetect.sh(revision 54544)
+++ ethdetect.sh(working copy)
@@ -82,12 +82,15 @@
rm -f $TEMP_EXTRACT
 }
 
+lsifaces () {
+   sed -e s/lo://  /proc/net/dev | grep [a-z0-9]*:[ ]*[0-9]* | sed 
s/:.*//; s/^ *//
+}
+
 ethernet_found() {
local ifaces=0
local firewire=0
 
-   for iface in $(sed -e s/lo://  /proc/net/dev | \
-   grep [a-z0-9]*:[ ]*[0-9]* | sed s/:.*//; s/^ *//); 
do
+   for iface in $(lsifaces); do
ifaces=$(expr $ifaces + 1)
if [ -f /etc/network/devnames ]; then
if grep ^$iface: /etc/network/devnames | \
@@ -237,6 +240,13 @@
fi
 done
 
+# Some modules only try to load firmware once brought up. So bring up and
+# then down all interfaces.
+for iface in $(lsifaces); do
+   ip link set $iface up
+   ip link set $iface down
+done
 check-missing-firmware
+
 sysfs-update-devnames || true
 cleanup

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Frans Pop
On Wednesday 23 July 2008, Joey Hess wrote:
 +lsifaces () {
 + sed -e s/lo://  /proc/net/dev | grep [a-z0-9]*:[ ]*[0-9]* | sed
 s/:.*//; s/^ *// +}

Use 'ls /sys/class/net/' instead?



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Joey Hess
Frans Pop wrote:
 On Wednesday 23 July 2008, Joey Hess wrote:
  +lsifaces () {
  +   sed -e s/lo://  /proc/net/dev | grep [a-z0-9]*:[ ]*[0-9]* | sed
  s/:.*//; s/^ *// +}
 
 Use 'ls /sys/class/net/' instead?

That would probably be a good idea if someone wants to do it.. above
code was already in ethdetect and just factored out.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Frans Pop
On Wednesday 23 July 2008, you wrote:
 Frans Pop wrote:
  On Wednesday 23 July 2008, Joey Hess wrote:
   +lsifaces () {
   + sed -e s/lo://  /proc/net/dev | grep [a-z0-9]*:[ ]*[0-9]* |
   sed s/:.*//; s/^ *// +}
 
  Use 'ls /sys/class/net/' instead?

 That would probably be a good idea if someone wants to do it.. above
 code was already in ethdetect and just factored out.

You change has not yet be committed though, so this could be taken along.
It would just be:
ls -1 /sys/class/net | grep -v ^lo$



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Joey Hess
Frans Pop wrote:
 You change has not yet be committed though, so this could be taken along.
 It would just be:
 ls -1 /sys/class/net | grep -v ^lo$

I like keeping bugfixes separate from potential bug introduction. :-)
And your code needs to grep out 'lo/'

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-23 Thread Joey Hess
Also, there's more /proc/net/dev parsing scattered throughout hw-detect, it 
should
probably all be changed together.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-22 Thread Jérémy Bobbio
reassign 491712 ethdetect
retitle 491712 firmware for iwl4965 is asked in disk-detect
thanks

On Mon, Jul 21, 2008 at 10:45:10AM -0400, Joey wrote:
 The wifi is iwl4965, and something didn't quite work in the firmware
 loading code. I had the firmware on the USB stick, attached, but was not
 prompted for it until after netcfg had run. (So the hw-detect run in
 disk-detect). I told it to install firmware, but did not see anything in
 /lib/firmware afterwards. Did see some codepage errors in the syslog. No
 error message displayed to me. Installed via ethernet.

Wild guess after having a look at the log: is the firmware only
requested when trying to brought the interface up?

This would explain why the firmware is only asked during disk-detect:
 1. ethdetect loads the iwl driver,
 2. netcfg tries to up the interface, which fails as the firmware is
missing, but iwl firmware is added to missing-firmware,
 3. disk-detect runs and ask for the iwl firmware.

If you still have access to the necessary hardware, can you look how far
I am from what is really happening?

If something close happens, we probably need to find a way to up then
down every interfaces in ethdetect, just to be sure that we have the
necessary firmware.

Cheers,
-- 
Jérémy Bobbio.''`. 
[EMAIL PROTECTED]: :Ⓐ  :  # apt-get install anarchism
`. `'` 
  `-   


signature.asc
Description: Digital signature


Processed: Re: Bug#491712: firmware for iwl4965 is asked in disk-detect (was: installation-reports: HP lenovo R61i laptop)

2008-07-22 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 reassign 491712 ethdetect
Bug#491712: installation-reports: HP lenovo R61i laptop
Bug reassigned from package `installation-reports' to `ethdetect'.

 retitle 491712 firmware for iwl4965 is asked in disk-detect
Bug#491712: installation-reports: HP lenovo R61i laptop
Changed Bug title to `firmware for iwl4965 is asked in disk-detect' from 
`installation-reports: HP lenovo R61i laptop'.

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]