Bug#808875: debian-installer: Perl transition

2015-12-23 Thread Cyril Brulebois 
gregor herrmann  (2015-12-24):
> On Thu, 24 Dec 2015 00:28:40 +0100, Cyril Brulebois wrote:
> 
> > [ Please keep debian-perl@ and debian-release@ in the loop. ]
> 
> > Just wanted to let you know that debian-installer still can't be built
> > since a few packages are missing. In my devel chroot, after a
> > dist-upgrade, I had to rebuild the following packages to make
> > debiandoc-sgml installable:
> >   debiandoc-sgml
> >   libhtml-parser-perl
> >   libhtml-tagset-perl
> >   libroman-perl
> >   libtext-format-perl
> > 
> > I've seen at least one of them getting a binNMU so I thought I'd cc
> > perl and release teams…
> 
> That's surprising, since libhtml-parser-perl is the only arch:any
> package, and it has already been NMUed some days ago. The others
> shouldn't be affected by the transition.

Seems to be a mirror needing a good kick, sorry about that…

The 5.20 → 5.22 thing still stands for -boot@ though.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#808875: debian-installer: Perl transition

2015-12-23 Thread Cyril Brulebois 
Control: severity -1 important
Control: tag -1 patch pending

[ -release dropped ]

gregor herrmann  (2015-12-24):
> On Thu, 24 Dec 2015 00:28:40 +0100, Cyril Brulebois wrote:
> 
> > In addition, one can see that kind of warnings during the build now:
> > | Unescaped left brace in regex is deprecated, passed through in regex;
> > | marked by <-- HERE in m/\${ <-- HERE BOOTPROMPT}\n?$/ at
> > | util/bootvars-subst line 13.
> > 
> > so one has to make sure how much d-i is affected by this transition.
> 
> Here's a patch for these warnings [0].

Thanks! Pushed:
  
https://anonscm.debian.org/cgit/d-i/debian-installer.git/commit/?id=ed4e1180d72d1d9765b9aeb17605a06f68371b6e

I didn't see any more warnings after a full build here (even if that was
only checked with a few greps).

> [0] which are harmless, unless something tests for "no warnings
> output", but also easy to fix. perldoc perldiag says: […]

Yeah, I think we discussed how much I like having advance warnings; but
it's always a good idea to deal with them before it's too late. :)

Mraw,
KiBi.


signature.asc
Description: Digital signature

Processed: Re: Bug#808875: debian-installer: Perl transition

2015-12-23 Thread Debian Bug Tracking System 
Processing control commands:

> severity -1 important
Bug #808875 [src:debian-installer] debian-installer: Perl transition
Severity set to 'important' from 'serious'
> tag -1 patch pending
Bug #808875 [src:debian-installer] debian-installer: Perl transition
Added tag(s) patch and pending.

-- 
808875: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808875
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#808875: debian-installer: Perl transition

2015-12-23 Thread gregor herrmann 
On Thu, 24 Dec 2015 00:28:40 +0100, Cyril Brulebois wrote:

> In addition, one can see that kind of warnings during the build now:
> | Unescaped left brace in regex is deprecated, passed through in regex;
> | marked by <-- HERE in m/\${ <-- HERE BOOTPROMPT}\n?$/ at
> | util/bootvars-subst line 13.
> 
> so one has to make sure how much d-i is affected by this transition.

Here's a patch for these warnings [0].


Cheers,
gregor


[0] which are harmless, unless something tests for "no warnings
output", but also easy to fix. perldoc perldiag says:

Unescaped left brace in regex is deprecated, passed through in regex;
marked by <-- HERE in m/%s/
(D deprecated, regexp) You used a literal "{" character in a regular
expression pattern. You should change to use "\{" instead, because a
future version of Perl (tentatively v5.26) will consider this to be a
syntax error. If the pattern delimiters are also braces, any matching
right brace ("}") should also be escaped to avoid confusing the
parser, for example,

qr{abc\{def\}ghi}


-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Joint Venture: Der Jesus von Oberpleis
diff --git a/build/util/bootvars-subst b/build/util/bootvars-subst
index e3e1fed..16a1227 100755
--- a/build/util/bootvars-subst
+++ b/build/util/bootvars-subst
@@ -10,8 +10,8 @@ while (@ARGV) {
 }
 
 while (<>) {
-	s/\${BOOTPROMPT}\n?$//g; # special case
-	s/\${([a-zA-Z0-9_]+)}/$subst{$1}/g;
+	s/\$\{BOOTPROMPT\}\n?$//g; # special case
+	s/\$\{([a-zA-Z0-9_]+)\}/$subst{$1}/g;
 	
 	print;
 }
diff --git a/build/util/pkg-list b/build/util/pkg-list
index b2faec8..29c56c9 100755
--- a/build/util/pkg-list
+++ b/build/util/pkg-list
@@ -234,10 +234,10 @@ sub getlists {
 next unless length;
 
 # normal kernel version substitution
-if (/\${kernel:Version}/) {
+if (/\$\{kernel:Version\}/) {
 	foreach my $v (@kernel_versions) {
 		my $l=$_;
-		$l=~s/\${kernel:Version}/$v-$kernel_flavour/g;
+		$l=~s/\$\{kernel:Version\}/$v-$kernel_flavour/g;
 		collectpackage($l, \%collect, \%exclude, \@postponed);
 	}
 	next; # move on to the next line


signature.asc
Description: Digital Signature

Bug#808875: debian-installer: Perl transition

2015-12-23 Thread gregor herrmann 
On Thu, 24 Dec 2015 00:28:40 +0100, Cyril Brulebois wrote:

> [ Please keep debian-perl@ and debian-release@ in the loop. ]

> Just wanted to let you know that debian-installer still can't be built
> since a few packages are missing. In my devel chroot, after a
> dist-upgrade, I had to rebuild the following packages to make
> debiandoc-sgml installable:
>   debiandoc-sgml
>   libhtml-parser-perl
>   libhtml-tagset-perl
>   libroman-perl
>   libtext-format-perl
> 
> I've seen at least one of them getting a binNMU so I thought I'd cc
> perl and release teams…

That's surprising, since libhtml-parser-perl is the only arch:any
package, and it has already been NMUed some days ago. The others
shouldn't be affected by the transition.

libhtml-parser-perl | 3.71-2| testing | source, amd64, arm64, 
armel, armhf, i386, mips, mipsel, powerpc, ppc64el, s390x
libhtml-parser-perl | 3.71-2| unstable| source
libhtml-parser-perl | 3.71-2+b1 | unstable| amd64, arm64, armel, 
armhf, hurd-i386, i386, kfreebsd-amd64, kfreebsd-i386, mips, mips64el, mipsel, 
powerpc, ppc64el, s390x

Package: debiandoc-sgml
Architecture: all
Depends: libhtml-parser-perl, libroman-perl, libtext-format-perl, sgml-data, 
sgmlspl, sp, sgml-base (>= 1.26+nmu2), perl

Package: libhtml-parser-perl
Architecture: amd64
Depends: perl (>= 5.22.1-1), perlapi-5.22.1, libc6 (>= 2.4), 
libhtml-tagset-perl, liburi-perl

Package: libhtml-tagset-perl
Architecture: all
Depends: perl (>= 5.6.0-16)

Package: libroman-perl
Architecture: all
Depends: perl

Package: libtext-format-perl
Architecture: all
Depends: perl


Cheers,
gregor, probably missing something in his d-i noobiness

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Page: When I Was A Child


signature.asc
Description: Digital Signature

Bug#808875: debian-installer: Perl transition

2015-12-23 Thread gregor herrmann 
On Thu, 24 Dec 2015 02:36:33 +0100, Cyril Brulebois wrote:

> > Here's a patch for these warnings [0].
> Thanks! Pushed:
>   
> https://anonscm.debian.org/cgit/d-i/debian-installer.git/commit/?id=ed4e1180d72d1d9765b9aeb17605a06f68371b6e

Thanks.
 
> I didn't see any more warnings after a full build here (even if that was
> only checked with a few greps).

Same here.
 
> > [0] which are harmless, unless something tests for "no warnings
> > output", but also easy to fix. perldoc perldiag says: […]
> Yeah, I think we discussed how much I like having advance warnings; but
> it's always a good idea to deal with them before it's too late. :)

I completely agree :)


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Hurricane


signature.asc
Description: Digital Signature

Bug#808875: debian-installer: Perl transition

2015-12-23 Thread Cyril Brulebois 
Source: debian-installer
Severity: serious
Justification: BD-Uninstallable etc.

[ Please keep debian-perl@ and debian-release@ in the loop. ]

Hi,

Just wanted to let you know that debian-installer still can't be built
since a few packages are missing. In my devel chroot, after a
dist-upgrade, I had to rebuild the following packages to make
debiandoc-sgml installable:
  debiandoc-sgml
  libhtml-parser-perl
  libhtml-tagset-perl
  libroman-perl
  libtext-format-perl

I've seen at least one of them getting a binNMU so I thought I'd cc
perl and release teams…

In addition, one can see that kind of warnings during the build now:
| Unescaped left brace in regex is deprecated, passed through in regex;
| marked by <-- HERE in m/\${ <-- HERE BOOTPROMPT}\n?$/ at
| util/bootvars-subst line 13.

so one has to make sure how much d-i is affected by this transition.


Mraw,
KiBi.