Bug#833097: flash-kernel: should exist when DTB doesn't exist
Control: retitle -1 flash-kernel: should exit when DTB doesn't exist signature.asc Description: Digital signature
Processed: Re: Bug#833097: flash-kernel: should exist when DTB doesn't exist
Processing control commands: > retitle -1 flash-kernel: should exit when DTB doesn't exist Bug #833097 [flash-kernel] flash-kernel: should exist when DTB doesn't exist Changed Bug title to 'flash-kernel: should exit when DTB doesn't exist' from 'flash-kernel: should exist when DTB doesn't exist'. -- 833097: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833097 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#833097: flash-kernel: should exist when DTB doesn't exist
On Sun, 2016-07-31 at 13:16 -0700, Martin Michlmayr wrote: > Package: flash-kernel > Version: 3.68 > > At the moment, flash-kernel doesn't exit when the DTB doesn't exist. > It will print the DTB to be used but then not copy it. That will > result in devices not being able to boot. > > Ian, is there a reason why we *don't* want to exit? Not that I can think of right now.
Bug#833097: flash-kernel: should exist when DTB doesn't exist
Package: flash-kernel Version: 3.68 At the moment, flash-kernel doesn't exit when the DTB doesn't exist. It will print the DTB to be used but then not copy it. That will result in devices not being able to boot. Ian, is there a reason why we *don't* want to exit? Right now we have: get_dtb_name() prints "DTB: $dtb_name" handle_dtb() returns if there's no DTB. If there's a DTB, handle_dtb() will call local dtb=$(find_dtb_file) But then it only copies the DTB if the file exists: if [ -e "$dtb" ]; then and there's no "else". Surely if a DTB is specified ($dtb_name is not empty) we need the DTB so there should be an else error "Cannot find DTB file $dtb" fi Is there a situation where we want to continue without the DTB file? -- Martin Michlmayr http://www.cyrius.com/
