Processed: Re: Bug#953878: libudev1-udeb: library wrongly shipped in the multiarch path

2020-03-14 Thread Debian Bug Tracking System
Processing control commands:

> reassign -1 mklibs
Bug #953878 [systemd] libudev1-udeb: library wrongly shipped in the multiarch 
path
Bug reassigned from package 'systemd' to 'mklibs'.
No longer marked as found in versions systemd/245-2.
Ignoring request to alter fixed versions of bug #953878 to the same values 
previously set

-- 
953878: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953878
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Re: Bug#953878: libudev1-udeb: library wrongly shipped in the multiarch path

2020-03-14 Thread Aurelien Jarno
On 2020-03-14 14:55, Michael Biebl wrote:
> Am 14.03.20 um 13:23 schrieb Aurelien Jarno:
> > Package: systemd
> > Version: 245-2
> > Severity: normal
> > Tags: patch
> > 
> > libudev1-udeb ships the libudev.so.1 in the multiarch path:
> > 
> > | $ dpkg -c libudev1-udeb_245-2_amd64.udeb
> > | drwxr-xr-x root/root 0 2020-03-12 12:55 ./
> > | drwxr-xr-x root/root 0 2020-03-12 12:55 ./lib/
> > | drwxr-xr-x root/root 0 2020-03-12 12:55 ./lib/x86_64-linux-gnu/
> > | -rw-r--r-- root/root174144 2020-03-12 12:55 
> > ./lib/x86_64-linux-gnu/libudev.so.1.6.17
> > | lrwxrwxrwx root/root 0 2020-03-12 12:55 
> > ./lib/x86_64-linux-gnu/libudev.so.1 -> libudev.so.1.6.17
> > 
> > udeb packages should ship the library in the non-multiarch path, i.e.
> > /lib or /usr/lib. Otherwise this causes mklibs to fetch the library from
> > the system instead of the udeb and increases the size of d-i image
> 
> Installing in M-A paths is deliberate to not have any pointless
> differences between the udeb and non-udeb build.

This is not something supported by the d-i build system.

> TBH, I don't understand the problems you list above. Why would shipping
> a file in a different path increase the size of the d-i image?
> 

This causes the d-i build system to not find the library, it therefore
fallback in to copying the system library, and thus it is present twice
in the initrd:

$ find . -name libudev.so.1
./lib/libudev.so.1
./lib/x86_64-linux-gnu/libudev.so.1

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net


signature.asc
Description: PGP signature


Bug#953878: libudev1-udeb: library wrongly shipped in the multiarch path

2020-03-14 Thread Aurelien Jarno
Package: systemd
Version: 245-2
Severity: normal
Tags: patch

libudev1-udeb ships the libudev.so.1 in the multiarch path:

| $ dpkg -c libudev1-udeb_245-2_amd64.udeb
| drwxr-xr-x root/root 0 2020-03-12 12:55 ./
| drwxr-xr-x root/root 0 2020-03-12 12:55 ./lib/
| drwxr-xr-x root/root 0 2020-03-12 12:55 ./lib/x86_64-linux-gnu/
| -rw-r--r-- root/root174144 2020-03-12 12:55 
./lib/x86_64-linux-gnu/libudev.so.1.6.17
| lrwxrwxrwx root/root 0 2020-03-12 12:55 
./lib/x86_64-linux-gnu/libudev.so.1 -> libudev.so.1.6.17

udeb packages should ship the library in the non-multiarch path, i.e.
/lib or /usr/lib. Otherwise this causes mklibs to fetch the library from
the system instead of the udeb and increases the size of d-i image
(although compression helps a bit there). This also prevent the removal
of mklibs from d-i, which will eventually want to do.

The patch below fixes the issue. Would it be possible to include it in
the next upload?

Thanks,
Aurelien

--- systemd-245/debian/libudev1-udeb.install
+++ systemd-245/debian/libudev1-udeb.install
@@ -1 +1 @@
-lib/*/libudev.so.*
+lib/*/libudev.so.* lib/

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-3-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled