Re: Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-30 Thread Bastian Blank
On Thu, Apr 30, 2020 at 11:41:44AM +0200, Bastian Blank wrote:
> The _other_ d-i parts are only looking in the specified directories in
> /usr/lib.

Okay, let's expand on this.

The following directories are part of the API of several d-i components:

- /usr/lib/post-base-installer.d/
- /usr/lib/pre-pkgsel.d/

The same is e.g. true for /usr/lib/apt/ (okay, maybe this was extended
to include /usr/libexec/apt/ as well in the meantime).

It is however irrelevant if this API is provided by a deb or udeb.  You,
as user of this API, can't just move a file from /usr/lib/x to
/usr/libexec/x and expect it to continue working.  This is an API
transition and needs to be coordinated.

I would assume this tag is in the pedantic pile for a reason:  You can't
just run, but need to think about it.

Bastian

-- 
If a man had a child who'd gone anti-social, killed perhaps, he'd still
tend to protect that child.
-- McCoy, "The Ultimate Computer", stardate 4731.3



Re: Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-30 Thread Bastian Blank
Hi Mattia

On Wed, Apr 29, 2020 at 06:40:07PM +0200, Mattia Rizzolo wrote:
> On Tue, Apr 28, 2020 at 11:38:44PM +0100, Steve McIntyre wrote:
> > ACK. d-i won't be looking in /usr/libexec. Please leave things where
> > they are...
> Good, then @lintian-maint: please exclude udebs from this check :)
> (as I think used to be in the past, since I don't think I saw this tag
> years ago in this package, but I know it has been there for a while…)

Why?  The tag is completely correct.

The _other_ d-i parts are only looking in the specified directories in
/usr/lib.

Bastian

-- 
But Captain -- the engines can't take this much longer!



Re: Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-29 Thread Mattia Rizzolo
On Tue, Apr 28, 2020 at 11:38:44PM +0100, Steve McIntyre wrote:
> ACK. d-i won't be looking in /usr/libexec. Please leave things where
> they are...

Good, then @lintian-maint: please exclude udebs from this check :)
(as I think used to be in the past, since I don't think I saw this tag
years ago in this package, but I know it has been there for a while…)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Re: Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-28 Thread Steve McIntyre
On Tue, Apr 28, 2020 at 11:49:56PM +0200, Mattia Rizzolo wrote:
>On Tue, Apr 28, 2020 at 02:39:49PM -0700, Felix Lechner wrote:
>> On Tue, Apr 28, 2020 at 4:27 AM Mattia Rizzolo  wrote:
>> > I'm CCing d-boot@ for confirmation, since I'm not sure if maybe I'm
>> > doing something wrong.
>> >
>> > Today I notices these tags:
>> >
>> > P: eatmydata-udeb udeb: executable-in-usr-lib 
>> > usr/lib/finish-install.d/13eatmydata-udeb
>> > N:
>> 
>> I expanded that odd tag description with some text from the original
>> bug report. I also adjusted the references. Perhaps the remark
>> regarding /usr/libexec is helpful:
>> 
>> The package ships an executable file in /usr/lib.
>> 
>> Please move the file to /usr/libexec.
>
>Not quite, as I'm positive those directories is where d-i go look for
>hooks, and I doubt just moving them to libexec is useful.
>
>I'm re-instating the CC on d-boot@ to see if it sparks some comment...

ACK. d-i won't be looking in /usr/libexec. Please leave things where
they are...

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
"War does not determine who is right - only who is left."
   -- Bertrand Russell



Re: Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-28 Thread Mattia Rizzolo
On Tue, Apr 28, 2020 at 02:39:49PM -0700, Felix Lechner wrote:
> On Tue, Apr 28, 2020 at 4:27 AM Mattia Rizzolo  wrote:
> > I'm CCing d-boot@ for confirmation, since I'm not sure if maybe I'm
> > doing something wrong.
> >
> > Today I notices these tags:
> >
> > P: eatmydata-udeb udeb: executable-in-usr-lib 
> > usr/lib/finish-install.d/13eatmydata-udeb
> > N:
> 
> I expanded that odd tag description with some text from the original
> bug report. I also adjusted the references. Perhaps the remark
> regarding /usr/libexec is helpful:
> 
> The package ships an executable file in /usr/lib.
> 
> Please move the file to /usr/libexec.

Not quite, as I'm positive those directories is where d-i go look for
hooks, and I doubt just moving them to libexec is useful.

I'm re-instating the CC on d-boot@ to see if it sparks some comment...

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#959037: lintian: FPOS? for executable-in-usr-lib

2020-04-28 Thread Mattia Rizzolo
Package: lintian
Version: 2.68.0
X-Debbugs-Cc: debian-boot@lists.debian.org

Hi,

I'm CCing d-boot@ for confirmation, since I'm not sure if maybe I'm
doing something wrong.

Today I notices these tags:

P: eatmydata-udeb udeb: executable-in-usr-lib 
usr/lib/finish-install.d/13eatmydata-udeb
N:
N:policy, 9.1.1,
N:https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html
N:
N:Severity: pedantic
N:
N:Check: usr/lib
N:
P: eatmydata-udeb udeb: executable-in-usr-lib 
usr/lib/post-base-installer.d/01eatmydata-udeb
P: eatmydata-udeb udeb: executable-in-usr-lib 
usr/lib/pre-pkgsel.d/10eatmydata-udeb


That being an udeb I know many things don't apply to it, but I'm not
sure if maybe I hsould place those d-i hooks elsewhere.

If, as I think, they are in the right place, please teach lintian to
ignore that in udebs.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature