Bug#98439: fixed in cvs

[Philip Blundell]

The culprit here, according to cvs annotate, anyhow, was Phil Blundell
[EMAIL PROTECTED], who wrote the include_module routine to ignore
failure.  Bad idea!

Actually, I think the behaviour goes back further than that.  Even in potato, 
we have:

if [ -f modules$revext.tgz ]  tar tvzf modules$revext.tgz | grep /af_packet.o 
/dev/null 21; then
info including af_packet.o from modules$revext.tgz
mkdir -p $mnt/lib/modules/misc
tar xOzf modules$revext.tgz lib/modules/\*/misc/af_packet.o  
$mnt/lib/modules/misc/af_packet.o
fi

But I can't think of any good reason for modules.tgz not to exist at this 
point.

p.




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#98439: fixed in cvs

[Adam Di Carlo]

Matt Kraai [EMAIL PROTECTED] writes:

 There is already code in rootdisk.sh to place the af_packet.o
 module on the root floppy, and code in /etc/init.d/rcS to insert
 the module.  It isn't included on the root floppy because the
 module is extracted from modules.tgz, but the dependencies don't
 ensure that this file is built before the root floppy.  I updated
 the dependencies, which should fix this problem.

*smooch*

Well, my changes to rootdisk.sh will at least cause the damn thing to
fail if the modules*.tgz file isn't there.

Please add your changelog (I added one for you already, the libfdisk
thing).

The culprit here, according to cvs annotate, anyhow, was Phil Blundell
[EMAIL PROTECTED], who wrote the include_module routine to ignore
failure.  Bad idea!

Lesson: fail on failure please, do not roll merrily along!

-- 
.Adam Di [EMAIL PROTECTED]URL:http://www.onshored.com/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#98439: fixed in cvs

[Matt Kraai]

Howdy,

There is already code in rootdisk.sh to place the af_packet.o
module on the root floppy, and code in /etc/init.d/rcS to insert
the module.  It isn't included on the root floppy because the
module is extracted from modules.tgz, but the dependencies don't
ensure that this file is built before the root floppy.  I updated
the dependencies, which should fix this problem.

Matt


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]