Re: cvs commit to base-config by barbier

2004-03-12 Thread Petter Reinholdtsen
 Store locale in /etc/environment when it is different from en_US.
 Closes: #237387

Good idea, but bad implementation.

 +   [ -f $environment ] || [ $locale = en_US ] || echo LANG=$locale  
 $environment

This one will remove the current content of /etc/environment.  That is
a bad idea.  It should append or replace the LANG variable instead.

Debian-edu store http_proxy and ftp_proxy variables in
/etc/environment.  It is a bad idea to remove them just to update the
LANG setting.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: cvs commit to base-config by barbier

2004-03-12 Thread Denis Barbier
On Fri, Mar 12, 2004 at 10:37:01AM +0100, Petter Reinholdtsen wrote:
  Store locale in /etc/environment when it is different from en_US.
  Closes: #237387
 
 Good idea, but bad implementation.
 
  +   [ -f $environment ] || [ $locale = en_US ] || echo LANG=$locale  
  $environment
 
 This one will remove the current content of /etc/environment.

No, unless I am mistaken, this is equivalent to
  [ ! -f $environment ]  [ $locale != en_US ]  echo LANG=$locale  $environment

 That is a bad idea.  It should append or replace the LANG variable
 instead.
 Debian-edu store http_proxy and ftp_proxy variables in
 /etc/environment.  It is a bad idea to remove them just to update the
 LANG setting.

So writing all variables at the same time is the simplest solution.
How do you create /etc/environment?

Denis


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]