Bug#653711: force __FAVOR_BSD in netinet/tcp.h and netinet/udp.h

2011-12-30 Thread Robert Millan
Package: libbsd-dev
Severity: wishlist
Tags: patch

El 25 de desembre de 2011 11:56, Robert Millan r...@debian.org ha escrit:
 +#define __FAVOR_BSD 1
  #include netinet/in_systm.h
  #include netinet/in.h
  #include netinet/ip.h
  #include netinet/ip_icmp.h
  #include netinet/tcp.h
  #include netinet/udp.h
 +#undef __FAVOR_BSD

 Shouldn't this kind of fix be in libbsd-dev?  E.g. in overlay netinet/in.h:

 #if __FAVOR_BSD
 #  include_next netinet/in.h
 #else
 #  define __FAVOR_BSD 1
 #  include_next netinet/in.h
 #  undef __FAVOR_BSD
 #endif

Let's make a bug out of this.  Patch attached.

-- 
Robert Millan
--- /dev/null
+++ b/include/bsd/netinet/tcp.h
@@ -0,0 +1,8 @@
+#include features.h
+#if __FAVOR_BSD
+#  include_next netinet/tcp.h
+#else
+#  define __FAVOR_BSD 1
+#  include_next netinet/tcp.h
+#  undef __FAVOR_BSD
+#endif
--- /dev/null
+++ b/include/bsd/netinet/udp.h
@@ -0,0 +1,8 @@
+#include features.h
+#if __FAVOR_BSD
+#  include_next netinet/udp.h
+#else
+#  define __FAVOR_BSD 1
+#  include_next netinet/udp.h
+#  undef __FAVOR_BSD
+#endif


Bug#653193: Missing patch

2011-12-30 Thread Robert Millan
El 25 de desembre de 2011 0:16, Christoph Egger christ...@debian.org
ha escrit:
 Hi!

 seems svn diff didn't include the new patch 14_alias.diff. Here it is.

The get-orig-source bits are also missing from the patch.

Btw, do you receive my mail also directly or only via list/BTS?  I
suspect my direct mails to you are being lost.

-- 
Robert Millan



-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caofdtxon5x0_aurfp-curr3mwoq8cac8g6ogr0a3fdg7m2t...@mail.gmail.com



Re: Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security

2011-12-30 Thread Steven Chamberlain
On 30/12/11 21:49, Steven Chamberlain wrote:
 ntp is now failing to build on the kfreebsd-* arches.

Argh!  I had the wrong version of the source package.  Most of the fixes
in my last mail are already applied (as per #542721, #627403) -- but
there are two places where some (apparently kfreebsd-specific) code was
not covered by Colin Watson's existing format-security.patch

This explains why build failures occurred only on kfreebsd arches.

My new patch (attached) fixes only those parts, and I am now able to
build successfully on kfreebsd-i386.

Thanks!

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org
Index: ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c
===
--- ntp-4.2.6.p3+dfsg.orig/lib/isc/unix/ifiter_sysctl.c	2010-12-25 09:40:35.0 +
+++ ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c	2011-12-30 20:30:25.0 +
@@ -272,10 +272,11 @@
 
 		return (ISC_R_SUCCESS);
 	} else {
-		printf(isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
-  ISC_MSG_UNEXPECTEDTYPE,
-  warning: unexpected interface list 
-  message type\n));
+		fprintf(stdout, %s,
+		isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
+   ISC_MSG_UNEXPECTEDTYPE,
+   warning: unexpected interface list 
+   message type\n));
 		return (ISC_R_IGNORE);
 	}
 }
Index: ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c
===
--- ntp-4.2.6.p3+dfsg.orig/ntpd/refclock_oncore.c	2010-12-25 09:40:34.0 +
+++ ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c	2011-12-30 20:37:33.0 +
@@ -4058,7 +4058,7 @@
 
 	snprintf(Msg, sizeof(Msg), ONCORE[%d]: %s, instance-unit,
 		 msg);
-	syslog(log_level, Msg);
+	syslog(log_level, %s, Msg);
 
 	i = strlen(msg);
 


Bug#631639: __unused in libbsd. workaround for #522773 (linux) and #522774 (libc)

2011-12-30 Thread Guillem Jover
On Sat, 2011-06-25 at 17:24:00 +, Thorsten Glaser wrote:
 That won’t help. The overlay mode uses pkg-config which no BSD thing
 touches.

Well, even OpenBSD has its own re-implementation:

  
http://www.openbsd.org/cgi-bin/man.cgi?query=pkg-configsektion=1format=html

regards,
guillem



--
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111231013742.ga23...@gaara.hadrons.org